From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60E3CC433FE for ; Mon, 28 Nov 2022 04:06:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DCEFF6B0072; Sun, 27 Nov 2022 23:06:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D58CE6B0073; Sun, 27 Nov 2022 23:06:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BFA746B0074; Sun, 27 Nov 2022 23:06:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B08996B0072 for ; Sun, 27 Nov 2022 23:06:43 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8CDFCAAEEF for ; Mon, 28 Nov 2022 04:06:43 +0000 (UTC) X-FDA: 80181514686.18.C0F6D8B Received: from formenos.hmeau.com (helcar.hmeau.com [216.24.177.18]) by imf27.hostedemail.com (Postfix) with ESMTP id 1D20740008 for ; Mon, 28 Nov 2022 04:06:42 +0000 (UTC) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1ozVPc-001OkT-0q; Mon, 28 Nov 2022 12:06:33 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Mon, 28 Nov 2022 12:06:32 +0800 Date: Mon, 28 Nov 2022 12:06:32 +0800 From: Herbert Xu To: Catalin Marinas Cc: Ard Biesheuvel , Will Deacon , Marc Zyngier , Arnd Bergmann , Greg Kroah-Hartman , Andrew Morton , Linus Torvalds , Linux Memory Management List , Linux ARM , Linux Kernel Mailing List , "David S. Miller" , Linux Crypto Mailing List Subject: Re: [v2 PATCH 3/9] crypto: aead - Add ctx helpers with DMA alignment Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669608403; a=rsa-sha256; cv=none; b=D1vIkM6svFMDm4yeQi5NJIBQo+z57mpQdeme4RKBY1QJ+q0x+xv2s5VB3dXgjtnD0Lf37C qdm3vgO+L1R96iAwjIMfJn4uLadXXoRaIWDWO/f2dTGWSIzKvX+l5RhC5IqXia6RkK1CmM 6xqbAqNHkChsh+iJLF42tj3U8/rEgLE= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf27.hostedemail.com: domain of herbert@gondor.apana.org.au designates 216.24.177.18 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669608403; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gQ/Nc/2E8ou/O5WgJCsP2tIaC0ukAyI1jUO7d27Yl0M=; b=cARiiCXlHT6TwOuMDdNE9a+LHuTrHEPkuErafnYm0AQX4AriJ5kklsD//zKHAjZ4kslU1U qzRB3ue2KynYmoDQFiEJk5SiGQLFED71+YJ1bVRcm1oSmLoulMbYSaIFndxRsqw3u7wBJU x+GR6OrA43cMHfNFB2n+yg8oL6pH+W4= X-Rspam-User: Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf27.hostedemail.com: domain of herbert@gondor.apana.org.au designates 216.24.177.18 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au X-Stat-Signature: m1rdounxcjrk74mtckek4sjyqhp6o8uu X-Rspamd-Queue-Id: 1D20740008 X-Rspamd-Server: rspam12 X-HE-Tag: 1669608402-912754 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 25, 2022 at 12:24:31PM +0000, Catalin Marinas wrote: > > I wonder, if drivers end up calling this, isn't it easier to do the > alignment in crypto_aead_ctx() directly? There are over 300 callers (not > sure about the padding though, it may need still driver changes unless > we can add it to something like crypto_tfm_alg_alignmask()). Or is the > expectation that not all drivers need a DMA alignment? I'm only changing the specific drivers that map things from the ctx structures for DMA. So it's not as bad as a simple grep would suggest. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt