From: Herbert Xu <herbert@gondor.apana.org.au>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Ard Biesheuvel <ardb@kernel.org>, Will Deacon <will@kernel.org>,
Marc Zyngier <maz@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Subject: Re: [v2 PATCH 3/9] crypto: aead - Add ctx helpers with DMA alignment
Date: Mon, 28 Nov 2022 12:06:32 +0800 [thread overview]
Message-ID: <Y4QzyPgDPt11iHlM@gondor.apana.org.au> (raw)
In-Reply-To: <Y4Cz/xJKYbdOyjiB@arm.com>
On Fri, Nov 25, 2022 at 12:24:31PM +0000, Catalin Marinas wrote:
>
> I wonder, if drivers end up calling this, isn't it easier to do the
> alignment in crypto_aead_ctx() directly? There are over 300 callers (not
> sure about the padding though, it may need still driver changes unless
> we can add it to something like crypto_tfm_alg_alignmask()). Or is the
> expectation that not all drivers need a DMA alignment?
I'm only changing the specific drivers that map things from the ctx
structures for DMA. So it's not as bad as a simple grep would suggest.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2022-11-28 4:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 4:35 [v2 PATCH 0/9] crypto: Add helpers for allocating " Herbert Xu
2022-11-25 4:36 ` [v2 PATCH 1/9] crypto: Prepare to move crypto_tfm_ctx Herbert Xu
2022-11-25 4:36 ` [v2 PATCH 2/9] crypto: api - Add crypto_tfm_ctx_dma Herbert Xu
2022-11-25 11:31 ` Catalin Marinas
2022-11-28 3:59 ` Herbert Xu
2022-11-25 4:36 ` [v2 PATCH 3/9] crypto: aead - Add ctx helpers with DMA alignment Herbert Xu
2022-11-25 12:24 ` Catalin Marinas
2022-11-28 4:06 ` Herbert Xu [this message]
2022-11-25 4:36 ` [v2 PATCH 4/9] crypto: hash " Herbert Xu
2022-11-25 4:36 ` [v2 PATCH 5/9] crypto: skcipher " Herbert Xu
2022-11-25 4:36 ` [v2 PATCH 6/9] crypto: api - Increase MAX_ALGAPI_ALIGNMASK to 127 Herbert Xu
2022-11-25 4:36 ` [v2 PATCH 7/9] crypto: akcipher - Add ctx helpers with DMA alignment Herbert Xu
2022-11-25 4:36 ` [v2 PATCH 8/9] crypto: kpp " Herbert Xu
2022-11-25 4:36 ` [v2 PATCH 9/9] crypto: caam - Set DMA alignment explicitly Herbert Xu
2022-11-25 12:17 ` [v2 PATCH 0/9] crypto: Add helpers for allocating with DMA alignment Ard Biesheuvel
2022-11-28 4:05 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4QzyPgDPt11iHlM@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maz@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox