From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D60AC433FE for ; Mon, 28 Nov 2022 06:07:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BC6606B0072; Mon, 28 Nov 2022 01:07:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B77166B0073; Mon, 28 Nov 2022 01:07:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A3F466B0074; Mon, 28 Nov 2022 01:07:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 943346B0072 for ; Mon, 28 Nov 2022 01:07:31 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 64548160CDB for ; Mon, 28 Nov 2022 06:07:31 +0000 (UTC) X-FDA: 80181819102.16.A43353F Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf08.hostedemail.com (Postfix) with ESMTP id B5E0E16000F for ; Mon, 28 Nov 2022 06:07:30 +0000 (UTC) Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2AS2CQOa025596; Mon, 28 Nov 2022 06:07:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=PjT+MfJJ3/eFkYXjY/kO+PmNcQCtw/hZMgnEnTpWVUE=; b=rVoKjTHNvMUd9wAIEHCBlfezLg4cZ+/3trV53cItcanTZvQtTOCg74DMaAn/QiwUGuTN FyeDH40Qn6gYFhn/rt2sydNwln95q4cq7Jkr2Ix8XIlcS91oFspQVivNMErBqtB+/X4n jAyXf43eXihjfu5H//104pImWPpXs33kAvKiNAG3yy+oFpQUe6VF8OlHYcBRc/OIAxL7 7DT0NahkY2MMG5mMA+uKy9Vo5dlvC7LzcUdhr7MqL+fMR2cvkeG4mLTX3XwAClXvDFuE pf2ilMn74miCalpP2HwfpQqG5jxeTr1jXBcnKmcT3O2oFnPyJXw3sZsIjDv9W9vO1bA9 VQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3m3vnnxuv9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 28 Nov 2022 06:07:27 +0000 Received: from m0127361.ppops.net (m0127361.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 2AS5jegh001876; Mon, 28 Nov 2022 06:07:27 GMT Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3m3vnnxuus-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 28 Nov 2022 06:07:27 +0000 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 2AS67PGj024064; Mon, 28 Nov 2022 06:07:25 GMT Received: from b06avi18626390.portsmouth.uk.ibm.com (b06avi18626390.portsmouth.uk.ibm.com [9.149.26.192]) by ppma03ams.nl.ibm.com with ESMTP id 3m3ae9a0pf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 28 Nov 2022 06:07:25 +0000 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2AS60vDe3408466 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 28 Nov 2022 06:00:57 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5B4BD4203F; Mon, 28 Nov 2022 06:07:22 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DFB3142042; Mon, 28 Nov 2022 06:07:21 +0000 (GMT) Received: from li-4a3a4a4c-28e5-11b2-a85c-a8d192c6f089.ibm.com (unknown [9.145.84.206]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Mon, 28 Nov 2022 06:07:21 +0000 (GMT) Date: Mon, 28 Nov 2022 07:07:20 +0100 From: Alexander Gordeev To: Anshuman Khandual Cc: linux-mm@kvack.org, Christian Borntraeger , David Hildenbrand , Heiko Carstens , Andrew Morton , kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] s390/mm: Use pmd_pgtable_page() helper in __gmap_segment_gaddr() Message-ID: References: <20221125034502.1559986-1-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221125034502.1559986-1-anshuman.khandual@arm.com> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: H_ZeDN8WWMpM6hhRfHv3uOHEfKUsSV0l X-Proofpoint-GUID: YLYRH3nZvkEDWY5MrgI78-BPk0TOQjqi X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-28_04,2022-11-25_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 bulkscore=0 spamscore=0 phishscore=0 suspectscore=0 adultscore=0 lowpriorityscore=0 mlxscore=0 impostorscore=0 clxscore=1011 mlxlogscore=745 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211280043 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669615651; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PjT+MfJJ3/eFkYXjY/kO+PmNcQCtw/hZMgnEnTpWVUE=; b=7FY1K2zfl2f5FAm9o2juHJS34W9Bc9CpU2IITpH//0CCgrNsV97+XL1PFnt9N6/KWJxf67 diASYJpcub9blkr6nW/h/POYOO6Uu8kTneU+/zgAPiBBjWk/yBeN0k2TjL3rQal/P7VNwG Nj3ddg1NLrb/fqMTYH/dCWfNYNL2VV4= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=rVoKjTHN; spf=pass (imf08.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669615651; a=rsa-sha256; cv=none; b=aCqWN3Zw8Vc/kZj9mbcLAc/ZN7Jw9gkxRf/HxLyBXRdgvN4n9CZcxiJUAUAp1+BPQYPmxi Bc5YpZqnSbsGjNe48JYZ8A85d4bebvTNbbqbXe0ABq96U1vZ6fHAH7fC+3xZ8imqJSuqZa M+fVF3MUI08yZ3JrzZEApZlzxLDbnfk= X-Stat-Signature: e954eqw9b9o4oudtqh69nngi6w17jb3p X-Rspamd-Queue-Id: B5E0E16000F Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=rVoKjTHN; spf=pass (imf08.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1669615650-901847 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 25, 2022 at 09:15:02AM +0530, Anshuman Khandual wrote: Hi Anshuman, > In __gmap_segment_gaddr() pmd level page table page is being extracted from > the pmd pointer, similar to pmd_pgtable_page() implementation. This reduces > some redundancy by directly using pmd_pgtable_page() instead, though first > making it available. [...] > diff --git a/arch/s390/mm/gmap.c b/arch/s390/mm/gmap.c > index 02d15c8dc92e..8947451ae021 100644 > --- a/arch/s390/mm/gmap.c > +++ b/arch/s390/mm/gmap.c > @@ -336,12 +336,11 @@ static int gmap_alloc_table(struct gmap *gmap, unsigned long *table, > static unsigned long __gmap_segment_gaddr(unsigned long *entry) > { > struct page *page; > - unsigned long offset, mask; > + unsigned long offset; > > offset = (unsigned long) entry / sizeof(unsigned long); > offset = (offset & (PTRS_PER_PMD - 1)) * PMD_SIZE; > - mask = ~(PTRS_PER_PMD * sizeof(pmd_t) - 1); > - page = virt_to_page((void *)((unsigned long) entry & mask)); > + page = pmd_pgtable_page((pmd_t *) entry); > return page->index + offset; > } Looks okay to me. > diff --git a/include/linux/mm.h b/include/linux/mm.h > index e9e387caffac..5ead9e997510 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -2403,7 +2403,7 @@ static inline void pgtable_pte_page_dtor(struct page *page) > > #if USE_SPLIT_PMD_PTLOCKS > > -static struct page *pmd_pgtable_page(pmd_t *pmd) > +static inline struct page *pmd_pgtable_page(pmd_t *pmd) > { > unsigned long mask = ~(PTRS_PER_PMD * sizeof(pmd_t) - 1); > return virt_to_page((void *)((unsigned long) pmd & mask)); This chunk does not appear to belong to this patch. Thanks!