From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B4C9C4332F for ; Fri, 25 Nov 2022 12:24:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD5626B0071; Fri, 25 Nov 2022 07:24:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A5DE06B0072; Fri, 25 Nov 2022 07:24:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 926A16B0073; Fri, 25 Nov 2022 07:24:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7F4BB6B0071 for ; Fri, 25 Nov 2022 07:24:40 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4935280809 for ; Fri, 25 Nov 2022 12:24:40 +0000 (UTC) X-FDA: 80171883120.23.CA2930E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id D3A954000D for ; Fri, 25 Nov 2022 12:24:38 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F00D362369; Fri, 25 Nov 2022 12:24:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 41C99C433C1; Fri, 25 Nov 2022 12:24:34 +0000 (UTC) Date: Fri, 25 Nov 2022 12:24:31 +0000 From: Catalin Marinas To: Herbert Xu Cc: Ard Biesheuvel , Will Deacon , Marc Zyngier , Arnd Bergmann , Greg Kroah-Hartman , Andrew Morton , Linus Torvalds , Linux Memory Management List , Linux ARM , Linux Kernel Mailing List , "David S. Miller" , Linux Crypto Mailing List Subject: Re: [v2 PATCH 3/9] crypto: aead - Add ctx helpers with DMA alignment Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669379078; a=rsa-sha256; cv=none; b=onQIYsm3V/aDWDjqkWAO2w2hZnO2YPXUZLhUcF02LAs0jwxAdTc3lPx/vprLGrwuhfOMun HKF06Um6tH2x6YBuuvfLKT3Xs82uuU/SSbFZ5z6kui0OylTACdWwOzFK2MIAt9D+4+9zV8 bfZwuv2k5t+OaeFNNEdVShHbPpuNfZM= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf04.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669379078; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tI2kKxlk1ZsrIbNTPUevG3vzRNsLr3eI1gEKxUMRLfw=; b=06paaxUoCpVjM1HbZQDxPg9JjNOig2uBQf7aUOdx4Mq/UVfb/+6B1C9FgrjqN4WHn7J9cp DAlSv/v/4gewV4SQ4IuKIlXF+RvaFDwRMvcByPoq1Xudz0tbvneB2nzky4JonmNzvo6kKG QfG90zs1Z2wZ5w7J8NWezuPwMdKK8P0= X-Rspamd-Queue-Id: D3A954000D X-Stat-Signature: n4q66r9ut7an3zezr1fba8kxqgb19zsh X-Rspam-User: Authentication-Results: imf04.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf04.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org X-Rspamd-Server: rspam09 X-HE-Tag: 1669379078-793427 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 25, 2022 at 12:36:33PM +0800, Herbert Xu wrote: > diff --git a/include/crypto/internal/aead.h b/include/crypto/internal/aead.h > index d482017f3e20..cd8cb1e921b7 100644 > --- a/include/crypto/internal/aead.h > +++ b/include/crypto/internal/aead.h > @@ -39,6 +39,11 @@ static inline void *crypto_aead_ctx(struct crypto_aead *tfm) > return crypto_tfm_ctx(&tfm->base); > } > > +static inline void *crypto_aead_ctx_dma(struct crypto_aead *tfm) > +{ > + return crypto_tfm_ctx_dma(&tfm->base); > +} I wonder, if drivers end up calling this, isn't it easier to do the alignment in crypto_aead_ctx() directly? There are over 300 callers (not sure about the padding though, it may need still driver changes unless we can add it to something like crypto_tfm_alg_alignmask()). Or is the expectation that not all drivers need a DMA alignment? -- Catalin