From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14980C4332F for ; Fri, 25 Nov 2022 11:32:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 88A546B0071; Fri, 25 Nov 2022 06:32:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8120A6B0072; Fri, 25 Nov 2022 06:32:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B2E26B0073; Fri, 25 Nov 2022 06:32:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 578B26B0071 for ; Fri, 25 Nov 2022 06:32:04 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2C2101A0273 for ; Fri, 25 Nov 2022 11:32:04 +0000 (UTC) X-FDA: 80171750568.17.55B9A98 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf25.hostedemail.com (Postfix) with ESMTP id 943F5A0017 for ; Fri, 25 Nov 2022 11:32:03 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9D8B5623AE; Fri, 25 Nov 2022 11:32:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7B1DC433D6; Fri, 25 Nov 2022 11:31:59 +0000 (UTC) Date: Fri, 25 Nov 2022 11:31:56 +0000 From: Catalin Marinas To: Herbert Xu Cc: Ard Biesheuvel , Will Deacon , Marc Zyngier , Arnd Bergmann , Greg Kroah-Hartman , Andrew Morton , Linus Torvalds , Linux Memory Management List , Linux ARM , Linux Kernel Mailing List , "David S. Miller" , Linux Crypto Mailing List Subject: Re: [v2 PATCH 2/9] crypto: api - Add crypto_tfm_ctx_dma Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669375923; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Gy3ynE+iWXuqYXQMsuj6fo8+nMLRPGdXWfmT8cxJ9rc=; b=Fy4CpjZaWXY1gwl3nkWRMkzzhfRc0XEiukgQ+u8j+AwWouddXYvBQm7jTCCwK0TwJl+Xlr Y6RiUtJu0KuaqKY3ZmSY4gGwwv+BPOoF26bWVP2hZUkA9lpm2ScAxCMDiXZ70JXa1SXXcB mE7yzFxb4Rc3SLrxVvttjRxvSDPTm8k= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf25.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669375923; a=rsa-sha256; cv=none; b=gF1kfH9Q0OnDIbBYCHJvjw/AZ4mLvojvbyp6knZw4m6NArDiU/sOE5+PhU5ASPvvL4gPqp vu1ruP9fVwSYDY1nqq54NTVdhgyYsFKdtMCskUooiNEt8abUw7hO9JoNrhj1B5oi6HJ+p9 b/3ZefHSdAy3tdcDX7d1V4nfxMiJZTo= X-Stat-Signature: 6ym7gsu7tukrxx9pdzqawgrxu18jwo8h X-Rspamd-Queue-Id: 943F5A0017 Authentication-Results: imf25.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf25.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1669375923-487088 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Herbert, Thanks for putting this together. I'll try to go through the series but my crypto knowledge is fairly limited. On Fri, Nov 25, 2022 at 12:36:31PM +0800, Herbert Xu wrote: > diff --git a/include/crypto/algapi.h b/include/crypto/algapi.h > index f50c5d1725da..4c99eb66e654 100644 > --- a/include/crypto/algapi.h > +++ b/include/crypto/algapi.h > @@ -7,6 +7,7 @@ > #ifndef _CRYPTO_ALGAPI_H > #define _CRYPTO_ALGAPI_H > > +#include > #include > #include > #include > @@ -25,6 +26,14 @@ > #define MAX_CIPHER_BLOCKSIZE 16 > #define MAX_CIPHER_ALIGNMASK 15 > > +#ifdef ARCH_DMA_MINALIGN > +#define CRYPTO_DMA_ALIGN ARCH_DMA_MINALIGN > +#else > +#define CRYPTO_DMA_ALIGN CRYPTO_MINALIGN > +#endif > + > +#define CRYPTO_DMA_PADDING ((CRYPTO_DMA_ALIGN - 1) & ~(CRYPTO_MINALIGN - 1)) Is the CRYPTO_DMA_PADDING used anywhere? I couldn't find it in this series and I'd rather drop it, together with CRYPTO_DMA_ALIGN (see below). > + > struct crypto_aead; > struct crypto_instance; > struct module; > @@ -189,10 +198,38 @@ static inline void crypto_xor_cpy(u8 *dst, const u8 *src1, const u8 *src2, > } > } > > +static inline void *crypto_tfm_ctx(struct crypto_tfm *tfm) > +{ > + return tfm->__crt_ctx; > +} > + > +static inline void *crypto_tfm_ctx_align(struct crypto_tfm *tfm, > + unsigned int align) > +{ > + if (align <= crypto_tfm_ctx_alignment()) > + align = 1; > + > + return PTR_ALIGN(crypto_tfm_ctx(tfm), align); > +} > + > static inline void *crypto_tfm_ctx_aligned(struct crypto_tfm *tfm) > { > - return PTR_ALIGN(crypto_tfm_ctx(tfm), > - crypto_tfm_alg_alignmask(tfm) + 1); > + return crypto_tfm_ctx_align(tfm, crypto_tfm_alg_alignmask(tfm) + 1); >+} I had an attempt to make crypto_tfm_alg_alignmask() the larger of the cra_alignmask and ARCH_DMA_MINALIGN but for some reason the kernel started to panic, so I gave up. > + > +static inline unsigned int crypto_dma_align(void) > +{ > + return CRYPTO_DMA_ALIGN; > +} We have a generic dma_get_cache_alignment() function which currently is either 1 or ARCH_DMA_MINALIGN, if the latter is defined. My plan is to make eventually make this dynamic based on the actual cache line size (on most arm64 systems it would be 64 rather than 128). So could you use this instead of defining a CRYPTO_DMA_ALIGN? The only difference would be that dma_get_cache_alignment() returns 1 rather than ARCH_KMALLOC_MINALIGN if ARCH_DMA_MINALIGN is not defined, but I don't think that's an issue. > + > +static inline unsigned int crypto_dma_padding(void) > +{ > + return (crypto_dma_align() - 1) & ~(crypto_tfm_ctx_alignment() - 1); > +} > + > +static inline void *crypto_tfm_ctx_dma(struct crypto_tfm *tfm) > +{ > + return crypto_tfm_ctx_align(tfm, crypto_dma_align()); > } These would need to cope with crypto_dma_align() < ARCH_KMALLOC_MINALIGN. I think that's fine, the padding will be 0 if crypto_dma_align() is 1. -- Catalin