From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA3F0C352A1 for ; Tue, 6 Dec 2022 16:04:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5446E8E0003; Tue, 6 Dec 2022 11:04:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F3998E0001; Tue, 6 Dec 2022 11:04:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3BB598E0003; Tue, 6 Dec 2022 11:04:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2A06C8E0001 for ; Tue, 6 Dec 2022 11:04:54 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 035A8140A12 for ; Tue, 6 Dec 2022 16:04:53 +0000 (UTC) X-FDA: 80212354908.09.886B91A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf03.hostedemail.com (Postfix) with ESMTP id 6FD3D20028 for ; Tue, 6 Dec 2022 16:04:53 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=UF60dVUP; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf03.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670342693; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DIs4qdJxwgUZZ8TYFxFEUujKTcC1aHKihMZ7v32qGRc=; b=ZHlYikFeT7mPHTiYA4+/aPxXVKtJbyKaEsi9fOPZ27K54UrG6u469wYWAROOJ5MlDfxV0N uIFx4Z4YXlUZA2cECFuX3BTBfXaWX5iyrPLFD/dLOLDsJcWR018Gttua86kpHS7vwpuk+J g099BxKolnqkR/zLnv3CDq6JldazoGo= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=UF60dVUP; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf03.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670342693; a=rsa-sha256; cv=none; b=tCNXQno4gmLQGY03to8BwIT6itWuxt5Bf2hYsQ1ge0+7NArahuaSJv8t9Mo7/TygzTvLxq ynMrYCt15txt/6rdznXwoHsswqibpTgsl0BB20MYsI3RAsYWRmWadE38rcPCpavsgHMfnV cqYiwGuDlrVvJqxjwC0OzeWUM3Bb6Yg= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 85DBD617C3; Tue, 6 Dec 2022 16:04:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 41BE8C433C1; Tue, 6 Dec 2022 16:04:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1670342691; bh=gLpDTa+rhIH8NgaAcvNWyhQOtMSJQxHMPFZgL9hpIWI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UF60dVUP/aF9XqgJKVxVlccO8WHFfVB+F8TBKwO1Ir+7+A95I+cWjyQ/89GNogrrJ VjewJijvOODIWPYGIFOs0lvI2Xjz9XWsL/cq/ERPHHWGhU2LzvwfIVFdbj69IdQTl4 Fwr55ea12m70z4dZfL7YmtW0+dTRXkv3sN2AlY4A= Date: Tue, 6 Dec 2022 17:04:49 +0100 From: Greg KH To: jeffxu@chromium.org Cc: skhan@linuxfoundation.org, keescook@chromium.org, akpm@linux-foundation.org, dmitry.torokhov@gmail.com, dverkamp@chromium.org, hughd@google.com, jeffxu@google.com, jorgelo@chromium.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, jannh@google.com, linux-hardening@vger.kernel.org, kernel test robot Subject: Re: [PATCH v5 3/6] mm/memfd: add MFD_NOEXEC_SEAL and MFD_EXEC Message-ID: References: <20221206152358.1966099-1-jeffxu@google.com> <20221206152358.1966099-4-jeffxu@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221206152358.1966099-4-jeffxu@google.com> X-Spamd-Result: default: False [2.21 / 9.00]; BAYES_HAM(-2.39)[89.12%]; IRL_BL_25(2.00)[52.25.139.140:received]; SUSPICIOUS_RECIPS(1.50)[]; SUBJECT_HAS_UNDERSCORES(1.00)[]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; BAD_REP_POLICIES(0.10)[]; TAGGED_RCPT(0.00)[]; ARC_NA(0.00)[]; RCPT_COUNT_TWELVE(0.00)[15]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_ALLOW(0.00)[linuxfoundation.org:s=korg]; MIME_TRACE(0.00)[0:+]; R_SPF_ALLOW(0.00)[+ip4:139.178.84.217]; DMARC_POLICY_ALLOW(0.00)[linuxfoundation.org,none]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_SOME(0.00)[]; DKIM_TRACE(0.00)[linuxfoundation.org:+]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; RCVD_COUNT_THREE(0.00)[3]; FROM_HAS_DN(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[] X-Rspamd-Queue-Id: 6FD3D20028 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: tfs91rjprb987w4em8f1en1bdfnydrhd X-HE-Tag: 1670342693-197795 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 06, 2022 at 03:23:55PM +0000, jeffxu@chromium.org wrote: > --- a/kernel/pid_namespace.c > +++ b/kernel/pid_namespace.c > @@ -110,6 +110,11 @@ static struct pid_namespace *create_pid_namespace(struct user_namespace *user_ns > ns->ucounts = ucounts; > ns->pid_allocated = PIDNS_ADDING; > > +#if defined(CONFIG_SYSCTL) && defined(CONFIG_MEMFD_CREATE) > + ns->memfd_noexec_scope = > + task_active_pid_ns(current)->memfd_noexec_scope; > +#endif .c files should never have #if in them. Can't you put this in a .h file properly so that this does not get really messy over time? > + > return ns; > > out_free_idr: > @@ -255,6 +260,45 @@ void zap_pid_ns_processes(struct pid_namespace *pid_ns) > return; > } > > +#if defined(CONFIG_SYSCTL) && defined(CONFIG_MEMFD_CREATE) Same here. thanks, greg k-h