From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DC07C352A1 for ; Tue, 6 Dec 2022 10:33:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 79B7B8E0002; Tue, 6 Dec 2022 05:33:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 74C7B8E0001; Tue, 6 Dec 2022 05:33:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 614438E0002; Tue, 6 Dec 2022 05:33:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 509648E0001 for ; Tue, 6 Dec 2022 05:33:17 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 297B880397 for ; Tue, 6 Dec 2022 10:33:17 +0000 (UTC) X-FDA: 80211519234.21.074EC2C Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf18.hostedemail.com (Postfix) with ESMTP id 349411C000A for ; Tue, 6 Dec 2022 10:33:14 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=dMNGtYEU; spf=pass (imf18.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670322795; a=rsa-sha256; cv=none; b=xFBP+IltEzmMWeyzlGQ4iDtabqTfokPu18qfOLrYsGfOy29uz4Y9Ns7Y8QihYEOfBnY9Lk EDtcGUDU9coYieCwoMJH78LWtSCBWOhco5Bbbwx2UF1o4Dt4UC0RAjGtTJVLHIqsrFfZnn wNc3uesnCy8SM+Uim9co3kinQww5E8o= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=dMNGtYEU; spf=pass (imf18.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670322795; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sXtB0LJ1gZ5Q2aHoxbN5D+rA1BRGWLH2LRyfAy0cNtA=; b=GqcVczCEgkPoOw9ZKBmWroAmt/ynfymnUlq0wxej8f6Vh12kjI2YX0Zm3bm3DyQo8iEouf ERgf4//ruEjrKX6LLV0DVaQZwfJouv6d4gRztTzQZedi+yld+6cEUWQtiJvIwn4vctfyfs Vy6uQQ6OQY0ORsb0drG60Riv5njaDPY= Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 83E571FE2B; Tue, 6 Dec 2022 10:33:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1670322793; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sXtB0LJ1gZ5Q2aHoxbN5D+rA1BRGWLH2LRyfAy0cNtA=; b=dMNGtYEU6bdKskTmQkpt4FcDRN92UcqQjVVtK9/Njg6YZcuhQ+6Hth69Qy2QWb6OjdEWXT r9M9rpzPKXzw3R5xaI5oSFSnd2bJKb/MkktHhJOec2h9PlWH/SejxdQyOXcdWRB6HLWHWa hVn+9lcsEhdTy/Y0D2XAsxyz9mYV+f0= Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 624AC132F3; Tue, 6 Dec 2022 10:33:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id 5MKmFWkaj2OnLgAAGKfGzw (envelope-from ); Tue, 06 Dec 2022 10:33:13 +0000 Date: Tue, 6 Dec 2022 11:33:12 +0100 From: Michal Hocko To: Shakeel Butt Cc: lirongqing@baidu.com, linux-mm@kvack.org, cgroups@vger.kernel.org, hannes@cmpxchg.org, roman.gushchin@linux.dev, songmuchun@bytedance.com, akpm@linux-foundation.org Subject: Re: [PATCH] mm: memcontrol: speedup memory cgroup resize Message-ID: References: <1670240992-28563-1-git-send-email-lirongqing@baidu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spamd-Result: default: False [-1.24 / 9.00]; DMARC_POLICY_ALLOW(-0.50)[suse.com,quarantine]; BAYES_HAM(-0.34)[69.87%]; R_DKIM_ALLOW(-0.20)[suse.com:s=susede1]; R_SPF_ALLOW(-0.20)[+a:smtp-out2.suse.de]; MIME_GOOD(-0.10)[text/plain]; RCVD_NO_TLS_LAST(0.10)[]; RCPT_COUNT_SEVEN(0.00)[8]; FROM_EQ_ENVFROM(0.00)[]; DKIM_TRACE(0.00)[suse.com:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[] X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 349411C000A X-Stat-Signature: qshwi7n55z74axhzqxqbieghrwnobq3y X-HE-Tag: 1670322794-45593 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 05-12-22 08:32:41, Shakeel Butt wrote: > On Mon, Dec 5, 2022 at 3:49 AM wrote: > > > > From: Li RongQing > > > > when resize memory cgroup, avoid to free memory cgroup page > > one by one, and try to free needed number pages once > > > > It's not really one by one but SWAP_CLUSTER_MAX. Also can you share > some experiment results on how much this patch is improving setting > limits? Besides a clear performance gain you should also think about a potential over reclaim when the limit is reduced by a lot (there might be parallel reclaimers competing with the limit resize). -- Michal Hocko SUSE Labs