From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6690CC433FE for ; Tue, 22 Nov 2022 12:51:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CB3138E0001; Tue, 22 Nov 2022 07:51:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C3C556B0075; Tue, 22 Nov 2022 07:51:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ADD578E0001; Tue, 22 Nov 2022 07:51:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A07776B0074 for ; Tue, 22 Nov 2022 07:51:32 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C4AC1A1001 for ; Tue, 22 Nov 2022 12:51:31 +0000 (UTC) X-FDA: 80161064382.21.C90F7A8 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf05.hostedemail.com (Postfix) with ESMTP id 67D0810000B for ; Tue, 22 Nov 2022 12:51:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=kqed8cf0rF+7M2izq/OCegTtCpnXXbVi+7tx8ySuLzQ=; b=wz/sjoR41PLdlCr51Yyiba68/j xYoBna2Wc0GaLJtCDl6BcuOXjzr5BEVDrXhYD/8DjCuBVdIT7y2PV2oruOVKxNbw4a93C9onW6LBp n6b+7z+opdNF9I0kFuh1xUi5pPldnv8f560Q4NLILIWlu4u0PfkpS+2IWbK3bBNiFIac+LdKU8N+y LcKBdYNAJt8nJ/ne6FDRMuVUqMoIJpzYUdi/aT7qqqpnPfknzsTGaeBgJFDCyn2AcuvwL8IcdEYsx MkQczJt4XI74ggYWkCbAGp0FDmORi6mjtR1YFV10KEyitirG9xuys6MX/smrOz6pSPCTyxMcQ9rYN 8OWYrT1g==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxSkH-009PqL-Ci; Tue, 22 Nov 2022 12:51:25 +0000 Date: Tue, 22 Nov 2022 04:51:25 -0800 From: Christoph Hellwig To: David Howells Cc: Al Viro , Christoph Hellwig , John Hubbard , Matthew Wilcox , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , Jeff Layton , linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 2/4] iov_iter: Add a function to extract a page list from an iterator Message-ID: References: <166869687556.3723671.10061142538708346995.stgit@warthog.procyon.org.uk> <166869689451.3723671.18242195992447653092.stgit@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <166869689451.3723671.18242195992447653092.stgit@warthog.procyon.org.uk> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669121491; a=rsa-sha256; cv=none; b=zzOFbFXdQulZ04mkLZHSg4c5Gxso7AOfMb2KWKV1ibRyO2s+x38Jk3+9WLp/kPfYfMKj1T TAd8Cabt/k9wP86xJ4OmLAhRKZl6KSsTcGy31umauLzvZeU8U8psc37kb/1Xg9CR7S0m32 f6sYh2rjT0w8sQflPPz4dpddUL66KRg= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="wz/sjoR4"; dmarc=none; spf=none (imf05.hostedemail.com: domain of BATV+ebc7d116b695001c1e40+7030+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+ebc7d116b695001c1e40+7030+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669121491; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kqed8cf0rF+7M2izq/OCegTtCpnXXbVi+7tx8ySuLzQ=; b=cAiIkRy6YkIj3PiZbZ+zG1ATHrGJNpt7IEaI8zqhRIRekvJWad5C8xkyaUuWx3wWdHZMAR W6tORq3WgNQUi2UlUaV5HM32s+uw1pgDM/qGXiN3kylOn9J5YBXOqsz+hjjAxU+9G0fDwb yMbBcQGUOXFPmbggfyzVTssMSXbQPPk= X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 67D0810000B X-Rspam-User: Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="wz/sjoR4"; dmarc=none; spf=none (imf05.hostedemail.com: domain of BATV+ebc7d116b695001c1e40+7030+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+ebc7d116b695001c1e40+7030+infradead.org+hch@bombadil.srs.infradead.org X-Stat-Signature: 5tzrcdsen7cc1oyfaizax4xrnahxsooq X-HE-Tag: 1669121491-888508 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 17, 2022 at 02:54:54PM +0000, David Howells wrote: > An additional function, iov_iter_extract_mode() is also provided so that the > mode of retention that will be employed for an iterator can be queried - and > therefore how the caller should dispose of the pages later. Any reason to not just add an out paramter to the main function and return this directly instead of an extra helper? > +EXPORT_SYMBOL(iov_iter_extract_pages); get_user_pages_fast, pin_user_pages_fast are very intentionally EXPORT_SYMBOL_GPL, which should not be bypassed by an iov_* wrapper.