From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2717AC433FE for ; Tue, 22 Nov 2022 16:41:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 726856B0071; Tue, 22 Nov 2022 11:41:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D7A16B0073; Tue, 22 Nov 2022 11:41:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 59EBF6B0074; Tue, 22 Nov 2022 11:41:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4C85E6B0071 for ; Tue, 22 Nov 2022 11:41:11 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 109DD410BE for ; Tue, 22 Nov 2022 16:41:10 +0000 (UTC) X-FDA: 80161643142.30.D351FE9 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf09.hostedemail.com (Postfix) with ESMTP id 8B96214000B for ; Tue, 22 Nov 2022 16:41:10 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 14CFF1FB; Tue, 22 Nov 2022 08:41:16 -0800 (PST) Received: from FVFF77S0Q05N.cambridge.arm.com (FVFF77S0Q05N.cambridge.arm.com [10.1.32.179]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8D5153F73D; Tue, 22 Nov 2022 08:41:08 -0800 (PST) Date: Tue, 22 Nov 2022 16:41:02 +0000 From: Mark Rutland To: Steven Rostedt Cc: kernel test robot , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Will Deacon , Florent Revest , "Masami Hiramatsu (Google)" Subject: Re: [linux-next:master 8539/9537] include/linux/ftrace.h:126:16: error: implicit declaration of function 'arch_ftrace_get_regs'; did you mean 'ftrace_get_regs'? Message-ID: References: <202211212249.livTPi3Y-lkp@intel.com> <20221121124015.31d34642@gandalf.local.home> <20221122103042.07c349ee@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221122103042.07c349ee@gandalf.local.home> ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; spf=pass (imf09.hostedemail.com: domain of mark.rutland@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=mark.rutland@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669135270; a=rsa-sha256; cv=none; b=cDNirth8NKQpjjJvakArGWYXtl6kIqTxuOidkMwLUfyZuA8JypFa7kQss9g8AGS8cgT3C5 TpH3cGDTeP35vxQ9bP21dOSrBnsCFJT+JHwTy0T6KT2VYycdX0JPKNm8WFqaId0T5SwGl1 g7s7EO6f27gA8MuE1AlakwbB251NHWc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669135270; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vHUt7OO7WLKuzYlp8T0SQguWsguKN3IiU/+Y6mThs38=; b=I1ttR/8YyNlH5gAZ/dsd2GaKbTjYmhwAn5p5BVEh5aCK014WUJEP6nNMCLMC3binuxc4UE NJ/hKyH7CTx8PqKkkRzVyI3A2hJT6JDuY60xHRl5m7D3O2yswYbXnRwEi0XerxUgIhiO4f a6y1FQrzwbPvFenzblA4zJLL/ySg/4Y= X-Rspamd-Queue-Id: 8B96214000B X-Rspam-User: Authentication-Results: imf09.hostedemail.com; dkim=none; spf=pass (imf09.hostedemail.com: domain of mark.rutland@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=mark.rutland@arm.com; dmarc=pass (policy=none) header.from=arm.com X-Rspamd-Server: rspam06 X-Stat-Signature: xtoy5cffymbmjt5ppj7k8gogapf3ppsg X-HE-Tag: 1669135270-6050 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 22, 2022 at 10:30:42AM -0500, Steven Rostedt wrote: > On Tue, 22 Nov 2022 15:13:39 +0000 > Mark Rutland wrote: > > > To be honest, we just didn't think to remove static ftrace; I'm happy to remove > > that for arm64. > > Please do. There's no reason for it. The *only* reason I keep it around on > x86 is to make sure it still works (for those other architectures > developing ftrace). I've sent that out as: https://lore.kernel.org/linux-arm-kernel/20221122163624.1225912-1-mark.rutland@arm.com/T/#u ... on the assumption Will can queue that as a fixup. > > That said, I still think it makes sense to change the code to check > > CONFIG_DYNAMIC_FTRACE_WITH_ARGS rather than > > CONFIG_HAVE_DYNAMIC_FTRACE_WITH_ARGS, as mentioned below, unless you intend for > > that to have an effect on static ftrace on x86? > > > > Everywhere else with DYNAMIC_FTRACE_WITH_ARGS forces DYNAMIC_FTRACE, so it ends > > up equivalent; x86 and arm64 are the only exceptions today. > > Yeah, looking at the code, I think it does make sense to just use > DYNAMIC_FTRACE_WITH_ARGS, as that was created to combine the other two > configs anyway. Great; I'll follow up with a cleanup patch once the above has settled. Thanks, Mark.