From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E659C433FE for ; Tue, 22 Nov 2022 10:45:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0DEB46B0075; Tue, 22 Nov 2022 05:45:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 08D796B0078; Tue, 22 Nov 2022 05:45:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EBE716B007B; Tue, 22 Nov 2022 05:45:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DC9F86B0075 for ; Tue, 22 Nov 2022 05:45:05 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B06E580EF7 for ; Tue, 22 Nov 2022 10:45:05 +0000 (UTC) X-FDA: 80160745770.18.CDAE49C Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by imf24.hostedemail.com (Postfix) with ESMTP id 2231A18000E for ; Tue, 22 Nov 2022 10:44:58 +0000 (UTC) Received: from zn.tnic (p200300ea9733e79b329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e79b:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 0631F1EC04E2; Tue, 22 Nov 2022 11:44:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1669113864; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=izVDKDv7Rl1i97cUDM6TUAYXEE94cHxeCRcaeu34Lpc=; b=eVUoi/0OHuA53lMtrGjsdYDHp5hLMccabq4+OoUJGJ1FsI7Bw0SSo5TnN7EiSYVkP+uTeU YRq1nJxO653ALTWHR635+ACjmdJCuBxPNWOHrtzBvDlusLgHvwYaT3/ewl+ymQKv1ColJ3 3RClyvioX09qkHn5g39bRQO3uwV6W7U= Date: Tue, 22 Nov 2022 11:44:23 +0100 From: Borislav Petkov To: "Kalra, Ashish" Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, michael.roth@amd.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, dgilbert@redhat.com, jarkko@kernel.org Subject: Re: [PATCH Part2 v6 14/49] crypto: ccp: Handle the legacy TMR allocation when SNP is enabled Message-ID: References: <3a51840f6a80c87b39632dc728dbd9b5dd444cd7.1655761627.git.ashish.kalra@amd.com> <380c9748-1c86-4763-ea18-b884280a3b60@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669113903; a=rsa-sha256; cv=none; b=CGRbL2IikJNPGB49qs5qujPh2ZDMKfsonu2kTqRQDjHTN7m3ytKH6mQqVjWNoSeeTKd069 7V6Js5TMRqg45hijSSbEQQvun5s0twQb3+VT5eMZuai7yB9xP4rfi403b2bJ1hgjVuF5gJ eDV6IpdgcBHLLf/KYxvIHfGgqDuWChQ= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=alien8.de header.s=dkim header.b="eVUoi/0O"; dmarc=pass (policy=none) header.from=alien8.de; spf=temperror (imf24.hostedemail.com: error in processing during lookup of bp@alien8.de: DNS error) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669113903; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=izVDKDv7Rl1i97cUDM6TUAYXEE94cHxeCRcaeu34Lpc=; b=BkbUKO7QoR8OEKdM4IhpRcCGTL4hWAjYicabd0qIy6PaUcq02lHmK/5+QZC0hIFlCWhs2e KIrjL7jMvMYS3hr6skdE5GxYjbCkBvp79tPlZ194Kgbi/urHHlXOBAtCE5kzguw1U3m1SF LhDggkRC3ZN41rpnLq6z7+J12tVAIT8= X-Stat-Signature: w11jsy5sd63f8gydjtdfrfa3fzr8u6an X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 2231A18000E Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=alien8.de header.s=dkim header.b="eVUoi/0O"; dmarc=pass (policy=none) header.from=alien8.de; spf=temperror (imf24.hostedemail.com: error in processing during lookup of bp@alien8.de: DNS error) smtp.mailfrom=bp@alien8.de X-Rspam-User: X-HE-Tag: 1669113898-502463 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 22, 2022 at 04:32:18AM -0600, Kalra, Ashish wrote: > Please note that in both cases, these non-reclaimed pages cannot be > freed/returned back to the page allocator. You keep repeating "these pages". Which pages? What if you specify the wrong, innocent pages because the kernel is wrong? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette