From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2315C433FE for ; Tue, 22 Nov 2022 06:35:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 11D1C6B0071; Tue, 22 Nov 2022 01:35:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0CD7F6B0073; Tue, 22 Nov 2022 01:35:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED7006B0074; Tue, 22 Nov 2022 01:35:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E14376B0071 for ; Tue, 22 Nov 2022 01:35:25 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B1FB5AB77A for ; Tue, 22 Nov 2022 06:35:25 +0000 (UTC) X-FDA: 80160116610.23.A9191E8 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf07.hostedemail.com (Postfix) with ESMTP id 485CF4000D for ; Tue, 22 Nov 2022 06:35:25 +0000 (UTC) Received: by mail-pl1-f181.google.com with SMTP id j12so12718916plj.5 for ; Mon, 21 Nov 2022 22:35:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=BZcw3xphyFpaMwrz2/RfL1TkxCNnDZvBvwaHcEozeVo=; b=gc9iRvo0HrISQTXfnCpl6IEX773OMidfAI9E+Bb7/VBj5N0v4YGejsaBNYalbQcr7P ca7cJyaLQXrWjybpdkYaCoP5dOAVQ9l0p2JXEr9RDeLXUB4dSPZyPOcWNGS2RPBynVBP Y803ZBp6/+ub5d150Lwt44vPD+OpF7ztHLoN0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BZcw3xphyFpaMwrz2/RfL1TkxCNnDZvBvwaHcEozeVo=; b=l7dE4l/HpCzdR/qtNnlsyFXhda2wiabh/BUvlP4dXsoSPqNA9doXv6bGUVqJ1GDIKX ZF4145BM4OccpoylqV9xv1vaHDbRor0LU7W7NoTlawIziw20TWAw6YhDrRDUby+4kqC6 C6TrjN97iJYWxJa+xdXZCcGTh+H/Xdp89Jw+x2K1/nuyS6y6qrXjmjSYv/akkDe7xVur gDNNYitCT3HA8OTPfzm9Ss9ny0GbtQGDCSRgfHpHPe2cmpd3TrZCHFyZ6E9p6EyQUdiY mvzoBskRttacXcgo4QXz1DRXtKS8MBlJ9d6cl7Evd9YzO5vpoQk7B22O+WqZnxLxHYBL YOGg== X-Gm-Message-State: ANoB5pmAKbSvKwcMHZ1zT3ciK6Tbk9hRHoyz717tHWpvzLxfid89TyGn l8zcCNSAWvXAvl7CLzFW124KhA== X-Google-Smtp-Source: AA0mqf7R9zv+5zht7rNwqMkVgWWExmmyK2xXlbenlYgDUv8aZO3AGFXUNg4nEe2uDHIGcItotOUx9w== X-Received: by 2002:a17:90b:2542:b0:1fb:e7a:79b with SMTP id nw2-20020a17090b254200b001fb0e7a079bmr30708699pjb.93.1669098924054; Mon, 21 Nov 2022 22:35:24 -0800 (PST) Received: from google.com ([240f:75:7537:3187:e258:71ac:37b7:2d52]) by smtp.gmail.com with ESMTPSA id c10-20020a170902d48a00b0016d9b101413sm1472468plg.200.2022.11.21.22.35.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Nov 2022 22:35:23 -0800 (PST) Date: Tue, 22 Nov 2022 15:35:18 +0900 From: Sergey Senozhatsky To: Johannes Weiner Cc: Sergey Senozhatsky , Nhat Pham , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, minchan@kernel.org, ngupta@vflare.org, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com Subject: Re: [PATCH v6 6/6] zsmalloc: Implement writeback mechanism for zsmalloc Message-ID: References: <20221119001536.2086599-1-nphamcs@gmail.com> <20221119001536.2086599-7-nphamcs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669098925; a=rsa-sha256; cv=none; b=mxhEmtw3ZGezC1S9cdfbL1M/kFLquAF49LLil7Cbm3uoXhz+y2N04Z6caqN7uko1YP0aw2 Ag4i3zXJ2NeEetyBllYrsBiD6/mtPm3KYKDtNWIMcfekLQF/wNhb1Z/3fgkt5V0ywuB1+F pX9x2f/PCHp3zdJdiH9JWKI24M6kKnw= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=gc9iRvo0; spf=pass (imf07.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.181 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669098925; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BZcw3xphyFpaMwrz2/RfL1TkxCNnDZvBvwaHcEozeVo=; b=6cHDC57S/d9rpFrTnkpDGqywkqg0G+L7/UEx/XpuKloEmY+F8GAyAEwTL7AJrCOVTI2jb1 xs05KoMtDITw91XjWNjvjyeMlt+Hy2rvpb5BsD6WC0kCCc0KO6VGF4VCHiMEPnB5WxpAgr QWMP6JiajB9KhGP51I4tlY8ruPrJNtc= X-Rspam-User: X-Rspamd-Queue-Id: 485CF4000D Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=gc9iRvo0; spf=pass (imf07.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.181 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Stat-Signature: r48hpgwkc65g4kw9fiynx1wr8ac7p8mq X-Rspamd-Server: rspam10 X-HE-Tag: 1669098925-138266 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000252, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (22/11/22 01:09), Johannes Weiner wrote: > On Tue, Nov 22, 2022 at 12:42:20PM +0900, Sergey Senozhatsky wrote: > > On (22/11/21 22:12), Johannes Weiner wrote: > > > On Tue, Nov 22, 2022 at 11:15:20AM +0900, Sergey Senozhatsky wrote: > > > > On (22/11/18 16:15), Nhat Pham wrote: [..] > > What I meant was: if zs_reclaim_page() makes only partial progress > > with the current LRU tail zspage and returns -EAGAIN, then we just > > don't increment `total` and continue looping in zs_zpool_shrink(). > > Hm, but it breaks on -EAGAIN, it doesn't continue. Yes. "What if it would continue". Would it make sense to not break on EAGAIN? while (total < pages) { ret = zs_reclaim_page(pool); if (ret == -EAGAIN) continue; if (ret < 0) break; total++; } Then we don't need retry loop in zs_reclaim_page().