From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB7EDC433FE for ; Tue, 22 Nov 2022 01:40:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 44F3B6B0071; Mon, 21 Nov 2022 20:40:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D8516B0073; Mon, 21 Nov 2022 20:40:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2790F8E0001; Mon, 21 Nov 2022 20:40:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 140976B0071 for ; Mon, 21 Nov 2022 20:40:21 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D45828095E for ; Tue, 22 Nov 2022 01:40:20 +0000 (UTC) X-FDA: 80159373000.15.1E5AB03 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) by imf02.hostedemail.com (Postfix) with ESMTP id 71CFD8000A for ; Tue, 22 Nov 2022 01:40:20 +0000 (UTC) Received: by mail-pg1-f175.google.com with SMTP id s196so12797840pgs.3 for ; Mon, 21 Nov 2022 17:40:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=OmViSLFa5OllJV9pTGQkDLSySpGZUy3VM35OK0GlOcI=; b=K/hom9CbYbypJIGnzVOs25efj4/6n5Eehpw46jqAGqFhcK66ntifEwFgtLbyYz/qnh /zmvTQDD74uBFlz9Fu+kD+asOqO+yNezeg3tXoPhzLLsOMBENOmibVsFJ5GO7+57hXc0 ytdwT9Yhs8eHoEgosmzLvEpacwy2I4nIQN1/s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OmViSLFa5OllJV9pTGQkDLSySpGZUy3VM35OK0GlOcI=; b=1vM3eV6ygUAZWrw/9IwBEhijRcGDA0MJfWZDGr7aV1YxKu6VYN/1ZVNukEMwz56hf2 dOPbg/H/Npefo1JYb3rKnAAFc3kX6Ws2KJDJk0lG2IhvXi6Go6Dsk4xwaE8PRO21+BNr WsQ0857/T0eSjUNAgm8Agb8rWlifxWxwueodu5kA2HOQdkEDfwqZQiBo4RxnYxd/c6gl 5ucmcM9rvqzkKVWZNsKZtJjxk/+y0ovDNsZ4vOxPEfaO0uWs0e7uwIjmhtJ8gvtZpyXc M2TBUYGbh8kcdWsx4b9yuWsQwyZ4cP8Z6uzCbyaHOXRoysWdhUkAatXkxtkwBwzS1CSI e63w== X-Gm-Message-State: ANoB5pngw09DM3XDP6md0FOngIIHfz/J/q9h8rGXDGCnSjQEYv4TZqqk +QACfKwJjNo4UbsCXv+3B+8XSQ== X-Google-Smtp-Source: AA0mqf4FhWFVIV3MNn2bOvl6m1yPm7gRKn6SNTWHXHYJ0R6v3cV3fqsy/Q7jRya/DTdCHn820x5chw== X-Received: by 2002:a63:1f65:0:b0:470:8e8d:44ae with SMTP id q37-20020a631f65000000b004708e8d44aemr4487308pgm.382.1669081219500; Mon, 21 Nov 2022 17:40:19 -0800 (PST) Received: from google.com ([240f:75:7537:3187:e258:71ac:37b7:2d52]) by smtp.gmail.com with ESMTPSA id t20-20020a17090a951400b001fb1de10a4dsm7962686pjo.33.2022.11.21.17.40.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Nov 2022 17:40:19 -0800 (PST) Date: Tue, 22 Nov 2022 10:40:14 +0900 From: Sergey Senozhatsky To: Nhat Pham Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, minchan@kernel.org, ngupta@vflare.org, senozhatsky@chromium.org, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com Subject: Re: [PATCH v6 6/6] zsmalloc: Implement writeback mechanism for zsmalloc Message-ID: References: <20221119001536.2086599-1-nphamcs@gmail.com> <20221119001536.2086599-7-nphamcs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221119001536.2086599-7-nphamcs@gmail.com> ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="K/hom9Cb"; spf=pass (imf02.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.215.175 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669081220; a=rsa-sha256; cv=none; b=1MUGiikRjp1zeNKZItlpavOvi0q56oLu0xnp8Ihl8as69IQ+LOST/RBcTDPtiB9IIhPaF4 TYcYlEurry9oqr5XAZU/v3vvWaVWMWdsiJQL1Wuamqa+GIKqizdwl1h0T+96f92uJU3qZg Z+yON3vJCGoZ0AxXXW1wHNGdFrc3Keg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669081220; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OmViSLFa5OllJV9pTGQkDLSySpGZUy3VM35OK0GlOcI=; b=snSu1ybewSSAIEhxm7Wk5UKoopHYvkv8qGapL3RLAQe8B7+pDHa34A71+an5IN1aeJNPvZ aecB12la4LcbLGJlcVyxBJA9NHQtNTimO6FjzTspK/Im1buwBOne58AJEaG+PFL62c8CPC ENPw3afJi86joHy31aX+vHb1ssnwj2w= X-Stat-Signature: 3npaqgmgu3je4zy9zkno1mzt9c8317mr X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 71CFD8000A Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="K/hom9Cb"; spf=pass (imf02.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.215.175 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspam-User: X-HE-Tag: 1669081220-335500 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000073, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (22/11/18 16:15), Nhat Pham wrote: > +static int zs_reclaim_page(struct zs_pool *pool, unsigned int retries); > + > +static int zs_zpool_shrink(void *pool, unsigned int pages, > + unsigned int *reclaimed) > +{ > + unsigned int total = 0; > + int ret = -EINVAL; > + > + while (total < pages) { > + ret = zs_reclaim_page(pool, 8); Just curious why 8 retries and how was 8 picked? > + if (ret < 0) > + break; > + total++; > + } > + > + if (reclaimed) > + *reclaimed = total; > + > + return ret; > +}