From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E057C433FE for ; Tue, 22 Nov 2022 03:16:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C6BDD8E0001; Mon, 21 Nov 2022 22:16:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BF4C56B0075; Mon, 21 Nov 2022 22:16:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A953B8E0001; Mon, 21 Nov 2022 22:16:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 967AA6B0074 for ; Mon, 21 Nov 2022 22:16:06 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 692CEA0B91 for ; Tue, 22 Nov 2022 03:16:06 +0000 (UTC) X-FDA: 80159614332.28.3D738A3 Received: from mail-qv1-f42.google.com (mail-qv1-f42.google.com [209.85.219.42]) by imf01.hostedemail.com (Postfix) with ESMTP id 6479940005 for ; Tue, 22 Nov 2022 03:16:04 +0000 (UTC) Received: by mail-qv1-f42.google.com with SMTP id d13so3624185qvj.8 for ; Mon, 21 Nov 2022 19:16:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0CiyjDdTfauQUln/S8JKlz3FnBrq1FeGqO43v3NL0cI=; b=cyuE3iOBx0NFRc//xsPoso6mtBj6Dgo8Fe/NMGakYHCImhgWQUbZhVoubfovqm6G+h CDWydrrIb5+El7DyyxkxXVRmL3OkQKvrbZZt7t3EN9BXnE8ijpngmBxL+uUeFUdT56m3 1fuEGfXMkMfAGAbAkJHCVXoUl35/jOrG5CyqwfDIE2Do0z8d+IL5Gal1MSbxua7DdP7C e40nfakVcSK7De/dX+J3RsP6XlDsb0AH2NtHrmnNyVmxIbZ/3roUow3DjGwg6iJq0gZn ucmNOfzdjViIEad+0Hb6Kca8QO5G8Vkx2TftaZcDUPMCsg5rHLt2I3zTOj+uVGGapsTS iNSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0CiyjDdTfauQUln/S8JKlz3FnBrq1FeGqO43v3NL0cI=; b=BWPr8zMHgR/GRti9btbCisVHxNXLPU05HAhy/s18CMqtNUKuKY1qGkpSF4FR5Wvbvs vvu1roqrkX9S9Gdw7npdJWshVZXQdSd5zq03iAk34zuviLHjo67I5nJMeCKHCZmbFpxx ClfhcusbeBCCbYaz8VFVSJo/m/GhDoht9ZAey+nl+4eOUGWi48q5/yFAMhAviSgmduEP s0d35zG2BtgNGG6A6lie39BIkReFEGq4BiRs9KtER1qpEkMCwnk4Y52UCihcasjKyNRx tipLB6KuWlqJkhe/jNtH54tNGm/jHQA0k5JfJBLnUdPe03cFkU5bvNQY8nCzyamHRkiN 8jSQ== X-Gm-Message-State: ANoB5pmdKZ0bUUUfSipfe6TXrwyUqRwV/LbRSpxegNsbGFyN9oVJtND/ /8TOYO5ciRirjdRA3W878enbgA== X-Google-Smtp-Source: AA0mqf6Pzmh6pPNAtrTTacw2SzyO5EjWygILYkNiEZQx2H1eUrRxOy+un4c9p4OEWs897pchLEGu4Q== X-Received: by 2002:a05:6214:162e:b0:4c6:57f1:3514 with SMTP id e14-20020a056214162e00b004c657f13514mr3635896qvw.87.1669086963553; Mon, 21 Nov 2022 19:16:03 -0800 (PST) Received: from localhost ([2620:10d:c091:480::1:bc4]) by smtp.gmail.com with ESMTPSA id dt44-20020a05620a47ac00b006fbf88667bcsm3616176qkb.77.2022.11.21.19.16.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Nov 2022 19:16:03 -0800 (PST) Date: Mon, 21 Nov 2022 22:16:28 -0500 From: Johannes Weiner To: Sergey Senozhatsky Cc: Andrew Morton , Seth Jennings , Dan Streetman , Vitaly Wool , Nhat Pham , Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] zswap: do not allocate from atomic pool Message-ID: References: <20221122013338.3696079-1-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221122013338.3696079-1-senozhatsky@chromium.org> ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=cyuE3iOB; spf=pass (imf01.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.42 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669086964; a=rsa-sha256; cv=none; b=ZFrUzZr2ZN2QsraTWFwZGdSALBNJ9mh/G7MHTIVZazgReE0ONwBkzo6KD5XkvHMLcBBSM/ wxUCTgXuINWl8C9SkIk94UDLBEolH3+NkqwdIqjBlWqAKLGkOGtpgmxXXJTg7mWWk5w7Ap khHYlmJe9vU9fwGOn7/9Efky6mmdXNs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669086964; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0CiyjDdTfauQUln/S8JKlz3FnBrq1FeGqO43v3NL0cI=; b=QDI5xTM5hrk8jmvCq28tJpwrcX/E7sd3eK8R4nE2dcyAvxfplJkVbpxX3WTt9ByNJclzeq mxQa3y+3TtJvaN51M5xqeIIqRm2kVagHXAPipe652pSoCbRrrF9JlSTH7gywr0aEXkceTB Uu5tl7N1hXta55nXWCYidu35xIYD0M4= X-Rspam-User: Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=cyuE3iOB; spf=pass (imf01.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.42 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org X-Stat-Signature: o16rszm185qkkjjy3y4b7mcar1h8u9k3 X-Rspamd-Queue-Id: 6479940005 X-Rspamd-Server: rspam09 X-HE-Tag: 1669086964-83153 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 22, 2022 at 10:33:38AM +0900, Sergey Senozhatsky wrote: > zswap_frontswap_load() should be called from preemptible > context (we even call mutex_lock() there) and it does not > look like we need to do GFP_ATOMIC allocaion for temp > buffer there. Use GFP_KERNEL instead. > > Signed-off-by: Sergey Senozhatsky > --- > mm/zswap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index 2d69c1d678fe..f6c89049cf70 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -1314,7 +1314,7 @@ static int zswap_frontswap_load(unsigned type, pgoff_t offset, > } > > if (!zpool_can_sleep_mapped(entry->pool->zpool)) { > - tmp = kmalloc(entry->length, GFP_ATOMIC); > + tmp = kmalloc(entry->length, GFP_KERNEL); There is another one in zswap_writeback_entry() that seems equally arbitrary. They came in through the same commit, with no further explanation as to this choice. Do you want to pick that up too?