From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73CA7C4332F for ; Mon, 21 Nov 2022 20:20:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 197116B0072; Mon, 21 Nov 2022 15:20:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1468A6B0073; Mon, 21 Nov 2022 15:20:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 05CD98E0001; Mon, 21 Nov 2022 15:20:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EB6D66B0072 for ; Mon, 21 Nov 2022 15:20:39 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A40B6AB5C5 for ; Mon, 21 Nov 2022 20:20:39 +0000 (UTC) X-FDA: 80158567398.01.2F65C46 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf29.hostedemail.com (Postfix) with ESMTP id 47D5E120012 for ; Mon, 21 Nov 2022 20:20:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:References; bh=qaupadcjhzZWuwo0SW1FLQDoGV393NT+0ekZNi1CQlM=; b=NEF7A7h+pT/8S99HRFYNHfGzd9 1DGY+mEVxaTLHONneGw7xWiYLcyZF6lE4uZ9PoKfxCM+lAJXd9zEzP9+P3kQLiRQWMj7bZHB+LoeQ U8wPTuUOJMmh2rrdgkS2vHyQTVKLV09US9z17HwgouMku/QHyvnrqQGLyoeseECxZ/pmku3VZg5ci 8PZ2LybZEtCLzgHc5lIh/IqV9LhDDyC9ld9xLgKrLj1JVe+mklsE6Fe+y10TrU6rM+wcbEoLGJ6sZ 4LYK1AuZoaWg4ryzMEsyay5i4uTUnOLtKFAqAgjuwWsBg3ITTcVcn7VaL/CxNsLtM00aXe275kN4v xEyaNwYw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxDHO-00HXrP-PS; Mon, 21 Nov 2022 20:20:34 +0000 Date: Mon, 21 Nov 2022 12:20:34 -0800 From: Luis Chamberlain To: Song Liu , Linus Torvalds Cc: bpf@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, x86@kernel.org, peterz@infradead.org, hch@lst.de, rick.p.edgecombe@intel.com, rppt@kernel.org, willy@infradead.org, dave@stgolabs.net, a.manzanares@samsung.com Subject: Re: [PATCH bpf-next v4 0/6] execmem_alloc for BPF programs Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=NEF7A7h+; spf=none (imf29.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669062039; a=rsa-sha256; cv=none; b=KbfD3paXKIwezlFGSAjchio3x99vmpqv4S3sKtIPcBZJW7X1GRFWnV59VTmpEAywqKOaLU uuIMnCJqHjPY1nPyziGhWq0YmDjti9IcS6IvpJ5HGBPUGWL7azWwsdGxmLp+ZiaAbdF4uG jbhN+mDPpeWD1lSsEagR4y/+SvqWwgY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669062039; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=qaupadcjhzZWuwo0SW1FLQDoGV393NT+0ekZNi1CQlM=; b=FrUZYQ0akO7xFrPl+FeldjYKUIOzj/T/lvxj4t6XbTyor/UUncq1hTC93eqiMvevA3khqb i1pN2hWFcajbL81e0aNvjhvtNkFlQAOR/vX8Vu2WMvm/LAxWxwNCrbBVZ7BjVelM7jk9s2 v1Xs2Tu8of9ea+A+hqTEueq+YAQwS8E= X-Rspam-User: Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=NEF7A7h+; spf=none (imf29.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) X-Stat-Signature: y65ysxw7nyoxkid7iijyjgwiaqwp8aao X-Rspamd-Queue-Id: 47D5E120012 X-Rspamd-Server: rspam09 X-HE-Tag: 1669062039-447680 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 21, 2022 at 12:12:49PM -0800, Luis Chamberlain wrote: > On Thu, Nov 17, 2022 at 12:23:16PM -0800, Song Liu wrote: > > Based on our experiments [5], we measured ~0.6% performance improvement > > from bpf_prog_pack. This patchset further boosts the improvement to ~0.8%. > > I'd prefer we leave out arbitrary performance data, as it does not help much. I'd like to clarify what I mean by this, as Linus has suggested before, you are missing the opportunity to present "actual numbers on real loads. (not some artificial benchmark)" [0] https://lkml.kernel.org/r/CAHk-=wiF1KnM1_paB3jCONR9Mh1D_RCsnXKBau1K7XLG-mwwTQ@mail.gmail.com Luis