From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38CA0C433FE for ; Mon, 21 Nov 2022 19:55:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E5D36B0072; Mon, 21 Nov 2022 14:55:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 996436B0073; Mon, 21 Nov 2022 14:55:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 85D7C6B0074; Mon, 21 Nov 2022 14:55:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 777136B0072 for ; Mon, 21 Nov 2022 14:55:25 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 378A9AB346 for ; Mon, 21 Nov 2022 19:55:25 +0000 (UTC) X-FDA: 80158503810.15.54A256A Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf15.hostedemail.com (Postfix) with ESMTP id 59259A0003 for ; Mon, 21 Nov 2022 19:55:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=o7A0f5fhMzFexYyY2uaItIw4YITyd89IESvV+ezjEYs=; b=SyETYHYQ80ABmsXfB0x1k+cFAL EmI7nazUgJ27wjE0C2WRLWE0VNiZVEXjEF0VL+/HlbR7p6fKZb/9j65HZbTGnWub9nkmOODCReX8d +lgwWBdlF528feYzlOuWJnTSYM4E8YofY7MDnABMVkj3z2KCwLWkoVF4GxehnTpS4rVmQTxkSRulD SCLxbaDRG/wysJC0ozX7ekyxVmGY6YjGtIACySiklCYqVAig8ggNzrKT+zTGOUqfPD9F2hO7vVYpD PYKc+xYMlhuddbcUAGWmiTo/RwrEnk+mqR2S3HO1uHa76ABZyTkDxxMoTZMop74qD7VGpytDRxSAj e5sBcaEw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxCss-00HNOo-Gv; Mon, 21 Nov 2022 19:55:14 +0000 Date: Mon, 21 Nov 2022 11:55:14 -0800 From: Luis Chamberlain To: Song Liu Cc: Christoph Hellwig , Daniel Borkmann , bpf@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, x86@kernel.org, peterz@infradead.org, rick.p.edgecombe@intel.com, rppt@kernel.org Subject: Re: [PATCH bpf-next v4 1/6] vmalloc: introduce execmem_alloc, execmem_free, and execmem_fill Message-ID: References: <20221117202322.944661-1-song@kernel.org> <20221117202322.944661-2-song@kernel.org> <882e2964-932e-0113-d3cd-344281add3a1@iogearbox.net> <20221121155542.GA27879@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669060523; a=rsa-sha256; cv=none; b=fKiT35PMVP9dJdfAFJkclmV/fMTyOHHTfE3tfekLY/6tf2rD1Nn0NeYhXTzQjKkhZr9zIl nr6KplmsysBWovIN+7MPCIs+gYwiyizE+HobJ7W+RkHzBLdRS/UrdnJYc+h2K6lXWmkecb wppu+Le9oXvQe6hsSPh72Pk9ISPu9CY= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=SyETYHYQ; spf=none (imf15.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669060523; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=o7A0f5fhMzFexYyY2uaItIw4YITyd89IESvV+ezjEYs=; b=hqGoMdle9fNyEWPmQY5ZDE8WG0CFjHpaw/E4iwZ81w395VGAjixlkZaKsxUHH3G93SxaR3 S06qvC1zi3wndvaeQGxarFGnmYQ7efhepf9d/YMR5oPK2e36fi6oZFxMpUCPTyMqzyj+5P fg7SlyMD7gG/dHS9GZofdVTVR64wh+w= X-Stat-Signature: 75pppr4qxhwabaoxyc8gpikw6qcwepy7 X-Rspamd-Queue-Id: 59259A0003 X-Rspam-User: Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=SyETYHYQ; spf=none (imf15.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) X-Rspamd-Server: rspam02 X-HE-Tag: 1669060522-969347 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 21, 2022 at 09:29:20AM -0700, Song Liu wrote: > On Mon, Nov 21, 2022 at 8:55 AM Christoph Hellwig wrote: > > > > On Mon, Nov 21, 2022 at 04:52:24PM +0100, Daniel Borkmann wrote: > > >> +void *execmem_fill(void *dst, void *src, size_t len) > > >> +{ > > >> + return ERR_PTR(-EOPNOTSUPP); > > >> +} > > > > > > Don't they need EXPORT_SYMBOL_GPL, too? > > > > None of these should be exported. Modular code has absolutely no > > business creating executable mappings. > > I added these exports for test_vmalloc.ko. Is there a way to only export > them to test_vmalloc.ko but nothing else? See EXPORT_SYMBOL_NS_GPL() Luis