From: Al Viro <viro@zeniv.linux.org.uk>
To: Liu Shixin <liushixin2@huawei.com>
Cc: Eric Biederman <ebiederm@xmission.com>,
Kees Cook <keescook@chromium.org>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] binfmt_misc: fix shift-out-of-bounds in check_special_flags
Date: Sat, 19 Nov 2022 05:29:22 +0000 [thread overview]
Message-ID: <Y3hpslPymEBPmZCS@ZenIV> (raw)
In-Reply-To: <20221102025123.1117184-1-liushixin2@huawei.com>
On Wed, Nov 02, 2022 at 10:51:23AM +0800, Liu Shixin wrote:
> UBSAN reported a shift-out-of-bounds warning:
>
> left shift of 1 by 31 places cannot be represented in type 'int'
> Call Trace:
> <TASK>
> __dump_stack lib/dump_stack.c:88 [inline]
> dump_stack_lvl+0x8d/0xcf lib/dump_stack.c:106
> ubsan_epilogue+0xa/0x44 lib/ubsan.c:151
> __ubsan_handle_shift_out_of_bounds+0x1e7/0x208 lib/ubsan.c:322
> check_special_flags fs/binfmt_misc.c:241 [inline]
> create_entry fs/binfmt_misc.c:456 [inline]
> bm_register_write+0x9d3/0xa20 fs/binfmt_misc.c:654
> vfs_write+0x11e/0x580 fs/read_write.c:582
> ksys_write+0xcf/0x120 fs/read_write.c:637
> do_syscall_x64 arch/x86/entry/common.c:50 [inline]
> do_syscall_64+0x34/0x80 arch/x86/entry/common.c:80
> entry_SYSCALL_64_after_hwframe+0x63/0xcd
> RIP: 0033:0x4194e1
>
> Since the type of Node's flags is unsigned long, we should define these
> macros with same type too.
We are limited to 32 bits anyway. More interesting question here is what's
the point of having those bits that high anyway?
next prev parent reply other threads:[~2022-11-19 5:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 2:51 Liu Shixin
2022-11-19 5:29 ` Al Viro [this message]
2022-12-02 21:55 ` Kees Cook
2022-12-02 21:58 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3hpslPymEBPmZCS@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=ebiederm@xmission.com \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liushixin2@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox