From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F6AAC433FE for ; Fri, 18 Nov 2022 23:43:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8C2236B0071; Fri, 18 Nov 2022 18:43:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 871908E0001; Fri, 18 Nov 2022 18:43:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 738E16B0073; Fri, 18 Nov 2022 18:43:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 641C76B0071 for ; Fri, 18 Nov 2022 18:43:26 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2EE501201A4 for ; Fri, 18 Nov 2022 23:43:26 +0000 (UTC) X-FDA: 80148192012.18.4257C72 Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) by imf25.hostedemail.com (Postfix) with ESMTP id 9A93CA000E for ; Fri, 18 Nov 2022 23:43:25 +0000 (UTC) Received: by mail-qv1-f53.google.com with SMTP id s18so2804505qvo.9 for ; Fri, 18 Nov 2022 15:43:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=W/iTpmR4sRdLv0Rk3A8XEP/l6NiYPL92CF45ZyTgAiU=; b=gsWF7RmdFZNApUCqHEyf0BafcUrFVHnUgIS7HhgpUNR5xF9VvlzTIR5biXLQLJAtux ef1rp8dfIEcWWTpYDLJSxGwb35YMj4OcmP+tdOx2Fr4vTWGgN2XS2NtPbcroIz8XKl4v FNhXlg07RHUWM4bfGIaZ7i6wMsSfF+pCELt+P+9QZRmTkbnrqcjpAFUZjLFsEapoxUsy OMy1jNRSZJsxU+SqK2GdMJbnM8ptspzNHM41EB5x1wPnpWgIDPBEHkEOa4qM4JIIXMO7 15q1sHnkCMenDiRbzLQIew81n2tPXEb926GxiXB24xnKLs9+3HFdVuWpl6r8Oc7mlhkt bGOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=W/iTpmR4sRdLv0Rk3A8XEP/l6NiYPL92CF45ZyTgAiU=; b=H+gpmxQWfQPDTkCNQtBHTTr588G+pfzHTn4fLvrLXPU6Ugu5PyFdvAKlNATugL38Oa yYBuqu/dDiIJ4jGl7J/lbXrhS5nXg1RDH9X1FoFOUUdrwTCsYoMoiDlQHQxMZfhr0INh yvz0LswNjbfgNI5zehwiWZRl3WMObiWCvqsse9/EiRJj5NF/btHYe1XMa+lFt7Zp1C9V 3kQqey59FcQ/pksVPI57jSTz3WqH3Uz6tW+/ezh9pNFCe+mlyK2wIHnOBY4Y0/9JCl3S 3QeFFEgJfITUegEJIvP5/i5hOPV1dOIdFknh7fltAvYvrQ5J6Z8JxQ9wCKUDFjsd+AwD 6v3w== X-Gm-Message-State: ANoB5pkTAKZlK/pkMXsYxz1tW7ZFkSw0Z6XD5eg8ghCHFez737QSDJvd IekFpUW96C9QqNP26g6aun7aAw== X-Google-Smtp-Source: AA0mqf5G/gaac1k+oIvscpizv4XMzhcrStHSf0J/I1Czc9JO0bpVKFs2vCc7zi+UWJRorpllDXYDFw== X-Received: by 2002:a0c:8091:0:b0:4bb:b8ec:2bc7 with SMTP id 17-20020a0c8091000000b004bbb8ec2bc7mr8811778qvb.20.1668815004777; Fri, 18 Nov 2022 15:43:24 -0800 (PST) Received: from localhost ([2620:10d:c091:480::1:bc4]) by smtp.gmail.com with ESMTPSA id i10-20020a05620a404a00b006bb8b5b79efsm3504337qko.129.2022.11.18.15.43.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Nov 2022 15:43:23 -0800 (PST) Date: Fri, 18 Nov 2022 18:43:46 -0500 From: Johannes Weiner To: "Aneesh Kumar K.V" Cc: linux-mm@kvack.org, akpm@linux-foundation.org, Tejun Heo , Zefan Li , cgroups@vger.kernel.org, stable@kernel.org Subject: Re: [PATCH] mm/cgroup/reclaim: Fix dirty pages throttling on cgroup v1 Message-ID: References: <20221118070603.84081-1-aneesh.kumar@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221118070603.84081-1-aneesh.kumar@linux.ibm.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668815005; a=rsa-sha256; cv=none; b=Oj8Ywa5liJ/WGUOObJoXCOUzjMAtScqfzfGUhjxYMF3iJCKgMBcZtgULBOHmM/Zw4O1TF6 h04kmE61aXKg7vHkxEeZa2ajLXqbN3Ej8/ChXwroxUaJv59pG8FNeinUFHJCdPKw6iIWZU Q7BvMCPrvH/AypL6f4dKtx4o+hZKPg4= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=gsWF7Rmd; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf25.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.53 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668815005; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=W/iTpmR4sRdLv0Rk3A8XEP/l6NiYPL92CF45ZyTgAiU=; b=lbcBy/p40AWxdijU/ZlrFY3uB+JDfN3/83iagk0p9vSdwNDlwLe8zdZwg0qZ3HhxfddAM8 UwcVQCg8agiKs+6IEFb8GSPI0SJd4YjC81jNnKvLHnrkRF0UaAIKqPF0811uhvryLPkXcc 5ff9TdaLlAEhIOz4to5cjIbRLVe3W+w= Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=gsWF7Rmd; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf25.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.53 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org X-Rspam-User: X-Stat-Signature: dr8fcio1u37mn5ht971mofjjhkrergnk X-Rspamd-Queue-Id: 9A93CA000E X-Rspamd-Server: rspam11 X-HE-Tag: 1668815005-406445 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 18, 2022 at 12:36:03PM +0530, Aneesh Kumar K.V wrote: > balance_dirty_pages doesn't do the required dirty throttling on cgroupv1. See > commit 9badce000e2c ("cgroup, writeback: don't enable cgroup writeback on > traditional hierarchies"). Instead, the kernel depends on writeback throttling > in shrink_folio_list to achieve the same goal. With large memory systems, the > flusher may not be able to writeback quickly enough such that we will start > finding pages in the shrink_folio_list already in writeback. Hence for cgroupv1 > let's do a reclaim throttle after waking up the flusher. > > The below test which used to fail on a 256GB system completes till the > the file system is full with this change. > > root@lp2:/sys/fs/cgroup/memory# mkdir test > root@lp2:/sys/fs/cgroup/memory# cd test/ > root@lp2:/sys/fs/cgroup/memory/test# echo 120M > memory.limit_in_bytes > root@lp2:/sys/fs/cgroup/memory/test# echo $$ > tasks > root@lp2:/sys/fs/cgroup/memory/test# dd if=/dev/zero of=/home/kvaneesh/test bs=1M > Killed > > Cc: > Suggested-by: Johannes Weiner > Signed-off-by: Aneesh Kumar K.V Acked-by: Johannes Weiner Thanks Aneesh