From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8AF7C433FE for ; Fri, 18 Nov 2022 22:38:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4ACA36B0071; Fri, 18 Nov 2022 17:38:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 45CA66B0072; Fri, 18 Nov 2022 17:38:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 324B68E0002; Fri, 18 Nov 2022 17:38:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1F2A46B0071 for ; Fri, 18 Nov 2022 17:38:35 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E21AB120BF5 for ; Fri, 18 Nov 2022 22:38:34 +0000 (UTC) X-FDA: 80148028548.10.AFCCC87 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by imf15.hostedemail.com (Postfix) with ESMTP id 999F0A0008 for ; Fri, 18 Nov 2022 22:38:34 +0000 (UTC) Received: by mail-pj1-f43.google.com with SMTP id w3-20020a17090a460300b00218524e8877so7866492pjg.1 for ; Fri, 18 Nov 2022 14:38:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=HS7sEulacmj3f+9ywrtjJQQzrLADk3rwjiT5beC2f0A=; b=ilPjNnL61iiMSRQcVrqjQNVK2HQ0z98UghwmpFG6kKdemCWTQ3omDqFLckmIRrC3LX ukyfT6CrliV4ZXQtptfuUUAubD0pmzcgt2wUrAYIK1L7hpCa9z6Uz2N8G7Aprst0wkW1 +2ZHNxKq0/UdfKfAEFjzIsIwwHkQFzH+c7IAwwXhx6IEfI+Gj0t71+p3ZaJEbLPp27H+ tSR86vL8/rWWVNY0EMw7xI6aZjfzV1cJlpp+x++D7+Oyqan5pbYnuezjZpGPhOOjp0X7 GhoCZNNHv5rEGHN+ZbQ+/cASHKP519nxabD47EXTjTRk4PXXG3Ahp57mBE98lniEOXD9 j94Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HS7sEulacmj3f+9ywrtjJQQzrLADk3rwjiT5beC2f0A=; b=yN+LvR3PgwJgafbhAWeYTgQYOtU2pYYOIFtoJO9fUaloKrCNpmwjLzpcuf5XfPJkHA YRaAONvayhIdxUjyo6oXamhyeLrFbPxOEDFFnoGrVnvdtNhYnUFao+8KQMtGswDAb+1Q 6h66QuBN+fPqbYELO4MZ8hPh3pLBe13ZwQ7ZFpqxjsngFHKPpd9xNrUfiPq4OhvLwTMJ P5KRIz2BgitG0E7Ds8Dwhz1Y5+GpjpsrTWyHVRjFxKie593Rk9a/4fXGgKpCxH2p52tT OWmIy44gWCmr6ETSyCLswtI49RRE5v7QjAIZ6VS006upX4s9W/n+AsBlAVMrTyPBp48R LJCQ== X-Gm-Message-State: ANoB5plo8BQ2ozlS/sVCzyPMW4jKRHxM1/VyaYfvFEXbXYt8VJyLag/u 46gtPqX6T5TeccOd2tdKd2c= X-Google-Smtp-Source: AA0mqf5UNNKxewq5WGgPNmPe78Ytew11k0tjQAADMAM9wB6Qoot7fw+MqwX2ndiEAp2QV8Kig2NtBw== X-Received: by 2002:a17:90b:a15:b0:212:8f7:acf with SMTP id gg21-20020a17090b0a1500b0021208f70acfmr9570913pjb.13.1668811113557; Fri, 18 Nov 2022 14:38:33 -0800 (PST) Received: from google.com ([2620:15c:211:201:bba9:9f92:b2cc:16a4]) by smtp.gmail.com with ESMTPSA id l12-20020a170903120c00b0016be834d54asm4218422plh.306.2022.11.18.14.38.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Nov 2022 14:38:33 -0800 (PST) Date: Fri, 18 Nov 2022 14:38:31 -0800 From: Minchan Kim To: Nhat Pham Cc: hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, ngupta@vflare.org, senozhatsky@chromium.org, akpm@linux-foundation.org, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com Subject: Re: [PATCH v5 6/6] zsmalloc: Implement writeback mechanism for zsmalloc Message-ID: References: <20221118220808.1194168-1-nphamcs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221118220808.1194168-1-nphamcs@gmail.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668811114; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HS7sEulacmj3f+9ywrtjJQQzrLADk3rwjiT5beC2f0A=; b=XXSk2vqFI9a1tAhKH2AwGnTFU1Ug8d6CWDkGr2UxpwVAw/TWI0zvc4xUsGMqQA3VSQdVd8 QypyTyXWX7svkS5Pg5gBORyeh7tQ23WT4VPoFrAjj21vA9tt8wtnn2AcAx23cy7egdLFPU 3FE4U2Pj8TivUQAeTJ9CnWtk4xVEShI= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ilPjNnL6; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf15.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668811114; a=rsa-sha256; cv=none; b=Ckvfm60ylzQlsXenS2920bUHTJ+ot4+jNHWd2uJtsjoQVM4mp1zs0LrgXIUxa4Yd33hYVl GSRLnXTAyhnvCTBIjDrOFloYzQJ4Lh8jIocpeY00wUPm/mz5loJjvC784g2dk450aqD6oc l06kY4FPItnlsDU1fy+3pkiMAHZVZmQ= X-Rspam-User: X-Stat-Signature: 34iohg318midqxjrac9rjagts35memfs X-Rspamd-Queue-Id: 999F0A0008 Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ilPjNnL6; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf15.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com X-Rspamd-Server: rspam07 X-HE-Tag: 1668811114-577241 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 18, 2022 at 02:08:08PM -0800, Nhat Pham wrote: > Thanks a lot for the suggestions so far and for the review, Minchan! > Quick question about your last comment: > > >> +#ifdef CONFIG_ZPOOL > > > > Let's remove the ifdef machinery here. > > > >> + /* Free all deferred handles from zs_free */ > >> + free_handles(pool, zspage); > >> +#endif > > free_handles() here is for the deferred handle freeing, which is also > under CONFIG_ZPOOL now, so I don't think we should remove the #ifdef > CONFIG_ZPOOL here, no? Let me know if I'm misunderstanding your > suggestion, or if you have any further comments regarding this patch. What I meant is #ifdef CONFIG_ZPOOL /* * Free all the deferred handles whose objects are freed in zs_free. */ static void free_handles(struct zs_pool *pool, struct zspage *zspage) { unsigned long handle = (unsigned long)zspage->deferred_handles; while (handle) { unsigned long nxt_handle = handle_to_obj(handle); cache_free_handle(pool, handle); handle = nxt_handle; } } #else static inline void free_handles(struct zs_pool *pool, struct zspage *zspage) {} #endif And then we could do __free_zspage free_handles(pool, zspage); So without CONFIG_ZPOOL, the free_nandles function will be void.