From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88E7BC4332F for ; Fri, 18 Nov 2022 20:42:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E2B7E6B0071; Fri, 18 Nov 2022 15:42:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DDBB98E0001; Fri, 18 Nov 2022 15:42:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CCA1F6B0074; Fri, 18 Nov 2022 15:42:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BE4E06B0071 for ; Fri, 18 Nov 2022 15:42:12 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7FBAFC0CEE for ; Fri, 18 Nov 2022 20:42:12 +0000 (UTC) X-FDA: 80147735304.26.7D151D7 Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) by imf22.hostedemail.com (Postfix) with ESMTP id C9324C000B for ; Fri, 18 Nov 2022 20:42:11 +0000 (UTC) Received: by mail-qk1-f177.google.com with SMTP id p18so4286307qkg.2 for ; Fri, 18 Nov 2022 12:42:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sf7AnfznU4wpG+Kk6IbaTpUBZR9RJxDoBtRddMUUBJo=; b=FES1xXielCjlnU6nLLldQEL7U2LyKYg1uxJTFr/GHH3B43OI8ULbeBCd+4HULwGryt vSwxYFI1KCbtJ8ADiTxJMB64OUCQYgbdh0vlWDIhaUnkUEwVnAV+y24UYJsMYw4DE97E icSKqZ75UtIOoOnVdsPsPcr+0z4Gwgx3VRgv2HGC2ODsgPjHvbkGwNmvoP4MukQ9bpVg A8vMxqwRKM6nYoAyRrYUGBUV1IEVEH1CXXFu51bSgDA3pKV6fVJIJ5FBYyB68RknlRpj VBF8E5jWP8VzZmKQIU95/5r4V55nleUnmtGI2ubjLBOoOM9v51r8qprmEH0VCZQNKBdb wLlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sf7AnfznU4wpG+Kk6IbaTpUBZR9RJxDoBtRddMUUBJo=; b=2TdJEPAVvCrIf7dwpTWVBHSxiqgfniKPDvR4Yi4yOpTqhzgxLGGQuPEDpIrhSMUqlI y44VSj1AXxBC2v4sb+QnIC5jVKng/V2upkwARNUICSd+SGd/haEbAmaVXilmFQLcsxRc PAqVaWZcLZSeY0SLzfBDjSY9FF0kutmbLJcIAqpqFeYK+JsVytgx71js8RXPb1oOrVmT fqawk9u7XzMEu2eIGF/bpFZ4OCOTirqEcbt+UATSpIDxtGhmtkHz5/to/JJyOTFo/MiT gfIwlPGFrfU5zKbLZjmnx8ibPkTlA2u0MMqh6FrO3ln1WHEdOHBrZsfeK4cfi7OgWnsi W0gQ== X-Gm-Message-State: ANoB5pmLyNRz6TqYDq3cqw9RAH5aAVAacHfTSwjfSbDXSJpcfh4PiRid w2d7iZOh0ZzYwQR5zD6knm6OCQ== X-Google-Smtp-Source: AA0mqf4Z1c0WbscSmPbmpXbekp1NwBPs8mQBji6xV3gLE0ypFnlN3cjdDC/LePIIuNoLohvOTIFQmQ== X-Received: by 2002:ae9:c010:0:b0:6fb:84ee:ab84 with SMTP id u16-20020ae9c010000000b006fb84eeab84mr7534695qkk.152.1668804130921; Fri, 18 Nov 2022 12:42:10 -0800 (PST) Received: from localhost ([2620:10d:c091:480::1:bc4]) by smtp.gmail.com with ESMTPSA id bn39-20020a05620a2ae700b006fa16fe93bbsm3037356qkb.15.2022.11.18.12.42.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Nov 2022 12:42:10 -0800 (PST) Date: Fri, 18 Nov 2022 15:42:34 -0500 From: Johannes Weiner To: Linus Torvalds Cc: Hugh Dickins , Andrew Morton , "Kirill A. Shutemov" , Matthew Wilcox , David Hildenbrand , Vlastimil Babka , Peter Xu , Yang Shi , John Hubbard , Mike Kravetz , Sidhartha Kumar , Muchun Song , Miaohe Lin , Naoya Horiguchi , Mina Almasry , James Houghton , Zach O'Keefe , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 0/3] mm,thp,rmap: rework the use of subpages_mapcount Message-ID: References: <5f52de70-975-e94f-f141-543765736181@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668804132; a=rsa-sha256; cv=none; b=FLBlR2PgqH9a0Ah0j+s+7W+UnKOfPFzavwn7uFLiExqrG7xZfDSLfQz4eCXQx1i8RDRryz WoKWSVcp3M3jZqoRgigb6dxPk8XgSlcBi3J+r+7UoVbpsbjtw6bJUV7JPdLzoDbGTDsJ/P ptp8rxmTcsb2EWM94EismaXYpq2pnek= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=FES1xXie; spf=pass (imf22.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.177 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668804132; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sf7AnfznU4wpG+Kk6IbaTpUBZR9RJxDoBtRddMUUBJo=; b=oNkJzmWn729RGE6Hsz3F/EJoYDv4UgfiMnVYzEt/Ad45iNbrYUyAP/U8tGYhaDHjCAWSo0 bwqft+fcudeO8O5eVWN4QILasA+MwcTZv876FZ3TOwCqlbdgwZFOfzIDlfCr0BEWUk072N w//eErQpfHa2wiA1NrxAxj2iLJ/g8PA= X-Stat-Signature: qbcrmnh4t8yabm477mfkoqg5kaiqjf5j X-Rspamd-Queue-Id: C9324C000B Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=FES1xXie; spf=pass (imf22.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.177 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1668804131-760522 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 18, 2022 at 12:18:42PM -0800, Linus Torvalds wrote: > On Fri, Nov 18, 2022 at 1:08 AM Hugh Dickins wrote: > > > > Linus was underwhelmed by the earlier compound mapcounts series: > > this series builds on top of it (as in next-20221117) to follow > > up on his suggestions - except rmap.c still using lock_page_memcg(), > > since I hesitate to steal the pleasure of deletion from Johannes. > > This looks good to me. Particularly 2/3 made me go "Aww, yes" but the > overall line removal stats look good too. > > That said, I only looked at the patches, and not the end result > itself. But not having the bit spin lock is, I think, a huge > improvement. > > I do wonder if this should be now just merged with your previous > series - it looks a bit odd how your previous series adds that > bitlock, only for it to be immediately removed. > > But if you think the logic ends up being easier to follow this way as > two separate patch series, I guess I don't care. > > And the memcg locking is entirely a separate issue, and I hope > Johannes will deal with that. Yeah, I'll redo the removal on top of this series and resend it. Thanks