From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61230C43217 for ; Fri, 18 Nov 2022 19:32:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D4DE46B0071; Fri, 18 Nov 2022 14:32:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CFE266B0072; Fri, 18 Nov 2022 14:32:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC60E8E0001; Fri, 18 Nov 2022 14:32:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AB3956B0071 for ; Fri, 18 Nov 2022 14:32:05 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6DBA2140247 for ; Fri, 18 Nov 2022 19:32:05 +0000 (UTC) X-FDA: 80147558610.01.08A59A0 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by imf02.hostedemail.com (Postfix) with ESMTP id E399180013 for ; Fri, 18 Nov 2022 19:32:04 +0000 (UTC) Received: by mail-pj1-f50.google.com with SMTP id h14so5347991pjv.4 for ; Fri, 18 Nov 2022 11:32:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=YT7jh12C9b+MGVUbQC67HmN3j2iOcFYyfJpQMQ1dp4c=; b=nWMaCZ3QP/mFnpvGl93qvAIEWDpEyst5izQAWsgrbNJS4E4vPHQ5vE+8QCmrxGt/mt DvDFNExdjyfLVA6gHlRG2uI/7rdjPKgjJDcEx8ZNv24iSqb7jE4p/WhzrFEPwxSDhqDY 1KfiV7EdIOU3PTZ6CxPRLMSNgZwvSusIsIloYZu5k8rk3yhLr6pL7xoMlmVEO+aaTPiv jieYjfZawyQwnaSOYnTXIgsDoFZJ94RgM8/coHMH/tKiRRROOjNklNNjUyNgS6KpAL0Q GSLomCr3HmLPe2vE66d9pj2Kh3Idc8ja5ibNriP61V3PZ2AsPyj776iGOLTs81CdCDZN S8iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YT7jh12C9b+MGVUbQC67HmN3j2iOcFYyfJpQMQ1dp4c=; b=v46rIMCl4trgaiu9H2dW5OtmxW14ke+g7wsCxM/XWecIpogzD02Z3e8DecZKDjGjrd /Y90Wu+1iO52SqvbKM0G+EbaiTMfV2inU5Mf9l32bWbcTtr+XvHy0ZlzbP+H5d/QuLAn QSMLp649O9SYVZ7pYUZ/6F9HHlQiKQQ6Y0TU/qoTDI+kfT3x8eopEfgzsYNdAcPOiwd2 60leVqb5Qq6zFnTZ9QbAdpLVr3DYvWUTk1MnlnMs0T0mZvFkJbqI8C6U8L1Vt9/3Qs5V RKgfblziuZXeaA+zwQ2qICiyL++1umm7nNAUBjxAIOzKN5uSveyi4ZEn5Vy8fWgcpPVU JzgQ== X-Gm-Message-State: ANoB5plD3si/NOsxKVodUsKNGRvo6/WzK5MFK3BQq0D+A2xjwjrvnOVd 0bqHIxcYKVmQH9+fpgJySjM= X-Google-Smtp-Source: AA0mqf7HQUep/xODul/qAH2LRmvIbHpj0vO/tG3rt0ek/yMX9K71eY6mGcsX8r0Z759elpZeUn7FIw== X-Received: by 2002:a17:902:7881:b0:185:5537:f399 with SMTP id q1-20020a170902788100b001855537f399mr990413pll.39.1668799923782; Fri, 18 Nov 2022 11:32:03 -0800 (PST) Received: from google.com ([2620:15c:211:201:bba9:9f92:b2cc:16a4]) by smtp.gmail.com with ESMTPSA id cp17-20020a170902e79100b00186b8752a78sm4080558plb.80.2022.11.18.11.32.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Nov 2022 11:32:03 -0800 (PST) Date: Fri, 18 Nov 2022 11:32:01 -0800 From: Minchan Kim To: Nhat Pham Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, ngupta@vflare.org, senozhatsky@chromium.org, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com Subject: Re: [PATCH v5 4/6] zsmalloc: Add a LRU to zs_pool to keep track of zspages in LRU order Message-ID: References: <20221118182407.82548-1-nphamcs@gmail.com> <20221118182407.82548-5-nphamcs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221118182407.82548-5-nphamcs@gmail.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668799925; a=rsa-sha256; cv=none; b=tSPlwGIFSqvuyAYG4qJd4Dv59bBYuUY9TjoEglNX+QvlC0IJORl3G+n+L8AHYlrRPeDhAz Pl/cvXTlgkqf90QvJqPJB/p6sOxwnYorg/7UuyJSIcRl3wfRZBQhXXgmP2esDxX+KNxIei pAy4IMMr+gVIfRjzhtnC9ePoxXDhcWE= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=nWMaCZ3Q; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf02.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.216.50 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668799925; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YT7jh12C9b+MGVUbQC67HmN3j2iOcFYyfJpQMQ1dp4c=; b=rIjAs8JLXWj6H259URyrHeIJkvtfUOfjufzJnlN+xt40Gh4Rw76V9yUToSisSOn8lWDquJ 4FNbrPAQeyO62licJtjwmnOVlBXSetCMPnvwpHDiwhpE1iyKXGygeZlCAD2q/mTRJ2XYVN n55SAZpTeyK2XnrF1Ud3yEOWjWj9Zig= X-Stat-Signature: knz3cd7yx1drr66u9jp6inhmzn558nxk X-Rspamd-Queue-Id: E399180013 X-Rspam-User: Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=nWMaCZ3Q; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf02.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.216.50 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com X-Rspamd-Server: rspam09 X-HE-Tag: 1668799924-93228 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000533, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 18, 2022 at 10:24:05AM -0800, Nhat Pham wrote: > This helps determines the coldest zspages as candidates for writeback. > > Signed-off-by: Nhat Pham > --- > mm/zsmalloc.c | 45 +++++++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 43 insertions(+), 2 deletions(-) > > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c > index 326faa751f0a..9e7b54324181 100644 > --- a/mm/zsmalloc.c > +++ b/mm/zsmalloc.c > @@ -239,6 +239,11 @@ struct zs_pool { > /* Compact classes */ > struct shrinker shrinker; > > +#ifdef CONFIG_ZPOOL > + /* List tracking the zspages in LRU order by most recently added object */ > + struct list_head lru; > +#endif > + > #ifdef CONFIG_ZSMALLOC_STAT > struct dentry *stat_dentry; > #endif > @@ -260,6 +265,12 @@ struct zspage { > unsigned int freeobj; > struct page *first_page; > struct list_head list; /* fullness list */ > + > +#ifdef CONFIG_ZPOOL > + /* links the zspage to the lru list in the pool */ > + struct list_head lru; > +#endif > + > struct zs_pool *pool; > #ifdef CONFIG_COMPACTION > rwlock_t lock; > @@ -352,6 +363,18 @@ static void cache_free_zspage(struct zs_pool *pool, struct zspage *zspage) > kmem_cache_free(pool->zspage_cachep, zspage); > } > > +#ifdef CONFIG_ZPOOL > +/* Moves the zspage to the front of the zspool's LRU */ > +static void move_to_front(struct zs_pool *pool, struct zspage *zspage) > +{ > + assert_spin_locked(&pool->lock); > + > + if (!list_empty(&zspage->lru)) > + list_del(&zspage->lru); > + list_add(&zspage->lru, &pool->lru); > +} > +#endif > + > /* pool->lock(which owns the handle) synchronizes races */ > static void record_obj(unsigned long handle, unsigned long obj) > { > @@ -953,6 +976,9 @@ static void free_zspage(struct zs_pool *pool, struct size_class *class, > } > > remove_zspage(class, zspage, ZS_EMPTY); > +#ifdef CONFIG_ZPOOL > + list_del(&zspage->lru); > +#endif > __free_zspage(pool, class, zspage); > } > > @@ -998,6 +1024,10 @@ static void init_zspage(struct size_class *class, struct zspage *zspage) > off %= PAGE_SIZE; > } > > +#ifdef CONFIG_ZPOOL > + INIT_LIST_HEAD(&zspage->lru); > +#endif > + > set_freeobj(zspage, 0); > } > > @@ -1418,9 +1448,8 @@ unsigned long zs_malloc(struct zs_pool *pool, size_t size, gfp_t gfp) > fix_fullness_group(class, zspage); > record_obj(handle, obj); > class_stat_inc(class, OBJ_USED, 1); > - spin_unlock(&pool->lock); > > - return handle; > + goto out; > } > > spin_unlock(&pool->lock); > @@ -1444,6 +1473,11 @@ unsigned long zs_malloc(struct zs_pool *pool, size_t size, gfp_t gfp) > > /* We completely set up zspage so mark them as movable */ > SetZsPageMovable(pool, zspage); > +out: > +#ifdef CONFIG_ZPOOL > + /* Move the zspage to front of pool's LRU */ > + move_to_front(pool, zspage); > +#endif > spin_unlock(&pool->lock); Please move the move_to_front into zs_map_object with ZS_MM_WO with comment with "why we are doing only for WO case".