From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85501C4332F for ; Fri, 18 Nov 2022 09:19:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD8496B0071; Fri, 18 Nov 2022 04:19:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A85466B0072; Fri, 18 Nov 2022 04:19:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 94D2A6B0073; Fri, 18 Nov 2022 04:19:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 85BA46B0071 for ; Fri, 18 Nov 2022 04:19:32 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5DF34802BC for ; Fri, 18 Nov 2022 09:19:32 +0000 (UTC) X-FDA: 80146014984.23.B98E8E4 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by imf13.hostedemail.com (Postfix) with ESMTP id E10C620009 for ; Fri, 18 Nov 2022 09:19:31 +0000 (UTC) Received: by mail-wr1-f42.google.com with SMTP id l14so8365634wrw.2 for ; Fri, 18 Nov 2022 01:19:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ywmGO6HZoPeDk5pta/Zgi0l/H8NSLfPp6KexyZfvyDg=; b=XPRDdbxSOzJuW1tJt8/WHHpRnL8IMglbnT7xSVVogruEXcIywo6nDWDMXJnhsh0Til +nQRhwutmq5nZmv8aI9NOzyY7aB/KemObkTtxVM8iPd54uYQwHa5VhbuNEG9JdA0/SrL FtFdJhWtJBOqEGSYQiJHuSZPgdwXaf49DGFIzFP7h9d3Ht6cLtqQsnN0EvnpT/jWWLOp U53ZDhnVotci6ISnopHFOrEe3RpHuPBKHfX+fFnHH/H4x4eDlURpDi2FoNBvgeFugSCo 2VU81DsEDzHP38mJ3akPjnbGRTBIKdmpcIKti0fFUr6f6iilXuI6bF572+m+jUp+zKMY eMYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ywmGO6HZoPeDk5pta/Zgi0l/H8NSLfPp6KexyZfvyDg=; b=H0mKLEw3o5l7rV+wqySipzc8AtHqci9I3kbfVtsCLET+YC1buttbSCHSlJWx3fn7a5 jrtLeuti04L8+NuRzX0qs0nNN0lz/Edi3Dhw92PG5ZcJrC2CA7bDmdTJYYs9Piya00Qp bkCAMDgUJ2T5QDg84+DQEWY9lhpJMfj6KEnXLCC5W/vFIC1qypAY12P9TS+C4ZwCu+bB vtgcuPTB/OfI7KmU4a/jv+mwFbVaZpL9fp9c6JmE4Al6WEk98oedR0kYnqDLUjvcsUBE +ZWAe9KSMTjEy9Zp5V0X8HW/PYhbn3OtPzHqLKBtF3niPQ0rdSbIaT4RihgakiQiuO+M 52Lg== X-Gm-Message-State: ANoB5pkV+VEzJrXTqd9cVweuA86ZcwpA8VwFgRCgaOXcGBYFy27fSyc/ QvpmvX3mwNHza0XI4h0ltMz8Lw== X-Google-Smtp-Source: AA0mqf4IvIt8ecYfLqqdpfe2Ie8mTRQ05q6WdL2M9MInxr9ONrK62RPNSh4FwljtDFBhkb48MVrNJQ== X-Received: by 2002:a5d:53cd:0:b0:231:355b:211c with SMTP id a13-20020a5d53cd000000b00231355b211cmr3562614wrw.509.1668763170487; Fri, 18 Nov 2022 01:19:30 -0800 (PST) Received: from elver.google.com ([2a00:79e0:9c:201:4799:a943:410e:976]) by smtp.gmail.com with ESMTPSA id l8-20020adfa388000000b002417f35767asm3200743wrb.40.2022.11.18.01.19.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Nov 2022 01:19:29 -0800 (PST) Date: Fri, 18 Nov 2022 10:19:24 +0100 From: Marco Elver To: Dave Hansen Cc: Naresh Kamboju , Peter Zijlstra , kasan-dev , X86 ML , open list , linux-mm , regressions@lists.linux.dev, lkft-triage@lists.linaro.org, Andrew Morton , Alexander Potapenko Subject: Re: WARNING: CPU: 0 PID: 0 at arch/x86/include/asm/kfence.h:46 kfence_protect Message-ID: References: <4208866d-338f-4781-7ff9-023f016c5b07@intel.com> <41ac24c4-6c95-d946-2679-c1be2cb20536@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <41ac24c4-6c95-d946-2679-c1be2cb20536@intel.com> User-Agent: Mutt/2.2.7 (2022-08-07) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668763172; a=rsa-sha256; cv=none; b=DDEjFrJVTN4PcOjK1Yem7qmYIMdrUocODOX6+dtsRkdDIJcTTSkjzuE1Jeu78u4YHfqjWU 64BUBU+RM7WQ85UKtTxW+HIxM9+7y5tx6B6BFe/kYcCe5ulWEDinDX4hVTHqz5WscvAcvi SgGX0RgAdPhW9oyUKZ30lh6sGrEaovU= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=XPRDdbxS; spf=pass (imf13.hostedemail.com: domain of elver@google.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668763172; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ywmGO6HZoPeDk5pta/Zgi0l/H8NSLfPp6KexyZfvyDg=; b=bewohB7ivE1fLdgG7yah/28kZFAi8ztM2JkHkiDdWZJdMPrLQRVplRwYhJ3bvZfra4dcs7 bwfvGlB+HgpqSHU/lqrA1WxMwrkYU/verpZtnDOWNaa2pThfmvS0IzopFMhRgUbc4YiUe2 3mAUDyj6v+VYkWEQWz6sfrNbodmBl28= X-Stat-Signature: rokzmnquyq6byyjon1hx3eqg45i1gs78 X-Rspamd-Queue-Id: E10C620009 Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=XPRDdbxS; spf=pass (imf13.hostedemail.com: domain of elver@google.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam04 X-Rspam-User: X-HE-Tag: 1668763171-888641 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 17, 2022 at 03:54PM -0800, Dave Hansen wrote: > On 11/17/22 15:23, Marco Elver wrote: > > Yes - it's the 'level != PG_LEVEL_4K'. > > That plus the bisect made it pretty easy to find, thanks for the effort! > > Could you double-check that the attached patch fixes it? It seemed to > for me. Yes, that works - thanks! > The issue was that the new "No changes, easy!" check in the suspect > commit didn't check the cpa->force_split option. It didn't split down > to 4k and then all hell broke loose. > > Oh, and I totally misread the kfence ability to tolerate partial TLB > flushes. Sorry for the noise there! > diff --git a/arch/x86/mm/pat/set_memory.c b/arch/x86/mm/pat/set_memory.c > index 220361ceb997..9b4e2ad957f6 100644 > --- a/arch/x86/mm/pat/set_memory.c > +++ b/arch/x86/mm/pat/set_memory.c > @@ -1727,7 +1727,8 @@ static int __change_page_attr_set_clr(struct cpa_data *cpa, int primary) > /* > * No changes, easy! > */ > - if (!(pgprot_val(cpa->mask_set) | pgprot_val(cpa->mask_clr))) > + if (!(pgprot_val(cpa->mask_set) | pgprot_val(cpa->mask_clr)) > + && !cpa->force_split) > return ret; > > while (rempages) { Tested-by: Marco Elver