From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DD0AC433FE for ; Fri, 18 Nov 2022 05:23:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 87A536B0071; Fri, 18 Nov 2022 00:23:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 82A8E6B0072; Fri, 18 Nov 2022 00:23:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F3066B0073; Fri, 18 Nov 2022 00:23:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 62E0C6B0071 for ; Fri, 18 Nov 2022 00:23:46 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3C986406FE for ; Fri, 18 Nov 2022 05:23:46 +0000 (UTC) X-FDA: 80145420852.07.7631D77 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) by imf10.hostedemail.com (Postfix) with ESMTP id 8CBB5C0007 for ; Fri, 18 Nov 2022 05:23:45 +0000 (UTC) Received: by mail-qt1-f178.google.com with SMTP id h21so2545485qtu.2 for ; Thu, 17 Nov 2022 21:23:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=RmZFCbhZVx+S8fWiQUfSbQ8kLLMjYeNqXadz8uFT4Hk=; b=17g+Zcj4QfG+p5I0SLJ4UNDun1EQgDdsGQ2KWzOYSJCjj8nvfRnpRYalsIRmV1Jbza f+ra4lkwy06GzolOcfgajV/hxnSYGA8GSs463nLeyVB0nebG6m5jUsXGJ9ftVgRtR7Ah FqPDcZ0Okl1der8PXbwjPVSrWV1V+xseFipTEGIeVz64ruDZu6ElmhCYHhq8W8gMRyyU h/NHqivdPO8lG0cBCPQTFmrEEP/w7CfLBPgXVk7YIy7tch8u33WCw+YrlIxWSxDUCa5h ZPWuveYEDty4H/2bNE0JwlMO+YvHGHPpGeIQIu3/4oGuCpH83c2jUlcLVvP8G12Z2Z// JPtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RmZFCbhZVx+S8fWiQUfSbQ8kLLMjYeNqXadz8uFT4Hk=; b=VbagdeOLfny/OBQgQFz/4gyCeB11kNpMJ8+8NmN4sSWMKm2S8hfkDwsvfm8k6TsYMN KGgpa6lSJ3J1Oox6L+CbE1kzk/y2hvDPN8uMcwciher+w0gzOHh7WTIDP/VQ+LVgCqBS 6zUBHeSd2S+Tm+nxlXXAidyAzPtYbqNbjNxtBWwAkFoUO7t97tHIXL23w/NqIak7ghbU ryp9/aHeXWqW9yny/04NrmQi+oAYMWf5l98YLX1FCDpcP/bjKscSVkzLMKnNIoxaDWVC qCCbxeb1WE105BDb9LO3ypm52EW4V9jpyMpJ0jJiZ7o6SJ8h3mVoRlxIhMYxTAfZCwTZ hxEg== X-Gm-Message-State: ANoB5pn1q4U4RdsSfzM0oask3VAvSu6xORgbz4KyAKEXr4XmU+CXDmsd RxGYHcbjUYkKIlADvOnCnjE88g== X-Google-Smtp-Source: AA0mqf6XM50x/7Fzdl9gUIpGLpZ55FMwfAe9+x2g1UYcFuRqYSdoJvP3v+dLLikTs1vfXEEJiiaepw== X-Received: by 2002:ac8:740f:0:b0:3a5:2fce:adcb with SMTP id p15-20020ac8740f000000b003a52fceadcbmr5482378qtq.148.1668749024761; Thu, 17 Nov 2022 21:23:44 -0800 (PST) Received: from localhost ([2620:10d:c091:480::1:bc4]) by smtp.gmail.com with ESMTPSA id u12-20020a37ab0c000000b006bb29d932e1sm1746548qke.105.2022.11.17.21.23.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Nov 2022 21:23:44 -0800 (PST) Date: Fri, 18 Nov 2022 00:24:07 -0500 From: Johannes Weiner To: Minchan Kim Cc: Nhat Pham , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, ngupta@vflare.org, senozhatsky@chromium.org, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com Subject: Re: [PATCH v4 5/5] zsmalloc: Implement writeback mechanism for zsmalloc Message-ID: References: <20221117163839.230900-1-nphamcs@gmail.com> <20221117163839.230900-6-nphamcs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668749025; a=rsa-sha256; cv=none; b=fyDApl602RLC+Aer9/sAw4AZOFiQfI4g0y7x8bWqHk0Ebb1/QvWIMgOBPm6ZDHetUicraJ Ks7Gc5Hy3nsc5elEzHLQxH8L709jJ8eTJI/QcU5FgexfaqMFD9lt7jwXYQ6i3/rZ4W8KXv 9AeRHcrRipJwXK9pOcnyADem+SlaDRc= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=17g+Zcj4; spf=pass (imf10.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.178 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668749025; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RmZFCbhZVx+S8fWiQUfSbQ8kLLMjYeNqXadz8uFT4Hk=; b=oRWC//leq+B6zBemVmtxjE3pk2YzLPXjRG0Rz60KZh6yHi6duAjSIq2GEDKl/dXbfwWADS Rq7slJpNyaynBJjDqn4LSX2n1WR098Vu6pHvcjGqGmPbZxJyX/9hrrBbuuQJFwQzyj2kmj 52AiMJBRDLleAkBzXQo6p1suUJfQ2cs= Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=17g+Zcj4; spf=pass (imf10.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.178 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 8CBB5C0007 X-Rspam-User: X-Stat-Signature: j9x1wm7se9izwi4zsgu3masptcrc3rub X-HE-Tag: 1668749025-870468 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000056, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 17, 2022 at 02:48:28PM -0800, Minchan Kim wrote: > On Thu, Nov 17, 2022 at 08:38:39AM -0800, Nhat Pham wrote: > > @@ -449,6 +450,27 @@ static void zs_zpool_free(void *pool, unsigned long handle) > > zs_free(pool, handle); > > } > > > > +static int zs_reclaim_page(struct zs_pool *pool, unsigned int retries); > > + > > +static int zs_zpool_shrink(void *pool, unsigned int pages, > > what pages? Hm? This is the number of driver pages to clear out. The name matches the function signature for this callback in struct zpool_driver: int (*shrink)(void *pool, unsigned int pages, unsigned int *reclaimed); I agree with the rest of the feedback. Thanks for taking a look, Minchan!