From: Johannes Weiner <hannes@cmpxchg.org>
To: Minchan Kim <minchan@kernel.org>
Cc: Nhat Pham <nphamcs@gmail.com>,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, ngupta@vflare.org,
senozhatsky@chromium.org, sjenning@redhat.com, ddstreet@ieee.org,
vitaly.wool@konsulko.com
Subject: Re: [PATCH v4 5/5] zsmalloc: Implement writeback mechanism for zsmalloc
Date: Fri, 18 Nov 2022 00:24:07 -0500 [thread overview]
Message-ID: <Y3cW92Hb8KpEuuQk@cmpxchg.org> (raw)
In-Reply-To: <Y3a6PGDB5ievPYgQ@google.com>
On Thu, Nov 17, 2022 at 02:48:28PM -0800, Minchan Kim wrote:
> On Thu, Nov 17, 2022 at 08:38:39AM -0800, Nhat Pham wrote:
> > @@ -449,6 +450,27 @@ static void zs_zpool_free(void *pool, unsigned long handle)
> > zs_free(pool, handle);
> > }
> >
> > +static int zs_reclaim_page(struct zs_pool *pool, unsigned int retries);
> > +
> > +static int zs_zpool_shrink(void *pool, unsigned int pages,
>
> what pages?
Hm? This is the number of driver pages to clear out. The name matches
the function signature for this callback in struct zpool_driver:
int (*shrink)(void *pool, unsigned int pages,
unsigned int *reclaimed);
I agree with the rest of the feedback.
Thanks for taking a look, Minchan!
prev parent reply other threads:[~2022-11-18 5:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 16:38 [PATCH v4 0/5] Implement writeback " Nhat Pham
2022-11-17 16:38 ` [PATCH v4 1/5] zswap: fix writeback lock ordering " Nhat Pham
2022-11-17 16:38 ` [PATCH v4 2/5] zsmalloc: Consolidate zs_pool's migrate_lock and size_class's locks Nhat Pham
2022-11-17 22:02 ` Minchan Kim
2022-11-17 16:38 ` [PATCH v4 3/5] zsmalloc: Add a LRU to zs_pool to keep track of zspages in LRU order Nhat Pham
2022-11-17 22:15 ` Minchan Kim
2022-11-18 4:30 ` Johannes Weiner
2022-11-18 19:24 ` Minchan Kim
2022-11-18 19:54 ` Johannes Weiner
2022-11-17 16:38 ` [PATCH v4 4/5] zsmalloc: Add ops fields to zs_pool to store evict handlers Nhat Pham
2022-11-17 22:25 ` Minchan Kim
2022-11-18 5:15 ` Johannes Weiner
2022-11-18 5:52 ` Johannes Weiner
2022-11-17 16:38 ` [PATCH v4 5/5] zsmalloc: Implement writeback mechanism for zsmalloc Nhat Pham
2022-11-17 22:48 ` Minchan Kim
2022-11-18 5:24 ` Johannes Weiner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3cW92Hb8KpEuuQk@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=ddstreet@ieee.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=nphamcs@gmail.com \
--cc=senozhatsky@chromium.org \
--cc=sjenning@redhat.com \
--cc=vitaly.wool@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox