From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26D43C4332F for ; Thu, 17 Nov 2022 21:33:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 719276B0073; Thu, 17 Nov 2022 16:33:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C8FA6B0075; Thu, 17 Nov 2022 16:33:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 568F78E0001; Thu, 17 Nov 2022 16:33:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 482C46B0073 for ; Thu, 17 Nov 2022 16:33:14 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0E9A612121D for ; Thu, 17 Nov 2022 21:33:14 +0000 (UTC) X-FDA: 80144235108.22.9E331FE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf12.hostedemail.com (Postfix) with ESMTP id A4DF340014 for ; Thu, 17 Nov 2022 21:33:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668720791; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NacRUdys2RBcTySXcORs3cUgrfcTnkT3badNAV0/z5s=; b=Dlsh7APPnKJqNntXIDdgCmO4HG4q4vd64Z6RUs8Fajkgn4NCAoKlkjX8lHi3f2d84BiCGz akZTJlvY8pD7GYxhVJkRVSFFYsviNA/uIMQHKhO1/vwtevynQEa+QPGhHJiTZWS1fPu3F9 zbNtck1o4hEfraa21UEEj/PDx7/7MVY= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-654-13kbSYzgOaS2IR1GH7hRRw-1; Thu, 17 Nov 2022 16:33:03 -0500 X-MC-Unique: 13kbSYzgOaS2IR1GH7hRRw-1 Received: by mail-qk1-f197.google.com with SMTP id bs7-20020a05620a470700b006fac7447b1cso3756042qkb.17 for ; Thu, 17 Nov 2022 13:33:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=uDQssBDra2LgVmFEmn0r+1NHqlAxiYwGBKpxHeKgv/A=; b=Wld1AZzOxSTurNk3t5MtdebQl8JEI6Egm6cZc6PvgTdWchMC0Mv3qb9xaAfUTvjKgy xsgR0e4lVRQTxrFI6wXXBmBzHUcJYxgiIonFnRio0tD/qpg6720Mr6KQLNKODb0hUzFm LucknTz6OhVjmzYTtpvjbCpSyN2MWtPnyI90NSwgsueuO4lseTVrkBoA25J4Oh/0n4rj 0Tt9Wcb00izA4zpJf9k6FfvED7vpIYuIu7g2Gt/iEjPwFikPt8b7rwp68VjHjw9Xu1p8 aortbNVSp+vakg4X/Sa6ReMAH0ScBgBL0I322IiuxCizq/nxNQnp/8zCEBdZKvXw/viG MwxA== X-Gm-Message-State: ANoB5pmvOcRdNl7J8o1h3hXW8+ySIaYq/ZuLL3pANcw/jMTIlpI1Ns1q aVKKywxNuf8Vmfj6FLjmayZCWvDkR+BmirMUFT3Dv2Iq0sZhanxzAOs4rjjXZE1vO0O8Ep6nfNk 7TQfzrS5EsPs= X-Received: by 2002:a05:6214:1e2:b0:4b8:fbc8:594c with SMTP id c2-20020a05621401e200b004b8fbc8594cmr4180085qvu.61.1668720783478; Thu, 17 Nov 2022 13:33:03 -0800 (PST) X-Google-Smtp-Source: AA0mqf7GUQGzSuRb8meXTFVPjjz0QZ1OIpM/M/Y+skPofDCEJfsYqDG59yxNKsN4fDPGQ0ZyKA7lMw== X-Received: by 2002:a05:6214:1e2:b0:4b8:fbc8:594c with SMTP id c2-20020a05621401e200b004b8fbc8594cmr4180070qvu.61.1668720783259; Thu, 17 Nov 2022 13:33:03 -0800 (PST) Received: from x1n (bras-base-aurron9127w-grc-46-70-31-27-79.dsl.bell.ca. [70.31.27.79]) by smtp.gmail.com with ESMTPSA id bs42-20020a05620a472a00b006b61b2cb1d2sm1184021qkb.46.2022.11.17.13.33.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Nov 2022 13:33:02 -0800 (PST) Date: Thu, 17 Nov 2022 16:33:01 -0500 From: Peter Xu To: Joel Savitz Cc: Andrew Morton , linux-kernel@vger.kernel.org, Shuah Khan , David Hildenbrand , Nico Pache , linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH linux-next] selftests/vm: calculate variables in correct order Message-ID: References: <20221028132640.2791026-1-jsavitz@redhat.com> <20221108163124.a54f932f8f79f9c1d6e63903@linux-foundation.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="+DsSjgx0E9gBsQRT" Content-Disposition: inline ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Dlsh7APP; spf=pass (imf12.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668720793; a=rsa-sha256; cv=none; b=xTnhHvmDDzLm6xw2CJYW65sMPjuGZUe/or/iO3Ls2kqD5dpadeH8DXNKwIL7qK1azPOOZz mRkI9zV0/hom/O/12K1HgkOKVmvfbhMtsQ3pxixq8Aj5JM0a1D/37HkWc4wYSBMsIKWzWt GdoDLCBooScSgH9xJt3nI8x2Kg6v8Kc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668720793; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NacRUdys2RBcTySXcORs3cUgrfcTnkT3badNAV0/z5s=; b=OccryP6yVwKfCZGeEHilqOn/hecCAyYWhFp4zI4OvPMqhdFZ4MxOFHKWHIAEDVwdP5n8dK 9NU0OTXs2ech9xjGBU9cvuaHhadK4NxVyAQQj0tWnTdQub7+RmhsjCoUwFoElOYPgsINYr 21BVAr8KljQDDk7MVzyfXPTuZ5+XmT8= Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Dlsh7APP; spf=pass (imf12.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam02 X-Rspam-User: X-Stat-Signature: to667oc4exhu8kcfm9dmfoojeb15em4u X-Rspamd-Queue-Id: A4DF340014 X-HE-Tag: 1668720792-191834 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --+DsSjgx0E9gBsQRT Content-Type: text/plain; charset=utf-8 Content-Disposition: inline On Wed, Nov 16, 2022 at 08:09:11PM -0400, Joel Savitz wrote: > However, I noticed that on the mm-everything branch, the hugepage-mmap test > fails: > > # ./run_vmtests.sh -t "hugetlb" > running: ./hugepage-mmap > ----------------------- > running ./hugepage-mmap > ----------------------- > Open failed: No such file or directory > [FAIL] > ... > > It appears this is due to commit 0796c7b8be84 ("selftests/vm: drop mnt > point for hugetlb in run_vmtests.sh") > as the test still replies on the ./huge mountpoint removed in that commit. > The test passes before that patchset is applied. Oops, sorry I totally overlooked this hard-coded test case using the mntpoint. Fix is simple though, which is attached. -- Peter Xu --+DsSjgx0E9gBsQRT Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0001-selftests-vm-use-memfd-for-hugepage-mmap-test.patch" >From 71da2480d4bac0fc598e4d1f05f71aba8b980bc4 Mon Sep 17 00:00:00 2001 From: Peter Xu Date: Thu, 17 Nov 2022 16:29:15 -0500 Subject: [PATCH] selftests/vm: use memfd for hugepage-mmap test Content-type: text/plain This test was overlooked with a hard-coded mntpoint path in test when we're removing the hugetlb mntpoint in commit 0796c7b8be84. Fix it up so the test can keep running. Reported-by: Joel Savitz Signed-off-by: Peter Xu --- tools/testing/selftests/vm/hugepage-mmap.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/tools/testing/selftests/vm/hugepage-mmap.c b/tools/testing/selftests/vm/hugepage-mmap.c index 93f9e7b81331..955ef87f382c 100644 --- a/tools/testing/selftests/vm/hugepage-mmap.c +++ b/tools/testing/selftests/vm/hugepage-mmap.c @@ -16,14 +16,13 @@ * range. * Other architectures, such as ppc64, i386 or x86_64 are not so constrained. */ - +#define _GNU_SOURCE #include #include #include #include #include -#define FILE_NAME "huge/hugepagefile" #define LENGTH (256UL*1024*1024) #define PROTECTION (PROT_READ | PROT_WRITE) @@ -67,16 +66,16 @@ int main(void) void *addr; int fd, ret; - fd = open(FILE_NAME, O_CREAT | O_RDWR, 0755); + fd = memfd_create("hugepage-mmap", MFD_HUGETLB); if (fd < 0) { - perror("Open failed"); + perror("memfd_create() failed"); exit(1); } addr = mmap(ADDR, LENGTH, PROTECTION, FLAGS, fd, 0); if (addr == MAP_FAILED) { perror("mmap"); - unlink(FILE_NAME); + close(fd); exit(1); } @@ -87,7 +86,6 @@ int main(void) munmap(addr, LENGTH); close(fd); - unlink(FILE_NAME); return ret; } -- 2.37.3 --+DsSjgx0E9gBsQRT--