From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA1F7C433FE for ; Thu, 17 Nov 2022 22:25:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E01F6B0071; Thu, 17 Nov 2022 17:25:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 590306B0072; Thu, 17 Nov 2022 17:25:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 458A96B0073; Thu, 17 Nov 2022 17:25:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 374C46B0071 for ; Thu, 17 Nov 2022 17:25:56 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 0620816058A for ; Thu, 17 Nov 2022 22:25:56 +0000 (UTC) X-FDA: 80144367912.21.229D49F Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by imf16.hostedemail.com (Postfix) with ESMTP id 9CD0D180008 for ; Thu, 17 Nov 2022 22:25:55 +0000 (UTC) Received: by mail-pg1-f172.google.com with SMTP id n17so3352692pgh.9 for ; Thu, 17 Nov 2022 14:25:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=dgr+e8ZyUoyDeyQ+E1fecvyvQ3W2gshFUSz2h8pvtJo=; b=DSg1++mVGWTTs7HfqbyCCT1RM+HQcQfLF37N/1OsrGl29ndKcrswsXH85YfT5n3j6U 5FeMN6xIWV2gDbdsV+uwPpP78AvaGvtc5ezIVRGPWwjYinE4FHanGwaJXmxJnwmDZkVC +YoOUjS36Rwmv/Jp3G4T/DT4sazBl+QThyz17uQjFB/4g4wv8Vb9mwIO1KbJkYt0sq0K UrHI5Qs4fht+UlFZFUQLDMQ+pycLVg04zv3VTKamGabTNtFOSd6w75hkrR1vqon/EAWZ qyq0pEprtGELFzQ86y9i1aWNnW9Lggog846qYgk9lmWLvfzn/eg7Cf6mzDhAOXKI40e0 pfMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dgr+e8ZyUoyDeyQ+E1fecvyvQ3W2gshFUSz2h8pvtJo=; b=HQuwWsGSr5jl5614kWtYsYrwDAbgzQWlXH7+pkr2izAT+rPwFMG+0gDB2rvUbiITT5 mwEyfj/RCe+OlyW5zV8P7jj9Pg19rLZsIrwg9/WYDKcrFO9qw/SAXubedmPfW8JVYbCq 6yJr8EyntJhqdQwvN1Q4nhxdFaPpAl/dNAoLwnqVXKwMWInNwW2/taKnvX9psoeQNd+/ vVVTOxbMp+RuQhSmfAf6AI6aGnGFO2LXLqkIzHmTASPTJS5uN9ux9MZ0YF/kdwjYAdLi Q0Wi4pt0rvRRiazijIUTGcTE5/VshxgfNm9ccg0mnJ/7V/Gu+B4Ov/RNBQK8vtQfbMPZ SWEg== X-Gm-Message-State: ANoB5pkQ3yKqzPg4cvf+oErLEi8Ic4aC5iK/T8PjFkBECjhGyb3kLWlJ BBkK4eATuJMWAQEp5AbjeDo= X-Google-Smtp-Source: AA0mqf7Z65fj1NYronMx4tvVIgXpfTk0PfmABsMsNxgksLL4eZYFqj9gERnwE5cFmcG759Xa+4GpXA== X-Received: by 2002:a63:c65:0:b0:476:db6f:d436 with SMTP id 37-20020a630c65000000b00476db6fd436mr4003107pgm.394.1668723954609; Thu, 17 Nov 2022 14:25:54 -0800 (PST) Received: from google.com ([2620:15c:211:201:6bbc:b70a:8f80:710d]) by smtp.gmail.com with ESMTPSA id u15-20020a170902e80f00b001869581f7ecsm1963826plg.116.2022.11.17.14.25.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Nov 2022 14:25:54 -0800 (PST) Date: Thu, 17 Nov 2022 14:25:52 -0800 From: Minchan Kim To: Nhat Pham Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, ngupta@vflare.org, senozhatsky@chromium.org, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com Subject: Re: [PATCH v4 4/5] zsmalloc: Add ops fields to zs_pool to store evict handlers Message-ID: References: <20221117163839.230900-1-nphamcs@gmail.com> <20221117163839.230900-5-nphamcs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221117163839.230900-5-nphamcs@gmail.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668723955; a=rsa-sha256; cv=none; b=cFjuZTkJ1djVjBWVXJTwYlFE95dFV15fSyTfhvCfTEWigH6l2tltCk2z0iroJlMUGlXrge HUnixyPgHXNpD5T2ULKLKVKubb5nynMLB6M/RBC5ktrd5FPYj920jjZcW+6SFisya7nYN4 ugmJ8cLDKD4UQ5ZwT685tL6zTqb2i2Y= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=DSg1++mV; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf16.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.215.172 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668723955; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dgr+e8ZyUoyDeyQ+E1fecvyvQ3W2gshFUSz2h8pvtJo=; b=Bin49xygg5MujOg6kX+zBHbvHNGTQ2bn5K+b5NPlx/SJTMI6V1QDVZPWoUOh1c7uZ7dGfL MY+xcApQtckABndgKsSHkHPaX1xKNDHTBX/173SZqiW0PSV7rjfQLUeZN8tLnUAwZNKf4x pUGNx7hElx5Fz3rzIO2vfk9Msrm0H5c= X-Stat-Signature: 4kugim3fiknibqe7a6zd1xszr7bj3zi5 X-Rspamd-Queue-Id: 9CD0D180008 Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=DSg1++mV; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf16.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.215.172 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1668723955-846399 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 17, 2022 at 08:38:38AM -0800, Nhat Pham wrote: > This adds fields to zs_pool to store evict handlers for writeback, > analogous to the zbud allocator. > > Signed-off-by: Nhat Pham > --- > mm/zsmalloc.c | 35 ++++++++++++++++++++++++++++++++++- > 1 file changed, 34 insertions(+), 1 deletion(-) > > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c > index 2557b55ec767..776d0e15a401 100644 > --- a/mm/zsmalloc.c > +++ b/mm/zsmalloc.c > @@ -225,6 +225,12 @@ struct link_free { > }; > }; > > +struct zs_pool; > + > +struct zs_ops { > + int (*evict)(struct zs_pool *pool, unsigned long handle); > +}; > + > struct zs_pool { > const char *name; > > @@ -242,6 +248,9 @@ struct zs_pool { > #ifdef CONFIG_ZPOOL > /* List tracking the zspages in LRU order by most recently added object */ > struct list_head lru; > + const struct zs_ops *ops; > + struct zpool *zpool; > + const struct zpool_ops *zpool_ops; > #endif > > #ifdef CONFIG_ZSMALLOC_STAT > @@ -385,6 +394,18 @@ static void record_obj(unsigned long handle, unsigned long obj) > > #ifdef CONFIG_ZPOOL > > +static int zs_zpool_evict(struct zs_pool *pool, unsigned long handle) > +{ > + if (pool->zpool && pool->zpool_ops && pool->zpool_ops->evict) > + return pool->zpool_ops->evict(pool->zpool, handle); > + else > + return -ENOENT; > +} > + > +static const struct zs_ops zs_zpool_ops = { > + .evict = zs_zpool_evict > +}; > + > static void *zs_zpool_create(const char *name, gfp_t gfp, > const struct zpool_ops *zpool_ops, > struct zpool *zpool) > @@ -394,7 +415,19 @@ static void *zs_zpool_create(const char *name, gfp_t gfp, > * different contexts and its caller must provide a valid > * gfp mask. > */ > - return zs_create_pool(name); > + struct zs_pool *pool = zs_create_pool(name); > + > + if (pool) { > + pool->zpool = zpool; > + pool->zpool_ops = zpool_ops; > + > + if (zpool_ops) I lost. When do we have zpool_ops as NULL?