From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB64EC4332F for ; Thu, 17 Nov 2022 18:07:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 25D3A6B0071; Thu, 17 Nov 2022 13:07:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E6A46B0072; Thu, 17 Nov 2022 13:07:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0605F6B0073; Thu, 17 Nov 2022 13:07:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id ECB7D6B0071 for ; Thu, 17 Nov 2022 13:07:05 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C25A4C0DC3 for ; Thu, 17 Nov 2022 18:07:05 +0000 (UTC) X-FDA: 80143715610.01.75326A7 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by imf18.hostedemail.com (Postfix) with ESMTP id E83D41C0018 for ; Thu, 17 Nov 2022 18:07:04 +0000 (UTC) Received: by mail-qt1-f179.google.com with SMTP id l15so1618175qtv.4 for ; Thu, 17 Nov 2022 10:07:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2HPIXQbIrPnuqK125OGbmjGgvwi+I/0K6FJ7sbpZHi0=; b=nAEb4V+rPllk4yYfIKmhZuBLFGuUNzw4u9T5qf6/naX6NI/vvSZsg6P9EQXt0HvJCn 3cPXYuiUgg7ZM8+T+N+/C4WEs4m5Jm/RPrO7DLtmw1XV+94gVpFMLDi8qfyWUbSOtCmg YZv4roOTmITs4+PiJVPVdX7z71XMOYCkF6+p67ml48vveURuDGWswXGSnWNkSFtEzOow /2EEi2WJKFL/2GQAlIB+ALJ2D1yuSNie57I6z+BENl2rLkgfYQE/LN5i3aVziADhGWJY 5GxzMqekQeJMlU2SlBJMQJU43fLHyG02Oy0KJ1YtAAUoB3d7C13rrsCygGBGZCFANdiv MeSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2HPIXQbIrPnuqK125OGbmjGgvwi+I/0K6FJ7sbpZHi0=; b=Rh54qbpNTILLW8S4jk9HO1Emv4uB71Ftg0FnKBLmSNluWqnJQw2ulqkBBv4QTR/EEt 1KzW3Lfvj8gwsLFWV1PwaJCV6jXuKoSGn4grQEhU7NkAZc0QcJiDqT3j2xvZhslRPUmz b0lc0FBdOn0sL0dWAFVP08VS0HCx8qApwAtw0oKI1quxD2KGmzBu+nkd8mlH2Lt+Tz/U IvWcYwn8GY5IXxjao/qm97vo2SQtuFBxeeZzpKNz1BxML41wBOX4IRLX1LgI48DK+qm8 lnM1ncGeq6rH5nGs+qyg6Rs0DJYVo942h030Sfg/94ph7kSQge4OJo/Z8HdGGezowAjX ZjPQ== X-Gm-Message-State: ANoB5pnxc95EvZ4FzihprKH2gmw9ll3DI+zVT+WF9KHAccNsAGtNHHZN Y7QFysO30JTnIPHddoKPGJUmTw== X-Google-Smtp-Source: AA0mqf4CgakhwYHpec/A0fPHzxBoFCwV3ijijJ39AMA/ov/Z3Txnly7AUnen6dCUMERwaQfYlsO/sA== X-Received: by 2002:ac8:108d:0:b0:391:6892:16cb with SMTP id a13-20020ac8108d000000b00391689216cbmr3310779qtj.332.1668708423959; Thu, 17 Nov 2022 10:07:03 -0800 (PST) Received: from localhost ([2620:10d:c091:480::1:bc4]) by smtp.gmail.com with ESMTPSA id p16-20020a05620a057000b006fb8239db65sm813592qkp.43.2022.11.17.10.07.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Nov 2022 10:07:01 -0800 (PST) Date: Thu, 17 Nov 2022 13:07:24 -0500 From: Johannes Weiner To: Chao Xu Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Chao Xu , yu@cmpxchg.org Subject: Re: [PATCH v1] mm/vmscan: simplify the nr assignment logic for pages to scan Message-ID: References: <20221110113130.284290-1-Chao.Xu9@zeekrlife.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221110113130.284290-1-Chao.Xu9@zeekrlife.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668708425; a=rsa-sha256; cv=none; b=q3cPdpivPWCYdxq/WD9Y3MXCZpZ2EVp56faqywwvN5OAB4rsiQJDRWAB9/eNMRnWGPUvtp 0ctH1SxtV+olwGHzdCW+s7fiab1Wmd8wD6x07qEPNYty2G9mKZXkx5M8V9KV6VfCrS2d7D AqHIU/4vl/WE0YIiwaNpXpEs3K1dcLo= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=nAEb4V+r; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf18.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.179 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668708425; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2HPIXQbIrPnuqK125OGbmjGgvwi+I/0K6FJ7sbpZHi0=; b=eIkgYlgBZRugsR7LtTfaZgdqIUe9VjPBjsDy64GBa5hX1xQkvm1H1XQOZC1CpX8eNRZGbN rIQ5biZB41QZc66pyi8621y9i0nqLAi1GhaMdMmlvtetIoEfTUXhYb4zQUp9rc4MA/hK3V gH8oo7o+oBhgviabZvAA7dBUX1vW2Ds= X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: E83D41C0018 Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=nAEb4V+r; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf18.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.179 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org X-Stat-Signature: 1cqdfe48ai5zupathykkuepsqzohq58m X-HE-Tag: 1668708424-625549 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 10, 2022 at 07:31:30PM +0800, Chao Xu wrote: > By default the assignment logic of anonymouns or file inactive > pages and active pages to scan using the same duplicated code > snippet. To simplify the logic, merge the same part. > > Signed-off-by: Chao Xu > --- > mm/vmscan.c | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 04d8b88e5216..69e458e51c81 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -5932,14 +5932,11 @@ static void shrink_lruvec(struct lruvec *lruvec, struct scan_control *sc) > * scan target and the percentage scanning already complete > */ > lru = (lru == LRU_FILE) ? LRU_BASE : LRU_FILE; > - nr_scanned = targets[lru] - nr[lru]; > - nr[lru] = targets[lru] * (100 - percentage) / 100; > - nr[lru] -= min(nr[lru], nr_scanned); > - > - lru += LRU_ACTIVE; > - nr_scanned = targets[lru] - nr[lru]; > - nr[lru] = targets[lru] * (100 - percentage) / 100; > - nr[lru] -= min(nr[lru], nr_scanned); > + for ( ; lru <= lru + LRU_ACTIVE; lru += LRU_ACTIVE) { As Yu points out, this will loop until lru overflows. NAK.