* [PATCH v1] mm/vmscan: simplify the nr assignment logic for pages to scan
@ 2022-11-10 11:31 Chao Xu
2022-11-17 18:07 ` Johannes Weiner
0 siblings, 1 reply; 2+ messages in thread
From: Chao Xu @ 2022-11-10 11:31 UTC (permalink / raw)
To: akpm; +Cc: linux-mm, linux-kernel, Chao Xu
By default the assignment logic of anonymouns or file inactive
pages and active pages to scan using the same duplicated code
snippet. To simplify the logic, merge the same part.
Signed-off-by: Chao Xu <Chao.Xu9@zeekrlife.com>
---
mm/vmscan.c | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 04d8b88e5216..69e458e51c81 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -5932,14 +5932,11 @@ static void shrink_lruvec(struct lruvec *lruvec, struct scan_control *sc)
* scan target and the percentage scanning already complete
*/
lru = (lru == LRU_FILE) ? LRU_BASE : LRU_FILE;
- nr_scanned = targets[lru] - nr[lru];
- nr[lru] = targets[lru] * (100 - percentage) / 100;
- nr[lru] -= min(nr[lru], nr_scanned);
-
- lru += LRU_ACTIVE;
- nr_scanned = targets[lru] - nr[lru];
- nr[lru] = targets[lru] * (100 - percentage) / 100;
- nr[lru] -= min(nr[lru], nr_scanned);
+ for ( ; lru <= lru + LRU_ACTIVE; lru += LRU_ACTIVE) {
+ nr_scanned = targets[lru] - nr[lru];
+ nr[lru] = targets[lru] * (100 - percentage) / 100;
+ nr[lru] -= min(nr[lru], nr_scanned);
+ }
scan_adjusted = true;
}
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v1] mm/vmscan: simplify the nr assignment logic for pages to scan
2022-11-10 11:31 [PATCH v1] mm/vmscan: simplify the nr assignment logic for pages to scan Chao Xu
@ 2022-11-17 18:07 ` Johannes Weiner
0 siblings, 0 replies; 2+ messages in thread
From: Johannes Weiner @ 2022-11-17 18:07 UTC (permalink / raw)
To: Chao Xu; +Cc: akpm, linux-mm, linux-kernel, Chao Xu, yu
On Thu, Nov 10, 2022 at 07:31:30PM +0800, Chao Xu wrote:
> By default the assignment logic of anonymouns or file inactive
> pages and active pages to scan using the same duplicated code
> snippet. To simplify the logic, merge the same part.
>
> Signed-off-by: Chao Xu <Chao.Xu9@zeekrlife.com>
> ---
> mm/vmscan.c | 13 +++++--------
> 1 file changed, 5 insertions(+), 8 deletions(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 04d8b88e5216..69e458e51c81 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -5932,14 +5932,11 @@ static void shrink_lruvec(struct lruvec *lruvec, struct scan_control *sc)
> * scan target and the percentage scanning already complete
> */
> lru = (lru == LRU_FILE) ? LRU_BASE : LRU_FILE;
> - nr_scanned = targets[lru] - nr[lru];
> - nr[lru] = targets[lru] * (100 - percentage) / 100;
> - nr[lru] -= min(nr[lru], nr_scanned);
> -
> - lru += LRU_ACTIVE;
> - nr_scanned = targets[lru] - nr[lru];
> - nr[lru] = targets[lru] * (100 - percentage) / 100;
> - nr[lru] -= min(nr[lru], nr_scanned);
> + for ( ; lru <= lru + LRU_ACTIVE; lru += LRU_ACTIVE) {
As Yu points out, this will loop until lru overflows.
NAK.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-17 18:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-10 11:31 [PATCH v1] mm/vmscan: simplify the nr assignment logic for pages to scan Chao Xu
2022-11-17 18:07 ` Johannes Weiner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox