From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8A8AC4332F for ; Thu, 17 Nov 2022 13:58:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 38B656B0071; Thu, 17 Nov 2022 08:58:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 33B776B0072; Thu, 17 Nov 2022 08:58:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 202FA8E0001; Thu, 17 Nov 2022 08:58:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 112EB6B0071 for ; Thu, 17 Nov 2022 08:58:47 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B2D431A0F10 for ; Thu, 17 Nov 2022 13:58:46 +0000 (UTC) X-FDA: 80143089852.01.FE8FA69 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by imf27.hostedemail.com (Postfix) with ESMTP id 3258040013 for ; Thu, 17 Nov 2022 13:58:45 +0000 (UTC) Received: by mail-wm1-f51.google.com with SMTP id j5-20020a05600c410500b003cfa9c0ea76so1851446wmi.3 for ; Thu, 17 Nov 2022 05:58:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=1PQ5ws+dl8HGBcphz45G0mKTEEpJ4QfuhaudxhaD3+4=; b=Bsf2m3MvbEn/8XlgvsgW5JoESOTFjhJMfQGF2lQzwZWRI2+U8rmt31ZkpwmzciX3gQ 4j+E93VrCZNGODCTWUcMXYY5pbmaJwnHw+UdBmOxw+8NpVtAPtlx/YF5qnr5k19uDjAI hQsd2Rpf2Tf+rz3eywQyEVXwTnMfthpQL8fSQ025Pf4PC56p5cK3v3T1/6uvpLy1Paxo dNc1zIVzrK/5aiMtvDT3oznp7ozyqzD0S1ZJ8ufVEhHb4WxBHh36Kk2mnoekb4Srp2Tt IA3QGXQaAolTdPXvkHcJUQvqhyRl5sqciU2nf5szQT9gDc3GcZ7dtyBwTpT9x33SwaqY TvRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1PQ5ws+dl8HGBcphz45G0mKTEEpJ4QfuhaudxhaD3+4=; b=HdRjPjU3o/GDU0b518KMFTzNJZA1RfAXc1K0EpSNCiTICB5yNHcBvYLoTRB4NiUKdA k4/SJ7uaijzLsSHv6ctXwEYZuKG4YPH3q8cnNv2Mw/vdRnvm7K5JWJaYCHeQZaPcUigd P4FcFegCwFUc1D/SZDua5OwpSy4KlrOGjZjoGJksgLMV54yb0wYTOFxUgxDqZ72aMw8f dUaWi7OlRkPccVrHeZ8CZxZ4fXma+BJ86aUwNCerrb4XBBbOO0Zz9Dv57vdjlvPiXJZM PG7rc80AT+7sSfxkVmX8w5ms/y57HT9iRUGuHakmjZ74JMqrP1EzT8fAcjrOAnXieNph C2vQ== X-Gm-Message-State: ANoB5pnZ78JWBB5DaESnwWYjRusL3JGweQBxUD1VbtENyvDay7nnqBin LbYsdjDvS2OA/xf960CqZ93dsA== X-Google-Smtp-Source: AA0mqf5mWk6NiG18cPmnqbdN+rMZijqr8d6POOWkXXJ7U3JHI2JxQeypVTt8Zt40vyCYMSpJ0ixc2g== X-Received: by 2002:a05:600c:220b:b0:3cf:f747:71f with SMTP id z11-20020a05600c220b00b003cff747071fmr3728421wml.147.1668693524809; Thu, 17 Nov 2022 05:58:44 -0800 (PST) Received: from elver.google.com ([2a00:79e0:9c:201:92f0:1ec9:e9f2:5cbe]) by smtp.gmail.com with ESMTPSA id 4-20020a05600c020400b003b492753826sm1226279wmi.43.2022.11.17.05.58.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Nov 2022 05:58:43 -0800 (PST) Date: Thu, 17 Nov 2022 14:58:37 +0100 From: Marco Elver To: Naresh Kamboju , Peter Zijlstra , Dave Hansen Cc: kasan-dev , X86 ML , open list , linux-mm , regressions@lists.linux.dev, lkft-triage@lists.linaro.org, Andrew Morton , Alexander Potapenko Subject: Re: WARNING: CPU: 0 PID: 0 at arch/x86/include/asm/kfence.h:46 kfence_protect Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.7 (2022-08-07) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668693526; a=rsa-sha256; cv=none; b=R07PxnTVeovyU2GRptbHvOKHQQrvXlVbkdD57hh2fPhX8RYHIDdNvssFs3zz2MRaOjchjZ SraoZKNczinYHjQJG3wrS29xREc7tVytJ2cqVRSVRsUz6wN5TdSlNMRjjRAKpTEBjZ2jva 2HzqP75qiAKAX1XRySXXo3CNTfCzqyQ= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Bsf2m3Mv; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of elver@google.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=elver@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668693526; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1PQ5ws+dl8HGBcphz45G0mKTEEpJ4QfuhaudxhaD3+4=; b=p4WUOYDumok1erXDEerML0Sz/kwFgh9FdV1RqFT07q/BbU8cE5pmZCiKs+Up4Lh6y+Dzbt xsgg3cXxsMATTvETHEx+vnMa05jY/vd5XiwuTIvkTY5STS3eitMFntSRpHAiyEf7kh0Lvc OqTxfufdmUF7YtZqUCqnHeA37njev0c= X-Stat-Signature: 9hc5zhs9depgs9snxi8bcm7dfbmwj6x3 X-Rspamd-Queue-Id: 3258040013 X-Rspam-User: Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Bsf2m3Mv; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of elver@google.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=elver@google.com X-Rspamd-Server: rspam09 X-HE-Tag: 1668693525-233533 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 17, 2022 at 05:01PM +0530, Naresh Kamboju wrote: > Kunit test cases failed and found warnings while booting Linux next > version 6.1.0-rc5-next-20221117 on qemu-x86_64 [1]. > > It was working on Linux next-20221116 tag. > > [ 0.663761] WARNING: CPU: 0 PID: 0 at > arch/x86/include/asm/kfence.h:46 kfence_protect+0x7b/0x120 > [ 0.664033] WARNING: CPU: 0 PID: 0 at mm/kfence/core.c:234 > kfence_protect+0x7d/0x120 > [ 0.664465] kfence: kfence_init failed > > Reported-by: Linux Kernel Functional Testing [...] > [ 0.663758] ------------[ cut here ]------------ > [ 0.663761] WARNING: CPU: 0 PID: 0 at > arch/x86/include/asm/kfence.h:46 kfence_protect+0x7b/0x120 [...] > [ 0.664465] kfence: kfence_init failed > > metadata: > git_ref: master > git_repo: https://gitlab.com/Linaro/lkft/mirrors/next/linux-next > git_sha: af37ad1e01c72483c4ee8453d9d9bac95d35f023 > git_describe: next-20221117 > kernel_version: 6.1.0-rc5 > kernel-config: https://builds.tuxbuild.com/2Hfb6n1z0frt4iBlIvqUzjMHiLm/config > build-url: https://gitlab.com/Linaro/lkft/mirrors/next/linux-next/-/pipelines/697483979 > artifact-location: https://builds.tuxbuild.com/2Hfb6n1z0frt4iBlIvqUzjMHiLm > toolchain: gcc-11 I bisected this to: commit 127960a05548ea699a95791669e8112552eb2452 Author: Peter Zijlstra Date: Thu Nov 10 13:33:57 2022 +0100 x86/mm: Inhibit _PAGE_NX changes from cpa_process_alias() There is a cludge in change_page_attr_set_clr() that inhibits propagating NX changes to the aliases (directmap and highmap) -- this is a cludge twofold: - it also inhibits the primary checks in __change_page_attr(); - it hard depends on single bit changes. The introduction of set_memory_rox() triggered this last issue for clearing both _PAGE_RW and _PAGE_NX. Explicitly ignore _PAGE_NX in cpa_process_alias() instead. Fixes: b38994948567 ("x86/mm: Implement native set_memory_rox()") Reported-by: kernel test robot Debugged-by: Dave Hansen Signed-off-by: Peter Zijlstra (Intel) Link: https://lkml.kernel.org/r/20221110125544.594991716%40infradead.org A simple revert of this commit fixes the issue. Since all this seems to be about set_memory_rox(), and this is a fix commit, the fix itself missed something? Thanks, -- Marco