From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65865C43217 for ; Thu, 17 Nov 2022 06:32:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 85B3C6B0075; Thu, 17 Nov 2022 01:32:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 80C1D8E0003; Thu, 17 Nov 2022 01:32:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 721B98E0002; Thu, 17 Nov 2022 01:32:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 634876B0075 for ; Thu, 17 Nov 2022 01:32:11 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 334F71201D7 for ; Thu, 17 Nov 2022 06:32:11 +0000 (UTC) X-FDA: 80141964462.05.2CAD55F Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf06.hostedemail.com (Postfix) with ESMTP id C4380180003 for ; Thu, 17 Nov 2022 06:32:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=sPTNEKYS/tLrxLQ4oI8+Sww3RL9H9VBsThKBpc9p/Gk=; b=K5/Kn6cFMb9LpqpOmmVr3AL3ai 0vZiISKwXqKUiJyr5NDOKZcFSpggWGsQkawGPm3P7UqdnGkVIGS0HN54pOlcTrJ8rePonZkJs3Cil 8bG5OKkn5iawEo8woWwszoVV1jztfvn8yDDH4UUHHaZgV+LkaxPvvIKtxh7sEHllokJHoVwbKvpOR ENvaQDOMDREuKSfPLrgrnsEd9eK2C9hvWh0vih31N633ucRXxLWAkuGXNyd7W0qzrIZ0pV3+UyCxA ivXc9kNZLeJEgwy4smO9WMtwJHqptMT8zrurd6/ISPrEggAEdLgDwvS6/Hx+XBRJGJhsBKQH7y+wz 1FJWbVoA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovYR9-00Aqki-1y; Thu, 17 Nov 2022 06:31:47 +0000 Date: Wed, 16 Nov 2022 22:31:47 -0800 From: Christoph Hellwig To: Jan Kara Cc: Christoph Hellwig , Christoph Hellwig , Namjae Jeon , Sungjong Seo , Jan Kara , OGAWA Hirofumi , Mikulas Patocka , Dave Kleikamp , Bob Copeland , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-karma-devel@lists.sourceforge.net, linux-mm@kvack.org Subject: Re: [PATCH 2/9] ext2: remove ->writepageo Message-ID: References: <20221113162902.883850-1-hch@lst.de> <20221113162902.883850-3-hch@lst.de> <20221114104927.k5x4i4uanxskfs6m@quack3> <20221116182040.tecis3dqejsdqnum@quack3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221116182040.tecis3dqejsdqnum@quack3> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668666730; a=rsa-sha256; cv=none; b=T/KCPLtDwaYTNO71upW1NxGZaLygc758ypMxLSMbWLFEHZOgB6uoTvD4ppNz5b5qZ9idU9 T+B0tidnYSdFCyiPXoX8Ry8/WCDax3b43/olv1HmAGVOyiY4lvMG0nr7oRB8EjO5Eri5bH s7uiGfyFtYFt/G/dbRXpvAX1XW8XD9U= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="K5/Kn6cF"; dmarc=none; spf=none (imf06.hostedemail.com: domain of BATV+7a745b0808b3927cdbe5+7025+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+7a745b0808b3927cdbe5+7025+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668666730; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sPTNEKYS/tLrxLQ4oI8+Sww3RL9H9VBsThKBpc9p/Gk=; b=aJIFY2r6WMbnMtwAlyQ+1eZB5IV2JFREpkGHUyIG/KzDpxp2Bjx62BsYsQVWUz5WtFmkkF VuzRGI93bfaJ3dcEm+ST4uqAek4kiu3Kvk5B9hWFZEV+R2lIBDULU2AyoBnvfEJF/dWD9Z nWuXH2ydgMi+sLljWLLuM3kS09MwbCY= X-Stat-Signature: w5z6ntg8mrsw85cyuw79jc5gspcwz68t X-Rspamd-Queue-Id: C4380180003 X-Rspam-User: Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="K5/Kn6cF"; dmarc=none; spf=none (imf06.hostedemail.com: domain of BATV+7a745b0808b3927cdbe5+7025+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+7a745b0808b3927cdbe5+7025+infradead.org+hch@bombadil.srs.infradead.org X-Rspamd-Server: rspam09 X-HE-Tag: 1668666729-429930 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 16, 2022 at 07:20:40PM +0100, Jan Kara wrote: > Looking at the code, IMO the write_one_page() looks somewhat premature > anyway in that place. AFAICS we could handle the writeout using > filemap_write_and_wait() if we moved it to somewhat later moment. So > something like attached patch (only basic testing only so far)? Yes, this looks sensible. Do you want to queue this one and the ext2 and udf patches from this series if the testing works fine? The same transformation should also be done for minix, sysfs and ufs. And a bunch of the others are probaby similar as well.