From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46E5EC4332F for ; Wed, 16 Nov 2022 23:49:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A6CEA6B0072; Wed, 16 Nov 2022 18:49:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A1CC46B0073; Wed, 16 Nov 2022 18:49:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E4696B0074; Wed, 16 Nov 2022 18:49:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7C07D6B0072 for ; Wed, 16 Nov 2022 18:49:34 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 59887A06C1 for ; Wed, 16 Nov 2022 23:49:34 +0000 (UTC) X-FDA: 80140949868.20.8FB2982 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf07.hostedemail.com (Postfix) with ESMTP id E7A254000B for ; Wed, 16 Nov 2022 23:49:33 +0000 (UTC) Received: by mail-pl1-f179.google.com with SMTP id d20so11592plr.10 for ; Wed, 16 Nov 2022 15:49:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=tcCp/eb/WZU+DTJcPCwY2VJkzPTgvyrBuxk1a3NJIuI=; b=ckt1W2V8G652pelj9SWyQXDp3Mv8waRL2i3OMs9hnMF6mcaw50zNFpXPInwHGvNbHu +/05SMGYIOCZmnCULFWV3HcNsKsxbjUJFbP8+i8+mjo1Du9KTdwQaxJGhhIDvAr48L21 6Y6ju4t+okBqMFuPtTqqdhNp/Jco9AcwTq72YwTYjop7mF1HZutYfn51uTlqFyuuRovI XhJxb89wHORiCO5Tb2aFXXSngUsP11MnFi2WoheScQaTf6+JIpR/7VPv5BfoBrB4fCpG De7RZXc+28UE83VKcNIGB8RT8FhP1VOVyJVwpaAPUrg455teh0pMtB/SWGqS/TLs6DBN gVmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tcCp/eb/WZU+DTJcPCwY2VJkzPTgvyrBuxk1a3NJIuI=; b=xcdjLKtRrfZ3MKPcTwFh6vENvTJoArUMCWkrOEqZj8wpvGIdtn/NfxYwna9s9RrO0C Y2rsZ4c44ZyUhYyD7AJApUDbb4MWi3a1c3z2Z42Vxi3lDJUgaE2qtrj2X/WEvYKWICh8 Sx3EAB+jZIIkwHNqGJd6H3cZ2Oz+/Ij6FgBp1QD1KRtKRqApLTtCSQymeIn2Ek64pj3g fD1jjVQFF7PV/1k4uIq0U31d9b/jnvrDtNYEzD1LK0vd+PH9t2VRkDRDq9hbZvDS5tc/ xYRKZ3pEUVbMjAmL5yGuUgybxn97v/DBDxFq/Oq+1BA7og4d6iiZpWSaKScvbpbQ0+d3 AM6A== X-Gm-Message-State: ANoB5pmdXOQ9bOR2byiN5rd2fJ4nPohhpwy1O1tDO2vSKkxeHsZ2BTLA jwNi1El2Ey6zSby7yBDEJEs= X-Google-Smtp-Source: AA0mqf57O2fw5FRh5h+aqLS29o4QxVpsLSnEs/MpaK/Rn1BzGnLL++2dWwaTAMJ+IUd1DX0r3QpK+A== X-Received: by 2002:a17:902:e9cc:b0:188:6c5b:ffb0 with SMTP id 12-20020a170902e9cc00b001886c5bffb0mr129205plk.125.1668642572737; Wed, 16 Nov 2022 15:49:32 -0800 (PST) Received: from google.com ([2620:15c:211:201:3439:fe53:7a5f:f579]) by smtp.gmail.com with ESMTPSA id k26-20020aa7999a000000b00561382a5a25sm11446066pfh.26.2022.11.16.15.49.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Nov 2022 15:49:31 -0800 (PST) Date: Wed, 16 Nov 2022 15:49:29 -0800 From: Minchan Kim To: Johannes Weiner Cc: Nhat Pham , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ngupta@vflare.org, senozhatsky@chromium.org, akpm@linux-foundation.org, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com Subject: Re: [PATCH v3 3/5] zsmalloc: Add a LRU to zs_pool to keep track of zspages in LRU order Message-ID: References: <20221110171831.19176-1-nphamcs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668642574; a=rsa-sha256; cv=none; b=wwVTsBtrHDNN6NO6fJEQLOmn8wJoKew4KO+ilZcFj6Gc/uTH9SuCYkkOYtnt/fqhAqPqUQ Zfanzow5XbrBoEBIfqSSjZaAP00WdJC49sr64OPv8Np//XVlioMbTlqqiSeuCV1UwaiTcU 5UK3yZLJsV/mjVDX6w7jWnwz+EweDOk= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ckt1W2V8; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf07.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668642574; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tcCp/eb/WZU+DTJcPCwY2VJkzPTgvyrBuxk1a3NJIuI=; b=SvqYqcHuwYzK8NzVRr55vzfiYZthWlWCLrViEZNYfgmNJtRPRpLijIOuOgAuB1YbYoOMJn 2TGRedWS/oqmVDo6DjZM5M5EnEmRIhyWUmJL64okjU8IY38iJJYVtHv5fkb5BOaqrkS0lS YBWbdAJO1aGe8LOPbjIlwKFAO9A8VJY= X-Stat-Signature: rzea6yxawa9m6idj5enkswtrcd73p45n X-Rspamd-Queue-Id: E7A254000B X-Rspam-User: Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ckt1W2V8; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf07.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com X-Rspamd-Server: rspam09 X-HE-Tag: 1668642573-552798 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 16, 2022 at 05:02:57PM -0500, Johannes Weiner wrote: > On Thu, Nov 10, 2022 at 02:48:32PM -0800, Minchan Kim wrote: > > On Thu, Nov 10, 2022 at 09:18:31AM -0800, Nhat Pham wrote: > > > > Please put the LRU logic under config ZSMALLOC_LRU since we don't need the > > > > additional logic to others. > > > > > > I think the existing CONFIG_ZPOOL would be a good option for this purpose. It > > > should disable the LRU behavior for non-zswap use case (zram for e.g). The > > > eviction logic is also currently defined under this. What do you think, > > > Minchan? > > > > That sounds good. > > > > Sergey and I are working to change zsmalloc zspage size. > > https://lore.kernel.org/linux-mm/20221031054108.541190-1-senozhatsky@chromium.org/ > > > > Could you send a new version once we settle those change down > > in Andrew's tree to minimize conflict? > > (Feel free to join the review/discussion if you are also interested ;-)) > > I've been reading through that thread, and it doesn't look like it'll > be ready for the upcoming merge window. (I've tried to contribute Depending on the discussion status :) > something useful to it, but it's a fairly difficult tuning problem, > and I don't know if a sysfs knob is the best answer, either...) That's the point. > > Would you have any objections to putting Nhat's patches here into 6.2? I don't want to block due to other issues so no objection from my side. > > It doesn't sound like there was any more feedback (except the trivial > ifdef around the LRU), and the patches are otherwise ready to go. In fact, I didn't start the review yet so please post it unless Sergey objects it. Thank you.