From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0D1BC4332F for ; Wed, 16 Nov 2022 16:36:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8627F6B0071; Wed, 16 Nov 2022 11:36:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 838FB6B0073; Wed, 16 Nov 2022 11:36:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 728556B0074; Wed, 16 Nov 2022 11:36:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 63AC06B0071 for ; Wed, 16 Nov 2022 11:36:54 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 37B3C807C1 for ; Wed, 16 Nov 2022 16:36:54 +0000 (UTC) X-FDA: 80139859548.20.E3C7794 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 8104540011 for ; Wed, 16 Nov 2022 16:36:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668616612; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=42qda8YCXAvT0VvMkHOL+t/vCh+HyZAHRup7avtOxrg=; b=UFHb7zYcWaxnba9BCEgfd3TBW/RHw2k+cfapDoqHO8b2xFGv6QHg/NBO3sDzvqsImngcKS Mia3pvyClrLlb7+6RgRHq/bjcGp6JbRXn0cKHyfgt0O1WuTyp/6LqMQvQ7+JymDUQe7wFJ 8dtt1kG77Q8FOuCOoA9jwq0gLZvO4cU= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-326-uV5yDKdbMEeVDenp5lyBnA-1; Wed, 16 Nov 2022 11:36:51 -0500 X-MC-Unique: uV5yDKdbMEeVDenp5lyBnA-1 Received: by mail-qv1-f69.google.com with SMTP id w12-20020a056214012c00b004c6257ca968so10297172qvs.16 for ; Wed, 16 Nov 2022 08:36:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=42qda8YCXAvT0VvMkHOL+t/vCh+HyZAHRup7avtOxrg=; b=bAEwNWROkKZRCIdWAMALJFe+iQ3tM7bysc5anC4vX6vlu7e7RQKtUeHmeLywvkldnA unx4v5H2k/l+6Y6TbMcch3Y7IR38843An/AE/JeulcwDHA0AKnq+hSoPAtOCSZtONgPu YONFIMW1wc7kYsXhlPDZpgGvJX1ahDVmwcUQHcI9qUwlo8Dv25CC7tRxMZBHdkWRlL8g OA6dduq1bdN1r2iEbJJ8Iorf3FAS/8qM7qNHlX8Vw8nlhUDpUK5Ol5yDSe04TWQSv3p+ idv3kfWe676akPN6ynrlP/Xu/ZccPpPyJ4R+iaTGcJgDIwSZrUI3HpiJmoO7csoCV+eO 245g== X-Gm-Message-State: ANoB5pkn38e4JV0I0Gy4DcEMDk242q299vTSAD+Yu07Or/ex6e9gLkWP HJeoKdwSccDrCK68BKUhFsNxRjN2MjTV2rwcTPbx/v8j3m55fELswFc7mO8SsTQkvaJ5PAPx+fm tLfc9eYn7swo= X-Received: by 2002:a05:620a:3ca:b0:6fb:9af3:8bb9 with SMTP id r10-20020a05620a03ca00b006fb9af38bb9mr8762412qkm.201.1668616610535; Wed, 16 Nov 2022 08:36:50 -0800 (PST) X-Google-Smtp-Source: AA0mqf7nkCxNpJGvJEJ3C6VRSsHqc3q6CslwVk4ldaBAzO3xHhUcYPs8eicSpJXUP6xNjMRHkMGZbw== X-Received: by 2002:a05:620a:3ca:b0:6fb:9af3:8bb9 with SMTP id r10-20020a05620a03ca00b006fb9af38bb9mr8762385qkm.201.1668616610302; Wed, 16 Nov 2022 08:36:50 -0800 (PST) Received: from x1n (bras-base-aurron9127w-grc-46-70-31-27-79.dsl.bell.ca. [70.31.27.79]) by smtp.gmail.com with ESMTPSA id x200-20020a3763d1000000b006fa8299b4d5sm10152480qkb.100.2022.11.16.08.36.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Nov 2022 08:36:49 -0800 (PST) Date: Wed, 16 Nov 2022 11:36:48 -0500 From: Peter Xu To: James Houghton Cc: Mike Kravetz , Muchun Song , David Hildenbrand , David Rientjes , Axel Rasmussen , Mina Almasry , Zach O'Keefe , Manish Mishra , Naoya Horiguchi , "Dr . David Alan Gilbert" , "Matthew Wilcox (Oracle)" , Vlastimil Babka , Baolin Wang , Miaohe Lin , Yang Shi , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v2 03/47] hugetlb: remove redundant pte_mkhuge in migration path Message-ID: References: <20221021163703.3218176-1-jthoughton@google.com> <20221021163703.3218176-4-jthoughton@google.com> MIME-Version: 1.0 In-Reply-To: <20221021163703.3218176-4-jthoughton@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668616613; a=rsa-sha256; cv=none; b=nax3dp2WK7PDe2TSjhtnQpOR5tW7kUqfzATXvo/fUo0j2hI1uEouXDK9Dgt+b5WDBgbnHi nf3siuXhiU4a/U0P8PrTQQD6m1Gr5YGPKYqRImxjZVh5uY1h4ukqYe/WbKqOF9i/mKolsd 519CMcrEwWL0BwVA7k9UzPP595mhb+U= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UFHb7zYc; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668616613; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=42qda8YCXAvT0VvMkHOL+t/vCh+HyZAHRup7avtOxrg=; b=HCR50T0G0OWxdNlSiWr45hC/Vp/GV7u/xMYPTFv/dH1v5MFnJhhQTuTt4qS2fEVIEVlb9X hS67KA3rwe2bhR6qEKhfoheEViCxcq5cPnVM6Gm0Y4Z8XslqUT21kQuFJvfTcb1txG+xo4 ioRY2TZUoRRTK+zxEgBLIilr2j1KiyQ= X-Rspamd-Queue-Id: 8104540011 Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UFHb7zYc; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: a6otjjuffaxinbby9zxffhr5xjgk3zj9 X-HE-Tag: 1668616613-841747 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 21, 2022 at 04:36:19PM +0000, James Houghton wrote: > arch_make_huge_pte, which is called immediately following pte_mkhuge, > already makes the necessary changes to the PTE that pte_mkhuge would > have. The generic implementation of arch_make_huge_pte simply calls > pte_mkhuge. > > Signed-off-by: James Houghton Acked-by: Peter Xu -- Peter Xu