From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE719C433FE for ; Wed, 16 Nov 2022 16:35:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 380AB6B0071; Wed, 16 Nov 2022 11:35:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 331536B0073; Wed, 16 Nov 2022 11:35:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D1AA6B0074; Wed, 16 Nov 2022 11:35:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0E0B06B0071 for ; Wed, 16 Nov 2022 11:35:28 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id DA21F40725 for ; Wed, 16 Nov 2022 16:35:27 +0000 (UTC) X-FDA: 80139855894.30.375DC23 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id DE55340006 for ; Wed, 16 Nov 2022 16:35:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668616525; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6P/DkHlylDqeyIXovCIuF2YvI5jJp50fry7v8dWMgVo=; b=DfaiX1hMsVHARK1bI/wpaUoFi/pz9XFBJvUmxLCJcfmvB8f1GpPlnlw9EdQYsgVB4i8VGz iLqv/KdBVA087YCzTCgfgcetnE2V1SK2/S4g3LotVhz9Uz85gMabEHgWt0AzKbM2hf5bgE n8YivekOLQq4R0Say0fGhvbr2soj3PQ= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-185-Rrc8NsYANSWSuvApsgm2RQ-1; Wed, 16 Nov 2022 11:35:22 -0500 X-MC-Unique: Rrc8NsYANSWSuvApsgm2RQ-1 Received: by mail-qt1-f198.google.com with SMTP id bb32-20020a05622a1b2000b003a56991a048so13288255qtb.6 for ; Wed, 16 Nov 2022 08:35:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6P/DkHlylDqeyIXovCIuF2YvI5jJp50fry7v8dWMgVo=; b=QjNQfaZe/fofLi4nTg0GKjS0JFy8GFNOWnVwd+7viRLRG2SnMszj3Q6fi/J7Wgy85R ttgFTM/x6P2z+L+cxD+VMDShfM8tsQjKlcV2yW++bmT1NMm0MgSonB7mG8A9liedVyDf O7ZyXoC2Jbsfu7lMMi8Olf3w3gBIOcSeqKYv4uygKdQLEzWYvRYavzV8ep9rhmwMIvR0 viPPY2JGdrypLXs+I0t3nWR6rlsYmH/VFpPNjCzrxZxaezmxQDLpD4ZpOROG1UG8N2i1 dNsTOtHcJGbAB+7ApArU/FVzNCSixsDyUKFRkm+Kuq0TN3cs9DU9DmPgsCcq6aTP07cH FKew== X-Gm-Message-State: ANoB5pnf/dQtnW50AvIqiEdg7SHOFNBWFGe39IArrLifvk4u0a1hR2YQ DJu6sOBsCLvEy6zabRb8nKwgqgsVjFFp5w0vev4+UPR5exukFqXd5zIY27xEwCXvODLW8/XFWdh EMDeyR2trIRc= X-Received: by 2002:ad4:51c2:0:b0:4bb:781e:6232 with SMTP id p2-20020ad451c2000000b004bb781e6232mr21168450qvq.15.1668616521906; Wed, 16 Nov 2022 08:35:21 -0800 (PST) X-Google-Smtp-Source: AA0mqf6brx9EkEPv6h957QCTT0k14m6ufIkEtyMRa3SdemkO46s593RTxi4C+EMxnGlsb9JQjbPPMA== X-Received: by 2002:ad4:51c2:0:b0:4bb:781e:6232 with SMTP id p2-20020ad451c2000000b004bb781e6232mr21168417qvq.15.1668616521629; Wed, 16 Nov 2022 08:35:21 -0800 (PST) Received: from x1n (bras-base-aurron9127w-grc-46-70-31-27-79.dsl.bell.ca. [70.31.27.79]) by smtp.gmail.com with ESMTPSA id c8-20020ac853c8000000b00359961365f1sm8826363qtq.68.2022.11.16.08.35.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Nov 2022 08:35:21 -0800 (PST) Date: Wed, 16 Nov 2022 11:35:19 -0500 From: Peter Xu To: James Houghton Cc: Mike Kravetz , Muchun Song , David Hildenbrand , David Rientjes , Axel Rasmussen , Mina Almasry , Zach O'Keefe , Manish Mishra , Naoya Horiguchi , "Dr . David Alan Gilbert" , "Matthew Wilcox (Oracle)" , Vlastimil Babka , Baolin Wang , Miaohe Lin , Yang Shi , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v2 02/47] hugetlb: remove mk_huge_pte; it is unused Message-ID: References: <20221021163703.3218176-1-jthoughton@google.com> <20221021163703.3218176-3-jthoughton@google.com> MIME-Version: 1.0 In-Reply-To: <20221021163703.3218176-3-jthoughton@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668616526; a=rsa-sha256; cv=none; b=XlwXfJOvo1DiiZ4rvM4wMHjeUNgfI/+BKFF4q1GvweuYBf/4eyciMzYxG64y3u1MR5z7qF px5y6I0SEDZPoO/AZT1h+BEh3sER7P/XwhqhylqTd/hvrUUE3qe5i7fVb6tcXJGRn7KLFK dXJve+3pFgjKuWhJshoV8sf7vBB+ivY= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DfaiX1hM; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668616526; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6P/DkHlylDqeyIXovCIuF2YvI5jJp50fry7v8dWMgVo=; b=zt6VkqVXlz2XufG0EN9ccZIzVeRkISsX3s0NlnBArQKUUKIBaSZmQH2nQh2ZzPa0K1qw6z CajDa6UNrlpq5bIyyXVEX7JAkwnpmxNT6kQCHkZFs3kS0wOyomAXbadoVDyXZZppantw7U Cx0IcFlPQLNvNz80gOe1iOOSMLcnZK8= Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DfaiX1hM; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com X-Rspam-User: X-Stat-Signature: p5gaiaruc4nyznoqyh5btcckwkhtgkbs X-Rspamd-Queue-Id: DE55340006 X-Rspamd-Server: rspam11 X-HE-Tag: 1668616525-711487 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 21, 2022 at 04:36:18PM +0000, James Houghton wrote: > mk_huge_pte is unused and not necessary. pte_mkhuge is the appropriate > function to call to create a HugeTLB PTE (see > Documentation/mm/arch_pgtable_helpers.rst). > > It is being removed now to avoid complicating the implementation of > HugeTLB high-granularity mapping. > > Signed-off-by: James Houghton Acked-by: Peter Xu -- Peter Xu