From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60672C433FE for ; Wed, 16 Nov 2022 16:14:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 516BA6B0071; Wed, 16 Nov 2022 11:14:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C7068E0001; Wed, 16 Nov 2022 11:14:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 38E496B0074; Wed, 16 Nov 2022 11:14:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 254306B0071 for ; Wed, 16 Nov 2022 11:14:32 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E495EA0A73 for ; Wed, 16 Nov 2022 16:14:31 +0000 (UTC) X-FDA: 80139803142.04.A6D34BA Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf15.hostedemail.com (Postfix) with ESMTP id EC629A000C for ; Wed, 16 Nov 2022 16:14:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=GW/mPvUNa8ycmt36mg7tsVRrtOyrpDhOFXMAIJPJkOE=; b=fv/z8Vq6c3nCHc9j56W7inAPrc 0dHcgJhI7otNJASZ17MhPMVxlFeyoYf4kkWas5Eo1Ec3GLZ11u690qlx7P/v7oNDWAqAIH8H8yfAD /1+ntBb76BGes/DskjfMzwy5tnJE3PtJshRQjDhtJe3GdRxa3iYgGlrg4SgbIsOz1xLUVMP3prz4Y CYEDn4nLle2PKtPXe6tjYaTxXNTKPX+uOVZ0Q2NsIXk+iTVqbBXGxNbargAbd+zNmaZW4alJOF63V hcY8gOY7GqI+y48QsSAg6GKHAhI6xNQtvE8qNC021YrYrfXYgoK0+mLFPHkKrKnIUnGGe6t1rneei zCHLsFCw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovL3H-005l8R-B4; Wed, 16 Nov 2022 16:14:15 +0000 Date: Wed, 16 Nov 2022 08:14:15 -0800 From: Christoph Hellwig To: Jan Kara Cc: Christoph Hellwig , Namjae Jeon , Sungjong Seo , Jan Kara , OGAWA Hirofumi , Mikulas Patocka , Dave Kleikamp , Bob Copeland , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-karma-devel@lists.sourceforge.net, linux-mm@kvack.org Subject: Re: [PATCH 2/9] ext2: remove ->writepage Message-ID: References: <20221113162902.883850-1-hch@lst.de> <20221113162902.883850-3-hch@lst.de> <20221114104927.k5x4i4uanxskfs6m@quack3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221114104927.k5x4i4uanxskfs6m@quack3> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668615271; a=rsa-sha256; cv=none; b=N7yrxVBSn5WrUZcBqLWIjnUtVQmDzrqGSqVf8q4FBycstvc34ibyyf7x7ZN1AfR2WQVJ9Y 4tj51QXW/O9L4X/K7onTRLJuX5pP81mDRDJtCzJocYWvcimhLacepKSc6ZB2WFMuW68pxY Zznb+2wnhn3/0tWaQZIJY6MgFLAChwI= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="fv/z8Vq6"; spf=none (imf15.hostedemail.com: domain of BATV+8c189177036f5411cb52+7024+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+8c189177036f5411cb52+7024+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668615271; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GW/mPvUNa8ycmt36mg7tsVRrtOyrpDhOFXMAIJPJkOE=; b=qfWqHLPOncVyU3YzFe7BjNk3aUGWL3Gbbhq8i1j9dDQfo6FTQhmHSTRmhyPD41CvyvC67B skHMPECQogWTz7giWoJadM9Ha5ho9uWTwQWqm6SdPz0rEf6uL+rWXWuWYCCAaBZ4y48Ykw 911wLmLpg/uapZuPTDQkfZkh8M9oeyo= X-Rspam-User: X-Stat-Signature: rudywbbsfgb3gmkdpjjmkkiwnuwqmfrf X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: EC629A000C Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="fv/z8Vq6"; spf=none (imf15.hostedemail.com: domain of BATV+8c189177036f5411cb52+7024+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+8c189177036f5411cb52+7024+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-HE-Tag: 1668615270-305211 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 14, 2022 at 11:49:27AM +0100, Jan Kara wrote: > On Sun 13-11-22 17:28:55, Christoph Hellwig wrote: > > ->writepage is a very inefficient method to write back data, and only > > used through write_cache_pages or a a fallback when no ->migrate_folio > > method is present. > > > > Signed-off-by: Christoph Hellwig > > Looks good! Feel free to add: The testbot found a problem with this: ext2_commit_chunk calls write_one_page for the IS_DIRSYNC case, and write_one_page calls ->writepage. So I think I need to drop this one for now (none of the other file systems calls write_one_page). And then think what best to do about write_one_page/write_one_folio. I suspect just passing a writepage pointer to them might make most sense, as they are only used by a few file systems, and the calling convention with the locked page doesn't lend itself to using ->writepages.