From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67DB9C4332F for ; Wed, 16 Nov 2022 10:51:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F2F3D8E0009; Wed, 16 Nov 2022 05:51:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EDECF8E0001; Wed, 16 Nov 2022 05:51:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D32438E0009; Wed, 16 Nov 2022 05:51:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BDACA8E0001 for ; Wed, 16 Nov 2022 05:51:01 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 97434805D8 for ; Wed, 16 Nov 2022 10:51:01 +0000 (UTC) X-FDA: 80138987922.05.9D45827 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) by imf22.hostedemail.com (Postfix) with ESMTP id 38D4AC000B for ; Wed, 16 Nov 2022 10:51:01 +0000 (UTC) Received: by mail-ed1-f53.google.com with SMTP id x102so10716577ede.0 for ; Wed, 16 Nov 2022 02:51:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=NMt8HjKxItO2J6bIbRsCvEdSlAZpP8uC48lcisou+nI=; b=eLnGvKK+w1XqLxzowLTo19VxBdUCyRC3jZCwBMpKaUWXXlLi4fs0Axmuul/wRN/I3k Ls2daX/AS8NBqlkGiJqqxb0gEFzgn6n0a6+XnpTDtipAc3J5NayuL7HDBO33beS0D75x K2gRZhVXeM0+lA+7zcbmJS/RVo1YdOeZ/sxms= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NMt8HjKxItO2J6bIbRsCvEdSlAZpP8uC48lcisou+nI=; b=gg9VyQ5ztUuEETx/A0dXWR0GadjxI0tIWy6cbJbjbafgxXCR4vKSfaWPg5KwlMbKHl 76YdZKR+ijCmRugvh/wFcyeR0oAPCJudkYXvq5aTeLMMiKo/5eS31k3X3I1Dxvht4Eb8 yiaOb1gmL7L5ZEymu44nU4f/w6MXUe9ywNhwdccwmxZ0HDRvLy4JUt6zYCrjhvsKFcxv /TWRLQRcp9ozdOxYcbVvNDREcnoMCQqeVrt78zDnYaJ2M3AxnZ6ck3Qj9GhmyMa+Hfb4 C55gXg/xTe8o/T6n8br5jrZaRo7UNPgenktgh8E6/poAxCvMHzz/Fo0vyrlgbtJKHRVx gN4w== X-Gm-Message-State: ANoB5pl2uQoiiJ0R/EUviIojlGmIPwSPTiEivjs5dCF0N4Zervztckqi wY+E+bMyDFY4/a6TZ4s7S0tmbw== X-Google-Smtp-Source: AA0mqf4Z9KF9DYfdJQdqGvbtRloYOPQXnN3MkKcJxdOs80iDic7Ysg9e6qfGKtqJuC+1emfUPfQ+gw== X-Received: by 2002:a50:ff04:0:b0:462:709:9f7b with SMTP id a4-20020a50ff04000000b0046207099f7bmr19331341edu.263.1668595860175; Wed, 16 Nov 2022 02:51:00 -0800 (PST) Received: from phenom.ffwll.local (212-51-149-33.fiber7.init7.net. [212.51.149.33]) by smtp.gmail.com with ESMTPSA id s6-20020a170906bc4600b007aed2057eaesm6056420ejv.161.2022.11.16.02.50.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Nov 2022 02:50:59 -0800 (PST) Date: Wed, 16 Nov 2022 11:50:57 +0100 From: Daniel Vetter To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, x86@kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kselftest@vger.kernel.org, Linus Torvalds , Andrew Morton , Jason Gunthorpe , John Hubbard , Peter Xu , Greg Kroah-Hartman , Andrea Arcangeli , Hugh Dickins , Nadav Amit , Vlastimil Babka , Matthew Wilcox , Mike Kravetz , Muchun Song , Shuah Khan , Lucas Stach , David Airlie , Oded Gabbay , Arnd Bergmann , Christoph Hellwig , Alex Williamson , Inki Dae , Seung-Woo Kim , Kyungmin Park , Daniel Vetter , Krzysztof Kozlowski Subject: Re: [PATCH mm-unstable v1 17/20] drm/exynos: remove FOLL_FORCE usage Message-ID: Mail-Followup-To: David Hildenbrand , linux-kernel@vger.kernel.org, x86@kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kselftest@vger.kernel.org, Linus Torvalds , Andrew Morton , Jason Gunthorpe , John Hubbard , Peter Xu , Greg Kroah-Hartman , Andrea Arcangeli , Hugh Dickins , Nadav Amit , Vlastimil Babka , Matthew Wilcox , Mike Kravetz , Muchun Song , Shuah Khan , Lucas Stach , David Airlie , Oded Gabbay , Arnd Bergmann , Christoph Hellwig , Alex Williamson , Inki Dae , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski References: <20221116102659.70287-1-david@redhat.com> <20221116102659.70287-18-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221116102659.70287-18-david@redhat.com> X-Operating-System: Linux phenom 5.19.0-2-amd64 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668595861; a=rsa-sha256; cv=none; b=q01z4UanN78fCyIPWkzB7Jw3DOvGgooV1azRoA0kXDAkOEfFEM/UwzDfOv6Tcz6CeaXlHd XDPh460qD5U/hdMX7mKFH6/UXUvzJTjUgEAKR5ZUAqvKUL2MWXsOUyMnKNUt5V2/rASIWd qzo5tlE5aNZYM33KsMfYk9UfxY0AB9I= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=ffwll.ch header.s=google header.b=eLnGvKK+; dmarc=none; spf=none (imf22.hostedemail.com: domain of daniel@ffwll.ch has no SPF policy when checking 209.85.208.53) smtp.mailfrom=daniel@ffwll.ch ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668595861; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NMt8HjKxItO2J6bIbRsCvEdSlAZpP8uC48lcisou+nI=; b=BlgDKyJQJsLlJat/dcCMeNUNLHUkjNJ10ja/FVG8JuCgUYac/EHqCTDbeh0Q6Rc9K8deEu cZ6r0AXm+bM4acuNztfpxQCLcAlXJAz76kmr2pUK9mwzcsL0Y6NB3jCRRn+To0qPRD0y+R GIePskc+9N1cBkYcNm++LhF35eDV71o= X-Rspamd-Queue-Id: 38D4AC000B Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=ffwll.ch header.s=google header.b=eLnGvKK+; dmarc=none; spf=none (imf22.hostedemail.com: domain of daniel@ffwll.ch has no SPF policy when checking 209.85.208.53) smtp.mailfrom=daniel@ffwll.ch X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: pqt68otfur9d8trqgre85jih88736stw X-HE-Tag: 1668595861-42813 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 16, 2022 at 11:26:56AM +0100, David Hildenbrand wrote: > FOLL_FORCE is really only for ptrace access. As we unpin the pinned pages > using unpin_user_pages_dirty_lock(true), the assumption is that all these > pages are writable. > > FOLL_FORCE in this case seems to be a legacy leftover. Let's just remove > it. > > Cc: Inki Dae > Cc: Seung-Woo Kim > Cc: Kyungmin Park > Cc: David Airlie > Cc: Daniel Vetter > Cc: Krzysztof Kozlowski > Signed-off-by: David Hildenbrand Reviewed-by: Daniel Vetter Plus ack for merging through the appropriate non-drm tree. -Daniel > --- > drivers/gpu/drm/exynos/exynos_drm_g2d.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c > index 471fd6c8135f..e19c2ceb3759 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c > @@ -477,7 +477,7 @@ static dma_addr_t *g2d_userptr_get_dma_addr(struct g2d_data *g2d, > } > > ret = pin_user_pages_fast(start, npages, > - FOLL_FORCE | FOLL_WRITE | FOLL_LONGTERM, > + FOLL_WRITE | FOLL_LONGTERM, > g2d_userptr->pages); > if (ret != npages) { > DRM_DEV_ERROR(g2d->dev, > -- > 2.38.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch