From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EECD3C43219 for ; Wed, 16 Nov 2022 10:49:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8EE238E0009; Wed, 16 Nov 2022 05:49:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C51E8E0001; Wed, 16 Nov 2022 05:49:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 766FB8E0009; Wed, 16 Nov 2022 05:49:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 66AE88E0001 for ; Wed, 16 Nov 2022 05:49:48 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2597BAB26D for ; Wed, 16 Nov 2022 10:49:48 +0000 (UTC) X-FDA: 80138984856.02.5DF9E85 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) by imf28.hostedemail.com (Postfix) with ESMTP id A8E4AC0006 for ; Wed, 16 Nov 2022 10:49:47 +0000 (UTC) Received: by mail-ed1-f49.google.com with SMTP id z18so25931317edb.9 for ; Wed, 16 Nov 2022 02:49:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=SB0xMxg7mb7arNhoP48cqWafxbk28Z1Lix7iS7Zkf4o=; b=G+yH7gGM79Kur0Iop0CPPA+qhziqzAzwIurg983ubYb3WshrhUBjt115nMP15JVtFB bCAGjPfacpREtOfp/xR/YX1SymsdQ1bgnCyPvMlgHC3mzRuO7K3B6poJkP/JWiUCmMWF GisY2xBmQqATnhhXA26BG81FXfyHx1zsVnNWg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SB0xMxg7mb7arNhoP48cqWafxbk28Z1Lix7iS7Zkf4o=; b=jEgntwbTJcuPpkfMzF4KhwnJTdmuOa4nfJRrBY3lbbaZ72LEqSp+ntG6vZzICNHYJa 0I4KiFeb7eMG7Zbobf3EH/SRn42SFBjnsG/ygf4mvxwJqUDj0NtdInXvfV9x2e0rVyKo A11z6LuJxOfVFgEbvcR362OSsDKP5GTsdQOcoz4euVura4Xqut999pS80Tb/u2GZDgyo sT/Vdui/zptklwwgrokHYZuIJfvrjBWd+Jx+4DcmseadagPiZDXhU5+1yXGd3HM28AiX u/ELeaAX/Gzyjj8mWlqFHK3NMXJuEJ4S6a2sg2j2XgTboKKUrs6NECAkG+GYnXPcmM4h vL9Q== X-Gm-Message-State: ANoB5pktfRyllD559+gcO7lLP/T1mGbZWm7+GwfB3r/XH5QndBU8ei0o YdQxCw44m+Z8380vsvZ4F8krIw== X-Google-Smtp-Source: AA0mqf5eZw0lnDAfrqoVYz8ol539itw9JN3l4qV2Eir0Zt6pEgAkXKur5xarVrPRHlm5su04xf/hGA== X-Received: by 2002:a05:6402:3458:b0:458:b9f9:9fba with SMTP id l24-20020a056402345800b00458b9f99fbamr19055554edc.305.1668595786519; Wed, 16 Nov 2022 02:49:46 -0800 (PST) Received: from phenom.ffwll.local (212-51-149-33.fiber7.init7.net. [212.51.149.33]) by smtp.gmail.com with ESMTPSA id kx13-20020a170907774d00b0078ba492db81sm6694451ejc.9.2022.11.16.02.49.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Nov 2022 02:49:46 -0800 (PST) Date: Wed, 16 Nov 2022 11:49:43 +0100 From: Daniel Vetter To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, x86@kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kselftest@vger.kernel.org, Linus Torvalds , Andrew Morton , Jason Gunthorpe , John Hubbard , Peter Xu , Greg Kroah-Hartman , Andrea Arcangeli , Hugh Dickins , Nadav Amit , Vlastimil Babka , Matthew Wilcox , Mike Kravetz , Muchun Song , Shuah Khan , Lucas Stach , David Airlie , Oded Gabbay , Arnd Bergmann , Christoph Hellwig , Alex Williamson , Daniel Vetter , Russell King , Christian Gmeiner Subject: Re: [PATCH mm-unstable v1 14/20] drm/etnaviv: remove FOLL_FORCE usage Message-ID: Mail-Followup-To: David Hildenbrand , linux-kernel@vger.kernel.org, x86@kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kselftest@vger.kernel.org, Linus Torvalds , Andrew Morton , Jason Gunthorpe , John Hubbard , Peter Xu , Greg Kroah-Hartman , Andrea Arcangeli , Hugh Dickins , Nadav Amit , Vlastimil Babka , Matthew Wilcox , Mike Kravetz , Muchun Song , Shuah Khan , Lucas Stach , David Airlie , Oded Gabbay , Arnd Bergmann , Christoph Hellwig , Alex Williamson , Russell King , Christian Gmeiner References: <20221116102659.70287-1-david@redhat.com> <20221116102659.70287-15-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221116102659.70287-15-david@redhat.com> X-Operating-System: Linux phenom 5.19.0-2-amd64 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668595787; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SB0xMxg7mb7arNhoP48cqWafxbk28Z1Lix7iS7Zkf4o=; b=hhTpzFryeXd4iOhBZFrbEn3izM1JfhA5dl3+J22wuoyy1NY9agcb5JOTADgMm4J1ynMkse ZJAHzETzCvS++HG8tK1NazGBGt+Z4MAU0ePrh0j/WUpY9AwDYdbmOOV9TJHAkMtTIWxD09 nG9BuhPwou7lEqnjUaXL4th63NAjs6g= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=ffwll.ch header.s=google header.b=G+yH7gGM; dmarc=none; spf=none (imf28.hostedemail.com: domain of daniel@ffwll.ch has no SPF policy when checking 209.85.208.49) smtp.mailfrom=daniel@ffwll.ch ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668595787; a=rsa-sha256; cv=none; b=57FAPQNrI9nYV5yY5OAnVuc9QUvthBCYIjPdDWzM12ndW/dVt9R/oyGu5Q8TOf8wnqUfLG hAqjCqLzP/nqLE8WB1RoJjMw0561QmHpS6HlvXPeQv7jcQ6j81tK4Kst2giQECyt7M94UD UrlmEVBuTSXuRSju/iv1P5s7VB5YqN0= X-Rspam-User: X-Stat-Signature: 4tpsibkgok5oe53ub6wfxwicozt7g876 X-Rspamd-Queue-Id: A8E4AC0006 Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=ffwll.ch header.s=google header.b=G+yH7gGM; dmarc=none; spf=none (imf28.hostedemail.com: domain of daniel@ffwll.ch has no SPF policy when checking 209.85.208.49) smtp.mailfrom=daniel@ffwll.ch X-Rspamd-Server: rspam07 X-HE-Tag: 1668595787-252866 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 16, 2022 at 11:26:53AM +0100, David Hildenbrand wrote: > GUP now supports reliable R/O long-term pinning in COW mappings, such > that we break COW early. MAP_SHARED VMAs only use the shared zeropage so > far in one corner case (DAXFS file with holes), which can be ignored > because GUP does not support long-term pinning in fsdax (see > check_vma_flags()). > > commit cd5297b0855f ("drm/etnaviv: Use FOLL_FORCE for userptr") > documents that FOLL_FORCE | FOLL_WRITE was really only used for reliable > R/O pinning. > > Consequently, FOLL_FORCE | FOLL_WRITE | FOLL_LONGTERM is no longer required > for reliable R/O long-term pinning: FOLL_LONGTERM is sufficient. So stop > using FOLL_FORCE, which is really only for ptrace access. > > Cc: Daniel Vetter > Cc: Lucas Stach > Cc: Russell King > Cc: Christian Gmeiner > Cc: David Airlie > Signed-off-by: David Hildenbrand Reviewed-by: Daniel Vetter Also ack for merging through whatever tree suits best, since I guess this should all land together. -Daniel > --- > drivers/gpu/drm/etnaviv/etnaviv_gem.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c > index cc386f8a7116..efe2240945d0 100644 > --- a/drivers/gpu/drm/etnaviv/etnaviv_gem.c > +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.c > @@ -638,6 +638,7 @@ static int etnaviv_gem_userptr_get_pages(struct etnaviv_gem_object *etnaviv_obj) > struct page **pvec = NULL; > struct etnaviv_gem_userptr *userptr = &etnaviv_obj->userptr; > int ret, pinned = 0, npages = etnaviv_obj->base.size >> PAGE_SHIFT; > + unsigned int gup_flags = FOLL_LONGTERM; > > might_lock_read(¤t->mm->mmap_lock); > > @@ -648,14 +649,15 @@ static int etnaviv_gem_userptr_get_pages(struct etnaviv_gem_object *etnaviv_obj) > if (!pvec) > return -ENOMEM; > > + if (!userptr->ro) > + gup_flags |= FOLL_WRITE; > + > do { > unsigned num_pages = npages - pinned; > uint64_t ptr = userptr->ptr + pinned * PAGE_SIZE; > struct page **pages = pvec + pinned; > > - ret = pin_user_pages_fast(ptr, num_pages, > - FOLL_WRITE | FOLL_FORCE | FOLL_LONGTERM, > - pages); > + ret = pin_user_pages_fast(ptr, num_pages, gup_flags, pages); > if (ret < 0) { > unpin_user_pages(pvec, pinned); > kvfree(pvec); > -- > 2.38.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch