From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AED5C433FE for ; Wed, 16 Nov 2022 10:49:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C98468E0009; Wed, 16 Nov 2022 05:49:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C47ED8E0001; Wed, 16 Nov 2022 05:49:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE8C18E0009; Wed, 16 Nov 2022 05:49:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9F21F8E0001 for ; Wed, 16 Nov 2022 05:49:01 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 55070406C2 for ; Wed, 16 Nov 2022 10:49:01 +0000 (UTC) X-FDA: 80138982882.14.900D07F Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by imf03.hostedemail.com (Postfix) with ESMTP id EEE342000B for ; Wed, 16 Nov 2022 10:49:00 +0000 (UTC) Received: by mail-ej1-f49.google.com with SMTP id k2so43109490ejr.2 for ; Wed, 16 Nov 2022 02:49:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=OSCwvxDUrivspPm0mWYSEKkrMB19obOv39RUwyA0PH0=; b=VJ17UkTNHUXDMc38lOye7y2paGd4FOYHBRYpe2vgelPuC55Z4g5rnX+xNi0NFRGTrN mdMUVKijrbkJJfn3y8Tm8vf3pLdF4omxIOM6UM8S6CVz2p3NrVUPvz4FNRN3RF3rQ/lN 9z9ibLXy5LDPJfO5cF7QIpPDKsW5E+659K7gg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OSCwvxDUrivspPm0mWYSEKkrMB19obOv39RUwyA0PH0=; b=ZmaiVQDbAQesa4nL3zd6siQ87mximeI9mcKWVic9Vz9L3lSS6mLmd6zOc5XZkiOU3t 6+mr8GpswfYhaZ3rQ68pFTPDHNMHnnUOYydnKNG4PpYDlMFAePLjUWagNeLsjXEOLrw2 1t1U6ZDI+UNyodEf615c4+1wrsrtLf+O/3w2RUluuEjMv8RJi3kmzoEyZML6g9BCrxY3 7qr5ocZCr/KP/ANwLJoBjFxldeOn0/EtjEXjZl8jIUkwlexnhSNp7Y5fQjR0xxE5cxn0 rA4ZN/xFrIc4h4OYvC2ph2RjUGq7HUqeRxQJujQWSVSZMgkcGnWWShgoV9OJjCzcDMSd 1hTA== X-Gm-Message-State: ANoB5pmItGEsQgtsO5vX2flaAf5ScmHn1fdS7Vy8xIwCZ/TzIazjHXVm KUP+0F/H3GckN8LM2ttcDpiZ6w== X-Google-Smtp-Source: AA0mqf6lc5lrEzUlEqYgu67h96R4r19JtBnDlqqKBl9ey0VuIf1EYIOTKVPSxvCTipQmxuaB88n35Q== X-Received: by 2002:a17:906:970e:b0:7ad:ccae:a30d with SMTP id k14-20020a170906970e00b007adccaea30dmr18079730ejx.704.1668595739329; Wed, 16 Nov 2022 02:48:59 -0800 (PST) Received: from phenom.ffwll.local (212-51-149-33.fiber7.init7.net. [212.51.149.33]) by smtp.gmail.com with ESMTPSA id g13-20020a50ec0d000000b0045b3853c4b7sm7352935edr.51.2022.11.16.02.48.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Nov 2022 02:48:58 -0800 (PST) Date: Wed, 16 Nov 2022 11:48:56 +0100 From: Daniel Vetter To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org, Greg Kroah-Hartman , dri-devel@lists.freedesktop.org, linux-mm@kvack.org, Nadav Amit , linux-kselftest@vger.kernel.org, sparclinux@vger.kernel.org, Shuah Khan , Andrea Arcangeli , linux-samsung-soc@vger.kernel.org, linux-rdma@vger.kernel.org, x86@kernel.org, Hugh Dickins , Matthew Wilcox , Christoph Hellwig , Jason Gunthorpe , Vlastimil Babka , linux-media@vger.kernel.org, Arnd Bergmann , John Hubbard , linux-um@lists.infradead.org, etnaviv@lists.freedesktop.org, Alex Williamson , Peter Xu , Muchun Song , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, Oded Gabbay , linux-mips@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-security-module@vger.kernel.org, linux-alpha@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton , Linus Torvalds , Mike Kravetz Subject: Re: [PATCH mm-unstable v1 13/20] media: videobuf-dma-sg: remove FOLL_FORCE usage Message-ID: Mail-Followup-To: David Hildenbrand , linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org, Greg Kroah-Hartman , dri-devel@lists.freedesktop.org, linux-mm@kvack.org, Nadav Amit , linux-kselftest@vger.kernel.org, sparclinux@vger.kernel.org, Shuah Khan , Andrea Arcangeli , linux-samsung-soc@vger.kernel.org, linux-rdma@vger.kernel.org, x86@kernel.org, Hugh Dickins , Matthew Wilcox , Christoph Hellwig , Jason Gunthorpe , Vlastimil Babka , linux-media@vger.kernel.org, Arnd Bergmann , John Hubbard , linux-um@lists.infradead.org, etnaviv@lists.freedesktop.org, Alex Williamson , Peter Xu , Muchun Song , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, Oded Gabbay , linux-mips@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-security-module@vger.kernel.org, linux-alpha@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton , Linus Torvalds , Mike Kravetz References: <20221116102659.70287-1-david@redhat.com> <20221116102659.70287-14-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221116102659.70287-14-david@redhat.com> X-Operating-System: Linux phenom 5.19.0-2-amd64 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668595741; a=rsa-sha256; cv=none; b=YaAIY9b/YbikOvnXRF24WELqIF99av9NGKQOPEamtmFcxtpJ1srvMKHajRXs/9D8+14yR0 qose1lwRSGxydZ47ztF5OyJmCoeHBo4fjx22eB0pK5fuguuhIvSyi9hwXFGXo73rkCewRg jh0NjFXGPIeV+es6rCPcVAqSw62h740= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=ffwll.ch header.s=google header.b=VJ17UkTN; dmarc=none; spf=none (imf03.hostedemail.com: domain of daniel@ffwll.ch has no SPF policy when checking 209.85.218.49) smtp.mailfrom=daniel@ffwll.ch ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668595741; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OSCwvxDUrivspPm0mWYSEKkrMB19obOv39RUwyA0PH0=; b=cROPHUljk/hWhmxRAiUqHRqV8oVCk6TJnVsp7wx2KmO3emcBOgNr/sI3NIWf5IBr7CR5LY p6wRCWAGV3fgvRmtN+uEyz2P4VdzV+fdvZc5rLhBdsQLPD+ipi03H3IxX1mK+oPXf76y7y YErTXR/z/cEJJvuNkx7PHsYDb/D9Wjc= X-Rspam-User: Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=ffwll.ch header.s=google header.b=VJ17UkTN; dmarc=none; spf=none (imf03.hostedemail.com: domain of daniel@ffwll.ch has no SPF policy when checking 209.85.218.49) smtp.mailfrom=daniel@ffwll.ch X-Rspamd-Server: rspam02 X-Stat-Signature: 45mxbknjbc7gmwopx1wpjyum94qfgkwe X-Rspamd-Queue-Id: EEE342000B X-HE-Tag: 1668595740-311231 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 16, 2022 at 11:26:52AM +0100, David Hildenbrand wrote: > GUP now supports reliable R/O long-term pinning in COW mappings, such > that we break COW early. MAP_SHARED VMAs only use the shared zeropage so > far in one corner case (DAXFS file with holes), which can be ignored > because GUP does not support long-term pinning in fsdax (see > check_vma_flags()). > > Consequently, FOLL_FORCE | FOLL_WRITE | FOLL_LONGTERM is no longer required > for reliable R/O long-term pinning: FOLL_LONGTERM is sufficient. So stop > using FOLL_FORCE, which is really only for ptrace access. > > Cc: Mauro Carvalho Chehab > Signed-off-by: David Hildenbrand I looked at this a while ago when going through some of the follow_pfn stuff, so Reviewed-by: Daniel Vetter > --- > drivers/media/v4l2-core/videobuf-dma-sg.c | 14 +++++--------- > 1 file changed, 5 insertions(+), 9 deletions(-) > > diff --git a/drivers/media/v4l2-core/videobuf-dma-sg.c b/drivers/media/v4l2-core/videobuf-dma-sg.c > index f75e5eedeee0..234e9f647c96 100644 > --- a/drivers/media/v4l2-core/videobuf-dma-sg.c > +++ b/drivers/media/v4l2-core/videobuf-dma-sg.c > @@ -151,17 +151,16 @@ static void videobuf_dma_init(struct videobuf_dmabuf *dma) > static int videobuf_dma_init_user_locked(struct videobuf_dmabuf *dma, > int direction, unsigned long data, unsigned long size) > { > + unsigned int gup_flags = FOLL_LONGTERM; > unsigned long first, last; > - int err, rw = 0; > - unsigned int flags = FOLL_FORCE; > + int err; > > dma->direction = direction; > switch (dma->direction) { > case DMA_FROM_DEVICE: > - rw = READ; > + gup_flags |= FOLL_WRITE; > break; > case DMA_TO_DEVICE: > - rw = WRITE; > break; > default: > BUG(); > @@ -177,14 +176,11 @@ static int videobuf_dma_init_user_locked(struct videobuf_dmabuf *dma, > if (NULL == dma->pages) > return -ENOMEM; > > - if (rw == READ) > - flags |= FOLL_WRITE; > - > dprintk(1, "init user [0x%lx+0x%lx => %lu pages]\n", > data, size, dma->nr_pages); > > - err = pin_user_pages(data & PAGE_MASK, dma->nr_pages, > - flags | FOLL_LONGTERM, dma->pages, NULL); > + err = pin_user_pages(data & PAGE_MASK, dma->nr_pages, gup_flags, > + dma->pages, NULL); > > if (err != dma->nr_pages) { > dma->nr_pages = (err >= 0) ? err : 0; > -- > 2.38.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch