From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EA77C4332F for ; Wed, 16 Nov 2022 05:46:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ABBA76B0071; Wed, 16 Nov 2022 00:46:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A6B456B0072; Wed, 16 Nov 2022 00:46:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 932F58E0001; Wed, 16 Nov 2022 00:46:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 80D796B0071 for ; Wed, 16 Nov 2022 00:46:58 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 450F31608F7 for ; Wed, 16 Nov 2022 05:46:58 +0000 (UTC) X-FDA: 80138221716.26.1FECA03 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf15.hostedemail.com (Postfix) with ESMTP id 2E5D1A0009 for ; Wed, 16 Nov 2022 05:46:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=8V0IP0Q1zd7NAy2EUGvsK/hhbASCjuEOFpMfbZU7rKc=; b=IqgkINI0lkyxOYd2ElfETnYIVr LIfSZeE3+sNgoco0A8lbTB1pLJARFA5RwoclL09EF/twp1NH7JVjOGNhOK16nHsMwDuXoCRP4CwMp rCnGlz6N6zRBznv0xB/mLXQz1nlsmDYPSjYIEsD7sQpoKJPIjqAM/1gagfWY3PWbTFNzJznFqVH8A Xc9yhAqn/NtAQtysuLX0HMdeA3JEM14hlX6CKrC4JNHNSYYtyr27CnDOjHYzZncO1DSsk8AXFPgTy IK1A6Zdc4nGNLVl2zWwNPhrUqWDNDb0/fn5DSKBcTkn2ubNKDEZ5YiZXtHCRQ7OZgX8wove4RiJxL dyI2eOYQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovBG6-0006ne-PW; Wed, 16 Nov 2022 05:46:50 +0000 Date: Tue, 15 Nov 2022 21:46:50 -0800 From: Christoph Hellwig To: Dave Chinner Cc: "Darrick J. Wong" , Christoph Hellwig , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 6/9] xfs: xfs_bmap_punch_delalloc_range() should take a byte range Message-ID: References: <20221115013043.360610-1-david@fromorbit.com> <20221115013043.360610-7-david@fromorbit.com> <20221116005723.GA3600936@dread.disaster.area> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221116005723.GA3600936@dread.disaster.area> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668577618; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8V0IP0Q1zd7NAy2EUGvsK/hhbASCjuEOFpMfbZU7rKc=; b=ThaUqDYHd4JjrLXWtXrPMRY4gXe3T5Mf0wwxlhsRnkY55ltuZmcVw0/07O4XyvDNyN1Hml Hez7oHUsx3Z6vEebJ1VxACGOx+HoyTDmc2Hxr4cDUenvxA1b2ABmdvCiC5gloaQ4oTvAcr ZZL3Xsd6564L+oNkg+8Z+QBu13PBkqI= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=IqgkINI0; spf=none (imf15.hostedemail.com: domain of BATV+8c189177036f5411cb52+7024+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+8c189177036f5411cb52+7024+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668577618; a=rsa-sha256; cv=none; b=dim2T3Wp3LstETuOoD2tPpXu7q7gmsFQg6DOhvdlgqPjhid7M+c3F6cUnNjVNqxVCCJqni XksiRiogFPW77TI5BiHh/stACII2YaMJfnTdyoy3O+xsorH975+aCzY1ZJch0qZhQDJsP3 TGNzxDzuVKAKUpRmp8eepG0Bs/zStaw= X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 2E5D1A0009 Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=IqgkINI0; spf=none (imf15.hostedemail.com: domain of BATV+8c189177036f5411cb52+7024+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+8c189177036f5411cb52+7024+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-Stat-Signature: sfzc1c6j5ms9aua8ciu6iypddp39mrq6 X-HE-Tag: 1668577616-705859 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 16, 2022 at 11:57:23AM +1100, Dave Chinner wrote: > The fact that Christoph NAK'd exporting mapping_seek_hole_data() > this time around is just Plain Fucking Annoying. Thank you so much, I love you too. > He didn't say > anything in the last thread about it after I explained why I used > it, so I had assumed it was all OK. Quote from the last thread: "So, the whole scan for delalloc logic seems pretty generic, I think it can an should be lifted to iomap, with xfs_buffered_write_delalloc_punch provided as a callback." > I've already been playing patch golf all morning now to rearrange > all the deck chairs to avoid exporting mapping_seek_hole_data(). > Instead we now have an exported iomap function that wraps > mapping_seek_hole_data, and the wrapper function I added in patch 4 > is now the callback function that is passed 3 layers deep into the > iomap code. > > Hence the xfs_buffered_write_delalloc_punch() function needs to > remain - we can't elide it entire like this patch does - because now > we need a callback function that we can provide to the iomap code so > we avoid coupling internal XFS implementation functions to external > VFS APIs. Which was roughly was the intention all along.