From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D18AC433FE for ; Tue, 15 Nov 2022 23:48:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 159D56B0073; Tue, 15 Nov 2022 18:48:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 109FC8E0001; Tue, 15 Nov 2022 18:48:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F136A6B0075; Tue, 15 Nov 2022 18:48:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DEFFA6B0073 for ; Tue, 15 Nov 2022 18:48:37 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B85E2A0A51 for ; Tue, 15 Nov 2022 23:48:37 +0000 (UTC) X-FDA: 80137318674.25.AA2C2C3 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf26.hostedemail.com (Postfix) with ESMTP id 44E6114000C for ; Tue, 15 Nov 2022 23:48:36 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3DCECB81B79; Tue, 15 Nov 2022 23:48:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EDCD4C433C1; Tue, 15 Nov 2022 23:48:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668556114; bh=OdIB60WCiKgiVdrlaQ1X+riGns5M5D4iYH1L7Fp6VEE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=F4BaDGbZVnV6Nt165ohbpw9UVCIpoeCr5mSpRB7XHeV5VOBhwtJLM/ejEh1Wy2NK0 elyss08X564tK0GksVIM4yYYze4RxQLg3ZgFYSdGuCzbk1kMnle/tH1+6tUJWybVDk +3skUANZL2RzxojAQXyxczbR09gphEdnUkFnisJNfLt4IupSJJqtJLLF0hQyyLxXJm B/I7YyE8lW08SqDamDxUKcuN3YzbqRTW4G4wCAYPz53lTVH06c8tqLvOdktBvN63nv X9YhxflWJ3WmLOwFZRr5Fse0Qdfg7B51TESPnbNlXMZ2TXxdEEwYqfAAGHF8imly5P E2sGBHaZFXfQQ== Date: Tue, 15 Nov 2022 15:48:33 -0800 From: "Darrick J. Wong" To: Christoph Hellwig Cc: Dave Chinner , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 6/9] xfs: xfs_bmap_punch_delalloc_range() should take a byte range Message-ID: References: <20221115013043.360610-1-david@fromorbit.com> <20221115013043.360610-7-david@fromorbit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668556117; a=rsa-sha256; cv=none; b=JTrniwD7Q1oSW0MnWhMA4AWcgIfPh73mMuc+gIp0mfIL1ZWRYs1xcvwtXqY2yS0CVqOeqK +lL+FNvAmSCHpM1vOVaWzmEQD1t1UNgLVdA4tVI5pX5lSY+CGyNgehlk/Q/ZrIkHVkzHp9 n8yK2CsoFkvDgcv4xxHv4mA7KcMxnq0= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=F4BaDGbZ; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of djwong@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=djwong@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668556117; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h5PV0GL0580b8tmpV7D40V+g2do1esb3njFwr2jnOMQ=; b=VLda0MQ08Cln7ccFpc8vgKNqzmNDgI/Ib9GE/iwxckvjBFDlz9ThffWC1PJXcoUsijnNtI xtwPjwypkpOcGVciECocmT0/bMC71sIxzE6UuGphMwISNUrk2qntU9riO5dF8037aMtnok 66/hj46k7gJB3AJL2FNRXAGfJ4niVi4= X-Rspam-User: Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=F4BaDGbZ; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of djwong@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=djwong@kernel.org X-Rspamd-Server: rspam02 X-Stat-Signature: in5ecp5e34zr85czo6y5rd9fz3e6mx94 X-Rspamd-Queue-Id: 44E6114000C X-HE-Tag: 1668556116-609721 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 15, 2022 at 12:44:46AM -0800, Christoph Hellwig wrote: > On Tue, Nov 15, 2022 at 12:30:40PM +1100, Dave Chinner wrote: > > From: Dave Chinner > > > > All the callers of xfs_bmap_punch_delalloc_range() jump through > > hoops to convert a byte range to filesystem blocks before calling > > xfs_bmap_punch_delalloc_range(). Instead, pass the byte range to > > xfs_bmap_punch_delalloc_range() and have it do the conversion to > > filesystem blocks internally. > > Ok, so we do this here. Why can't we just do this earlier and > avoid the strange inbetween stage with a wrapper? Probably to avoid rewriting the previous patch with this units change, is my guess. Dave, do you want to merge with this patch 4? I'm satisfied enough with patches 4 and 6 that I'd rather get this out to for-next for further testing than play more patch golf. Reviewed-by: Darrick J. Wong --D