From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7CA6C4332F for ; Tue, 15 Nov 2022 23:26:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4C9B36B0071; Tue, 15 Nov 2022 18:26:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4793F6B0072; Tue, 15 Nov 2022 18:26:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 341586B0073; Tue, 15 Nov 2022 18:26:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 23BE16B0071 for ; Tue, 15 Nov 2022 18:26:30 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id CCF511205A5 for ; Tue, 15 Nov 2022 23:26:29 +0000 (UTC) X-FDA: 80137262898.30.0C90842 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf14.hostedemail.com (Postfix) with ESMTP id 63EB110000D for ; Tue, 15 Nov 2022 23:26:29 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6AF8761772; Tue, 15 Nov 2022 23:26:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C0F74C433C1; Tue, 15 Nov 2022 23:26:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668554787; bh=Enk5bunTj07I51D2X8M1XeCZB6Ho2p8Hm2FOFwdLteg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oArHTPfCV7nYcOXshByZFHpNiwEJ6lt/M1DZqqPz76NwaqJXLVPVKlkkbTnCa1J+z HqDisDQIapx9iIf67UaGfsrDXZsaqbadrwcftb6RixBDg8oBSO6gdmheAswqd1+G34 2m3+UcDZlGr02FnSAs4FE0GBEp7lygcnPbutjGFMOe4oAMv7fjWWIY+o3I/NfiJLBI KlTnupyBBGOrAg0ezyX7kXRrhDeI2dt0viYcOSUn24eKpBtpkHwtbOW+EzZsFc4gLg D4JxRiuOAL0fRYhVkuFJ/on+eqdup4iJ0RVjrtvdGeP/LJjuW9kjjL5xy8EE6a+k4L lph6fQ8hFr/9Q== Date: Tue, 15 Nov 2022 15:26:27 -0800 From: "Darrick J. Wong" To: Christoph Hellwig Cc: Dave Chinner , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 8/9] xfs: use iomap_valid method to detect stale cached iomaps Message-ID: References: <20221115013043.360610-1-david@fromorbit.com> <20221115013043.360610-9-david@fromorbit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668554789; a=rsa-sha256; cv=none; b=1GndA7Umg/VxD6nX+VRS9lYlELFKlH3Eu5aFJCE1pCHLCCa7zp48gFjxyoI/tPmczlYz5i Ieat4KpYc/uXnMiKgMvopFEYRr90S1OzHXjPXB+g2ovtOIV27alZj8dt4//MFoHPktCRKc 3bkuheVZcpp0OaXy6FHA0BJHF3kJruY= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=oArHTPfC; spf=pass (imf14.hostedemail.com: domain of djwong@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668554789; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=z8lrOJoCbd6l/aSrNqtem3tzZV0kMeCoAQRoU12t1VA=; b=bWn0I6c1BAYEmoBxMlE/vk9eo/Em8TJanqZOK3l+eovsP+ksSg1PFxaX3O3dI0U4lQ4VV/ XLmrAHFG1Pm0NHJFreYb9C9lynIgGWkNANAh9d0mlxU8GUYgcLVEeMfcUQIWFSF38Qhiva K5zuzWFl+CDVtNEVDJVFNDDPubF++R4= X-Stat-Signature: gosyy7fi4ixh3p1gf6x476xh5fjwh4r7 X-Rspamd-Queue-Id: 63EB110000D Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=oArHTPfC; spf=pass (imf14.hostedemail.com: domain of djwong@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1668554789-120420 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 15, 2022 at 12:49:49AM -0800, Christoph Hellwig wrote: > On Tue, Nov 15, 2022 at 12:30:42PM +1100, Dave Chinner wrote: > > +/* > > + * Check that the iomap passed to us is still valid for the given offset and > > + * length. > > + */ > > +static bool > > +xfs_iomap_valid( > > + struct inode *inode, > > + const struct iomap *iomap) > > +{ > > + struct xfs_inode *ip = XFS_I(inode); > > + u64 cookie = 0; > > + > > + if (iomap->flags & IOMAP_F_XATTR) { > > + cookie = READ_ONCE(ip->i_af.if_seq); > > + } else { > > + if ((iomap->flags & IOMAP_F_SHARED) && ip->i_cowfp) > > + cookie = (u64)READ_ONCE(ip->i_cowfp->if_seq) << 32; > > + cookie |= READ_ONCE(ip->i_df.if_seq); > > + } > > + return cookie == iomap->validity_cookie; > > How can this be called with IOMAP_F_XATTR set? xfs_xattr_iomap_begin for FIEMAP, if I'm not mistaken. > Also the code seems to duplicate xfs_iomap_inode_sequence, so > we just call that: > > return cookie == xfs_iomap_inode_sequence(XFS_I(inode), iomap->flags); I was thinking that too. --D