From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E8C9C4332F for ; Tue, 15 Nov 2022 20:18:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E1A9B6B0071; Tue, 15 Nov 2022 15:18:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DA42E6B0072; Tue, 15 Nov 2022 15:18:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C1CF86B0073; Tue, 15 Nov 2022 15:18:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id ADE286B0071 for ; Tue, 15 Nov 2022 15:18:47 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7362E1204BC for ; Tue, 15 Nov 2022 20:18:47 +0000 (UTC) X-FDA: 80136789894.16.11F1171 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf10.hostedemail.com (Postfix) with ESMTP id EC238C0004 for ; Tue, 15 Nov 2022 20:18:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=p0GkDIqlaDtoqXa413Yu7SgMe+uJq2kGGguXZr+J0IA=; b=e6vnBK5ePXjGJx/5vJts9ENaef 3tatlAx4cg6sUjNfqAiuLFU8jnWZteZrH15vHmfjIsaWFY0Y2GBRcbafj7G4J4xGpvrfj+p0LmQxw cfus1poMbpdzG7Z3l1FJD7uY/vwtXRTD/25IJ2S9+1bZVjuusrPW+gNM7AzOTSu0kiVtxpoMI2sU/ 46ZLwbREHDtEiIB7vLrCymqp7cBiF8uxILtvBxqaSowQvaYiMM7s1HxN6W/p4G2cCbhxx1JnbHUaO J7DnbW7RJdhbRzGHrchoPjHqI94lcesVFwtXh5dUVHJmXaLyAYEp3QosmXOplOsEwuFcyvchW1uFy dnALxZ9Q==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1ov2O5-0015uW-5M; Tue, 15 Nov 2022 20:18:29 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 6B3E93002EC; Tue, 15 Nov 2022 15:22:01 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 544152CB43B65; Tue, 15 Nov 2022 15:22:01 +0100 (CET) Date: Tue, 15 Nov 2022 15:22:01 +0100 From: Peter Zijlstra To: Rick Edgecombe Cc: x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Randy Dunlap , "Ravi V . Shankar" , Weijiang Yang , "Kirill A . Shutemov" , John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com, akpm@linux-foundation.org, Yu-cheng Yu Subject: Re: [PATCH v3 27/37] x86/shstk: Introduce routines modifying shstk Message-ID: References: <20221104223604.29615-1-rick.p.edgecombe@intel.com> <20221104223604.29615-28-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221104223604.29615-28-rick.p.edgecombe@intel.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668543527; a=rsa-sha256; cv=none; b=5LV0KpBJTJL8yDUrl69/w4T9/k162vKLT6F5QOZw4wOK2wkTCeJhJFZjPQehiB/niB5OHR S2aDzu2ZujELWc+LOZBzlSpEuSyCznfArA72bEke/TLmcFT+1sbMvUK0+hmFTAheISXaWe u2GovtarorfPDUnUkxbe5vWVPMVy/1c= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=e6vnBK5e; spf=none (imf10.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668543527; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=p0GkDIqlaDtoqXa413Yu7SgMe+uJq2kGGguXZr+J0IA=; b=J6QzPEp0D/qpuvlgzt3U2TqglYl6CmKYaqrt5RuNfoscNl2BjvlKEnh+hj/4a4ovw6rLAu McrGgks8LPJUlXUJtRlOU0NWdFX78u6q1fX62t1lSxa54g6nplgQWE7tl32tXRJ1Id7Ssh ZWfaDNNWDBUTcJIoYMfd2e2m0XF25GU= X-Rspam-User: X-Stat-Signature: ofnifnrkt14r7q9z5yotp7q83gnfuw37 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: EC238C0004 Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=e6vnBK5e; spf=none (imf10.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none X-HE-Tag: 1668543526-376555 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 04, 2022 at 03:35:54PM -0700, Rick Edgecombe wrote: > +static unsigned long get_user_shstk_addr(void) > +{ > + unsigned long long ssp; > + > + fpregs_lock_and_load(); > + > + rdmsrl(MSR_IA32_PL3_SSP, ssp); > + > + fpregs_unlock(); > + > + return ssp; > +} This doesn't return the shstk addr, unlike what the name suggests, right?