From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B81B4C433FE for ; Tue, 15 Nov 2022 08:44:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6072A6B0071; Tue, 15 Nov 2022 03:44:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B7646B0072; Tue, 15 Nov 2022 03:44:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A6816B0073; Tue, 15 Nov 2022 03:44:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3C1406B0071 for ; Tue, 15 Nov 2022 03:44:49 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id AC43380F87 for ; Tue, 15 Nov 2022 08:44:48 +0000 (UTC) X-FDA: 80135041056.30.7C1BC58 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf08.hostedemail.com (Postfix) with ESMTP id 5B548160006 for ; Tue, 15 Nov 2022 08:44:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=JE+pDa9oSSrGTlesv5H0dmP0xLVCZF0jWZ2Qnff57X4=; b=u0X6G+mImjx/pFk7pniyypRq63 uemKvyAmtAw7GqwPvrVEdzHDLgGhMXw3Jkq/1NJUiiWqEg4RMW+pbpHcm84jHEaFcqqm54HsMiVF0 1L3TSD3Pxk6Eg0AEx8D/CTVmrU0qaJKb5H+62XEj5aLux7EgDs3ESD8/lQ7/lPKoFi9H32FXPEp3N RkZUPi6qbIGS2W9O6xdYaiBsjN7ypSeYstW/0Qkh02qi+USZLbsnNUZtsPfn/IuhREu3JC9VPpT5J PdwB2OsSeyW8XaPTM3Ddo6UnzfoltWHX0D5OE1xffNWAS69Woa6AsG9bk+i9Dshhdp5Xiq5zF0tDl u/wXtyMg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ourYk-0090jB-Lh; Tue, 15 Nov 2022 08:44:46 +0000 Date: Tue, 15 Nov 2022 00:44:46 -0800 From: Christoph Hellwig To: Dave Chinner Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 6/9] xfs: xfs_bmap_punch_delalloc_range() should take a byte range Message-ID: References: <20221115013043.360610-1-david@fromorbit.com> <20221115013043.360610-7-david@fromorbit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221115013043.360610-7-david@fromorbit.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668501888; a=rsa-sha256; cv=none; b=Ao+2pZDZ50T5w88VtySxi4fRvhjdcdsREEHE/mFOZasJvC76E9CwYOmdOCHK8sW7aimjxX PMK8KpPrHJAEHtssEetxsZtE7STTcNALDD8aNYWn7+qlohtHygsUWoAGjcmfpZOp592iEG 3q+1Nc6hmpoyxTnSDSlzxw5OKznZz+g= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=u0X6G+mI; dmarc=none; spf=none (imf08.hostedemail.com: domain of BATV+c84debcf882b373fc39b+7023+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+c84debcf882b373fc39b+7023+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668501888; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JE+pDa9oSSrGTlesv5H0dmP0xLVCZF0jWZ2Qnff57X4=; b=gdM3ZpcXbVVt6mAJRw68dSdSFCM0tXAB85wB9YKDQbuarcofkKermSeFM2fs9pH5fTrvUO nB3+5DoraP4xVozukKVU2D9mDG43LrS1k2rYOQMkQdX47mDtRc2L8hfkDAentmXY7xZzKt L1OTUEcGP9+eu8fBOP7CBV5LDkpHC5U= X-Rspam-User: Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=u0X6G+mI; dmarc=none; spf=none (imf08.hostedemail.com: domain of BATV+c84debcf882b373fc39b+7023+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+c84debcf882b373fc39b+7023+infradead.org+hch@bombadil.srs.infradead.org X-Rspamd-Server: rspam02 X-Stat-Signature: y3usuahtjuy11cga8331z7wfp5wc46kc X-Rspamd-Queue-Id: 5B548160006 X-HE-Tag: 1668501888-344296 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 15, 2022 at 12:30:40PM +1100, Dave Chinner wrote: > From: Dave Chinner > > All the callers of xfs_bmap_punch_delalloc_range() jump through > hoops to convert a byte range to filesystem blocks before calling > xfs_bmap_punch_delalloc_range(). Instead, pass the byte range to > xfs_bmap_punch_delalloc_range() and have it do the conversion to > filesystem blocks internally. Ok, so we do this here. Why can't we just do this earlier and avoid the strange inbetween stage with a wrapper?