From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66FD1C4332F for ; Tue, 15 Nov 2022 08:43:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DF8076B0071; Tue, 15 Nov 2022 03:43:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DA77A6B0072; Tue, 15 Nov 2022 03:43:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C96F06B0073; Tue, 15 Nov 2022 03:43:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BA38E6B0071 for ; Tue, 15 Nov 2022 03:43:45 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 97B8FA0118 for ; Tue, 15 Nov 2022 08:43:45 +0000 (UTC) X-FDA: 80135038410.05.B82DBB8 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf17.hostedemail.com (Postfix) with ESMTP id 5180C40002 for ; Tue, 15 Nov 2022 08:43:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ElXZRhGP3GQflFU1XjOBU4jVMW39dMHXe/t4ltdVZVg=; b=Fgwh612BHfQstmzzl2mPqObJS7 RxBuLPKPlMKD38PkN2yUtLNhre3avUb3c0fA+8eoXIMT3p3mWtkPGeYiO+LKPTnRHVoSC46sKn4Xc JO/UtCcNyg1Tuzyq6mvQ0cfXmvp4jQjhN2A6/5QvAJ230lLlPQEh80/PQeu5Fa/V7d+2864uOtbg+ QDxQugNjx/4kVEDqmogpcDXhkmCrmG1O4/aIRcrHhcKBZ0gpTdlLKO8u1Vt2xZ+km3ssKQQxlTlce OIpPgbFUk5iu6joO95tb47+aegwrGTbBevxz5sijZIPXgF1KuMn7FSSXBP6M1gcvw6Wk0xiTkOok3 qyqwiWjw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ourXj-0090ME-C5; Tue, 15 Nov 2022 08:43:43 +0000 Date: Tue, 15 Nov 2022 00:43:43 -0800 From: Christoph Hellwig To: Dave Chinner Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 5/9] xfs: buffered write failure should not truncate the page cache Message-ID: References: <20221115013043.360610-1-david@fromorbit.com> <20221115013043.360610-6-david@fromorbit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221115013043.360610-6-david@fromorbit.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668501825; a=rsa-sha256; cv=none; b=OQvV6iQpbVPw3p5+NAhsvfH8LscJqAlHrK+Uz4tcK4PIhnq/U7AM9rc7HhiL0WUEYRIuyH OTUk25U7eBcuKlR7SXdAldDXlZeOR2HG+idSvhsy85+9FxATa2QmInvGl+Ezmxm5k9zzHM boqZbG6E1hDjj6tpdP3fanyhg1jDtRY= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Fgwh612B; dmarc=none; spf=none (imf17.hostedemail.com: domain of BATV+c84debcf882b373fc39b+7023+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+c84debcf882b373fc39b+7023+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668501825; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ElXZRhGP3GQflFU1XjOBU4jVMW39dMHXe/t4ltdVZVg=; b=XqC7FUiO2iTUqJaB99dor3HQKmt0aaPjGMS2xxVB8Lt514GRLvxu/TrO+KA6Un+MGwJf+U BvCg9aFL7TSzmzK3WFNEV4MZAhAEj1UbuIdnh5jhjv7ODIp0HbkdCkmCYSzwGpCyRAb0rf p0c2Mz3GUdxAxg56LXd2txuQRQJ+5Is= X-Rspamd-Queue-Id: 5180C40002 Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Fgwh612B; dmarc=none; spf=none (imf17.hostedemail.com: domain of BATV+c84debcf882b373fc39b+7023+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+c84debcf882b373fc39b+7023+infradead.org+hch@bombadil.srs.infradead.org X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: rsujcmfemp7c6jg5wcgfatykr4togd1h X-HE-Tag: 1668501825-88872 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > +static int > +xfs_buffered_write_delalloc_scan( As pointed out last time, this is generic iomap (or in fact filemap.c, but maybe start small) logic, so move it there and just pass xfs_buffered_write_delalloc_punch as a callback.