From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC0BAC433FE for ; Tue, 15 Nov 2022 08:42:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8C8F06B0072; Tue, 15 Nov 2022 03:42:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8785B6B0073; Tue, 15 Nov 2022 03:42:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 769006B0074; Tue, 15 Nov 2022 03:42:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 669ED6B0072 for ; Tue, 15 Nov 2022 03:42:23 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 407D31401AC for ; Tue, 15 Nov 2022 08:42:23 +0000 (UTC) X-FDA: 80135034966.29.258D028 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf12.hostedemail.com (Postfix) with ESMTP id E6EC640008 for ; Tue, 15 Nov 2022 08:42:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=P1xELF4xsapCUJIfwA5KRWCPKuR/FLELoB8phxNz8eM=; b=eeVwgwI7+cXAd0wwyFZWo/ZbUO 7Z8s8cHLVS4SbkBOeUB0P3F4aRGV+jpOM9o2k9D7rrGHgR156yhqRazsomugA7YacZL0HfKl1vKfM f9HVEEqdeDwU1JvmVuFP0iR0zwDmTACHjSjY6fxZn2z6omzk0AhrfxwW45Lr3qv+bt7AvZLP6R0CB a+DuxZ9Y5duALMMcRC5jcbSHN/F0nthMeEecNbv2ErulfUhwc9XCLDLcDSnNBVRzEUWWHjVG8pH+j qrxK6Hg7zeqv23eQRLyyzgGHZxRFVce8Uo8Z2uYMGKrWGbdp1kQGV4UGEpB7162qPSqadlhZryh8s By/+bDWw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ourWP-008zrk-5c; Tue, 15 Nov 2022 08:42:21 +0000 Date: Tue, 15 Nov 2022 00:42:21 -0800 From: Christoph Hellwig To: Dave Chinner Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 4/9] xfs: use byte ranges for write cleanup ranges Message-ID: References: <20221115013043.360610-1-david@fromorbit.com> <20221115013043.360610-5-david@fromorbit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221115013043.360610-5-david@fromorbit.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668501743; a=rsa-sha256; cv=none; b=h4I6k2Qu9nW7HqsWQCGRUgPfNzSJ2tXHfd1bd6rx4DWPQ6n3c6oUU4B/MwRlJeJRXp+VdD TUEGc9p8JBuMaxHTFAmerHYcW1wYMNvXKyG+ZX7V4hQCCBpN/7USkRjVi67iTjaxMWxasn oChu2wRJTXrD09TSVCCyeEtrEpSqVis= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=eeVwgwI7; dmarc=none; spf=none (imf12.hostedemail.com: domain of BATV+c84debcf882b373fc39b+7023+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+c84debcf882b373fc39b+7023+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668501743; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P1xELF4xsapCUJIfwA5KRWCPKuR/FLELoB8phxNz8eM=; b=Sscj0FdYMIDTkp6A+usjdCWZiYEE4xr0eNVcH8Z+vzrFfqB0uKm+zvxcgrXlJ/JvXbgh6m eoxiEnd+wzlTjQFjVjS1bpbzQzEwOf3zJC+cR1UKcgsMwg7R/fZOZBd3d8DrN8LD6Q+L0h bQLWzuop5Kiy9wfpXfjCskWgnkcMplQ= X-Rspamd-Queue-Id: E6EC640008 Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=eeVwgwI7; dmarc=none; spf=none (imf12.hostedemail.com: domain of BATV+c84debcf882b373fc39b+7023+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+c84debcf882b373fc39b+7023+infradead.org+hch@bombadil.srs.infradead.org X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: sm6xzbchwa1iifuwmptsc9p5oy347dmi X-HE-Tag: 1668501742-359037 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 15, 2022 at 12:30:38PM +1100, Dave Chinner wrote: > +static int > +xfs_buffered_write_delalloc_punch( > + struct inode *inode, > + loff_t start_byte, > + loff_t end_byte) > +{ > + struct xfs_mount *mp = XFS_M(inode->i_sb); > + xfs_fileoff_t start_fsb = XFS_B_TO_FSBT(mp, start_byte); > + xfs_fileoff_t end_fsb = XFS_B_TO_FSB(mp, end_byte); > + > + return xfs_bmap_punch_delalloc_range(XFS_I(inode), start_fsb, > + end_fsb - start_fsb); > +} What is the reason to not switch xfs_bmap_punch_delalloc_range to just take the byte range as discussed last round?