From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8ABDDC4332F for ; Tue, 15 Nov 2022 00:47:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 236866B0071; Mon, 14 Nov 2022 19:47:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E5E86B0072; Mon, 14 Nov 2022 19:47:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D5816B0073; Mon, 14 Nov 2022 19:47:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 00FD06B0071 for ; Mon, 14 Nov 2022 19:47:13 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C37861609F1 for ; Tue, 15 Nov 2022 00:47:13 +0000 (UTC) X-FDA: 80133837546.02.606897B Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by imf24.hostedemail.com (Postfix) with ESMTP id 6D5DD18000C for ; Tue, 15 Nov 2022 00:47:13 +0000 (UTC) Received: by mail-pj1-f43.google.com with SMTP id gw22so11881090pjb.3 for ; Mon, 14 Nov 2022 16:47:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=R4E776DpX0wTKCI3TLDV4yOHj0J735rhp+IkszbZ/MY=; b=mrdRFzEsY9YBXYTxUDDgLoZgCJJvgN4FGzcb9hSocsa6IAryE5Y2FPNsit0tVRbvF5 FSzZp5BRgBeh8yXm/FBdFsv1HAzukEZFPhR49dV0zw8w+BK0YYfpC4jE4nd7z+SEfvhy YSZ8aKDJoaltzO3r1+Z+go6uM5CdADWKjdYMU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=R4E776DpX0wTKCI3TLDV4yOHj0J735rhp+IkszbZ/MY=; b=5ui8Yhiss/WgODJ3I0XzClghKgQIt6DidWEEVUFCI1CJ+C8ufxUAmr2/QSQ5p8CaLf qyDK61vAh1dCQYsRBT50JSVQf3VEWuYOdhCruMOwg5ty7VG46uMarUbnXt1I0EJVgtNV TsAp1vnIyYwgVwiSY9lzYuNHuKA4aHmRLWbyb8rkR+S8cRT8iE08e7Fzu7VeBixA0EpL 5ZS9y/lYQ9HOOSUuL1T9taSS+5T1sriv+dzlQHWmhIQt6mVLcdfgfr1QdytChUlt2Buo YHzRGMKGHWU/lFVFGzNDqANvx3rYTocg2nyFvCobUjp98CHMVGQAEmJX615s23YFge0a nUuw== X-Gm-Message-State: ANoB5pl33LJI8aiSniNia2cJaBnHTG/isWtpFKFPXkmGd4lvnjj9ERhE DNbe1OKm84FVTaYu1GU1w12CPHMcStOQfg== X-Google-Smtp-Source: AA0mqf6vHTVyItSWJ1wYm5TuZk7m1iytf1d5Mce00t/Mfag+LscwaIlRwnFRTD5F8ozzDjRbr08mXg== X-Received: by 2002:a17:902:aa47:b0:186:61c8:c512 with SMTP id c7-20020a170902aa4700b0018661c8c512mr1598724plr.155.1668473232412; Mon, 14 Nov 2022 16:47:12 -0800 (PST) Received: from google.com ([240f:75:7537:3187:3d10:c2ca:ba5b:55e6]) by smtp.gmail.com with ESMTPSA id e12-20020a63544c000000b0047048c201e3sm1009186pgm.33.2022.11.14.16.47.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Nov 2022 16:47:11 -0800 (PST) Date: Tue, 15 Nov 2022 09:47:07 +0900 From: Sergey Senozhatsky To: Andrew Morton Cc: Sergey Senozhatsky , Minchan Kim , Nitin Gupta , Suleiman Souhlal , linux-kernel@vger.kernel.org, linux-mm@kvack.org, coverity-bot Subject: Re: [PATCH] zram: explicitly limit prio_max for static analyzers Message-ID: References: <20221109115047.2921851-5-senozhatsky@chromium.org> <20221114021420.4060601-1-senozhatsky@chromium.org> <20221114164130.e45a95db4e8be2c3909bdba1@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221114164130.e45a95db4e8be2c3909bdba1@linux-foundation.org> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668473233; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=R4E776DpX0wTKCI3TLDV4yOHj0J735rhp+IkszbZ/MY=; b=tS5Yfdx2LzG3XxA8Voo173whY1wENQ5K8FNYia1POZE3Lc0lWWs0UwdnCDM0hEhBnC+Moq Ql4eEyhYw7wDDzSOv4qPYTWwQGvHagqVk+bVH1orgtLghtGCfaXlHcX9gYImR3aoXvNlve mR4w6kBzwSu6CrVRoNyMI5atepnE8FI= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=mrdRFzEs; spf=pass (imf24.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.43 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668473233; a=rsa-sha256; cv=none; b=Qmcx20S6z/WgWGaCbJxD2EO6FcnNNvxscZXBPx0NzWW4ckc8/y7SNu0Wpq15VZvwj+YkL0 3NdOT6lSjREXqGe24MYj8kUMOGATanKRkf1SfVrpr7QvYKaYUidPvTHGgYd9VTaO4Kife+ be9guNxxFVrP7y4eFuOX88Fs/6vPTHo= X-Stat-Signature: 5s55tyqtfwj4rqdjrkuqfps7zn8ja8qk X-Rspamd-Queue-Id: 6D5DD18000C Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=mrdRFzEs; spf=pass (imf24.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.43 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspamd-Server: rspam07 X-Rspam-User: X-HE-Tag: 1668473233-839591 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (22/11/14 16:41), Andrew Morton wrote: > > drivers/block/zram/zram_drv.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c > > index 9d33801e8ba8..e67a124f2e88 100644 > > --- a/drivers/block/zram/zram_drv.c > > +++ b/drivers/block/zram/zram_drv.c > > @@ -1706,6 +1706,7 @@ static int zram_recompress(struct zram *zram, u32 index, struct page *page, > > * Iterate the secondary comp algorithms list (in order of priority) > > * and try to recompress the page. > > */ > > + prio_max = min(prio_max, ZRAM_MAX_COMPS); > > for (; prio < prio_max; prio++) { > > if (!zram->comps[prio]) > > continue; > > I'll queue this as a fix to "zram: introduce recompress sysfs knob". > > What's it do? A little changelog would be nice, or at least a link to > the coverity report? It doesn't do much, coverity (static analyzer?) got confused by the code, so this simply is supposed to help coverity figure out that we never do an out of bounds access in comps[] array: https://lore.kernel.org/lkml/202211100847.388C61B3@keescook/