From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E860C433FE for ; Mon, 14 Nov 2022 23:24:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C40426B0071; Mon, 14 Nov 2022 18:24:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C16FE8E0001; Mon, 14 Nov 2022 18:24:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC1B86B0071; Mon, 14 Nov 2022 18:24:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 984736B0071 for ; Mon, 14 Nov 2022 18:24:01 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 64D79160E29 for ; Mon, 14 Nov 2022 23:24:01 +0000 (UTC) X-FDA: 80133627882.25.642513F Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by imf19.hostedemail.com (Postfix) with ESMTP id 17B1D1A0005 for ; Mon, 14 Nov 2022 23:24:00 +0000 (UTC) Received: by mail-pg1-f181.google.com with SMTP id n17so3991225pgh.9 for ; Mon, 14 Nov 2022 15:24:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=RwlygzCsN4JvBoBc5PT51nu/YPQWPnTm3fC10wkiQwI=; b=H/ssuI5Y03wS7QHyYAaQtvdvQLPAK4QsHc+sowRfzw7LbSXrrIuDGSMKFuT6SOy1Ha v1XDE9LyvBn0mtjjmniPJOxDCSuhjThvx09UEDEEikoyk9Nj5a41dfuBLMwpjLfLk2mL N5qmyTI1mFVFPVv4D9D1zVHc0Y80p4OetFtZvPOJ6Zd4VDhyH0W1g/yrmUWVFhSaucFA bXg7zhw0nc5VNiPSY8plbleLneOYe4zUKyahtbGp/Jrk0iZ3qaSo7+W+lrMERR1B3ozw NyMfDdBHMAk6MMrCB2Rykpe3dlbjg/oL2Kso8AwUZuu+veXgSt4axC5Kfd7QToGOLWUB EXUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RwlygzCsN4JvBoBc5PT51nu/YPQWPnTm3fC10wkiQwI=; b=e8cJ1whcREWGqCjgrKxOq+i2lQ4pWkYAR5Z3SeNPYMitLrXHY81ohT1zoYsAiQCEOk HAYkqBrguxTADIZ0tKkgX1dvFRrwGS34ExMTKBR6D2SwINrwXQHB1Vd3DPX8D2BEuy8g 4aZzgI39iR80ukL1zESuoF4UMYRaJgQALXCYdBikII+zCfKghyDORwpetHLOKCjQjFtu 0bUX+CAfI3eWePS9F1bI1hhBKvLsYaw2dIyLKl28e1HzFHG3wXstnRt1e0Er0x7Q9OKp 0vPyQk2BhQ0E+waHvMb64TlvFRpUZuVU2ZWwlNRiK2tYliX9v43wcTtBfdxAWxT3HdCI uwug== X-Gm-Message-State: ANoB5plDUPY+WQDZZDgZGGkx49ftq6eAVvxurJIahrQryzcSdHG02j8v 8WmHq34KVvFN8FVyj0zNaG008g== X-Google-Smtp-Source: AA0mqf6OeX4uF0N4ZAtEAWAWpkt1j2fd0oy7Bdye+9vXo14vwKDQcG8kuYKNlmHV8hItYawmG29FXA== X-Received: by 2002:aa7:8f37:0:b0:56c:cde:1a49 with SMTP id y23-20020aa78f37000000b0056c0cde1a49mr16109986pfr.9.1668468239853; Mon, 14 Nov 2022 15:23:59 -0800 (PST) Received: from google.com ([2620:15c:2d:3:1010:f556:6834:d91b]) by smtp.gmail.com with ESMTPSA id f1-20020a170902ab8100b00174c1855cd9sm8019458plr.267.2022.11.14.15.23.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Nov 2022 15:23:59 -0800 (PST) Date: Mon, 14 Nov 2022 15:23:54 -0800 From: Isaac Manjarres To: Catalin Marinas Cc: Linus Torvalds , Arnd Bergmann , Christoph Hellwig , Greg Kroah-Hartman , Will Deacon , Marc Zyngier , Andrew Morton , Herbert Xu , Ard Biesheuvel , Saravana Kannan , Alasdair Kergon , Daniel Vetter , Joerg Roedel , Mark Brown , Mike Snitzer , "Rafael J. Wysocki" , Robin Murphy , linux-mm@kvack.org, iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 03/13] iommu/dma: Force bouncing of the size is not cacheline-aligned Message-ID: References: <20221106220143.2129263-1-catalin.marinas@arm.com> <20221106220143.2129263-4-catalin.marinas@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221106220143.2129263-4-catalin.marinas@arm.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668468241; a=rsa-sha256; cv=none; b=hjBblmC7QgqlBOaSzgYo1YLquCpwIDyuXSrRVOL1uNlsqwu7WbN6xsTUhz1v/xQzf3K6vy HTdMPTitQdIBn72NrDpI7t37P6thOFBa3PRp9alU6DCmi5dUrw7xYp86e290XS9uwUcZfw 9KlDWhxUohHfr2odvO2GEA+v7qG4zdk= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="H/ssuI5Y"; spf=pass (imf19.hostedemail.com: domain of isaacmanjarres@google.com designates 209.85.215.181 as permitted sender) smtp.mailfrom=isaacmanjarres@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668468241; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RwlygzCsN4JvBoBc5PT51nu/YPQWPnTm3fC10wkiQwI=; b=gvc0l2eU2Eg0g/DE/jMfSoel3QGhitwXcGv0/6tQz8ctrw1ho1uuuh3ue8/lb7iQlHEMNC VXkwzIeRvBy/eDoT8Kzb702ZOq2bUdnfy/kRxinZT09ePT8LqpHhsY5j5kzus2VpxaFrBt CiSrFmS52xJyRNJVzrC22MGxSNSyyjA= X-Rspam-User: X-Stat-Signature: rkz1b4pxbdiiyoj4889tjbit9e8knsa3 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 17B1D1A0005 Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="H/ssuI5Y"; spf=pass (imf19.hostedemail.com: domain of isaacmanjarres@google.com designates 209.85.215.181 as permitted sender) smtp.mailfrom=isaacmanjarres@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1668468240-506951 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Nov 06, 2022 at 10:01:33PM +0000, Catalin Marinas wrote: > @@ -1202,7 +1203,10 @@ static int iommu_dma_map_sg(struct device *dev, struct scatterlist *sg, > goto out; > } > > - if (dev_use_swiotlb(dev)) > + if (dma_sg_kmalloc_needs_bounce(dev, sg, nents, dir)) > + sg_dma_mark_bounced(sg); > + > + if (dev_use_swiotlb(dev) || sg_is_dma_bounced(sg)) > return iommu_dma_map_sg_swiotlb(dev, sg, nents, dir, attrs); Shouldn't you add a similar check in the iommu_dma_unmap_sg() path to free any SWIOTLB memory that may have been allocated to bounce a scatter gather list?