From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9928C433FE for ; Tue, 15 Nov 2022 02:34:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 318476B0072; Mon, 14 Nov 2022 21:34:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C7F06B0073; Mon, 14 Nov 2022 21:34:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1687C6B0074; Mon, 14 Nov 2022 21:34:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 052386B0072 for ; Mon, 14 Nov 2022 21:34:44 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C27DF1C6347 for ; Tue, 15 Nov 2022 02:34:43 +0000 (UTC) X-FDA: 80134108446.05.C224E68 Received: from mail-il1-f182.google.com (mail-il1-f182.google.com [209.85.166.182]) by imf13.hostedemail.com (Postfix) with ESMTP id 5898420004 for ; Tue, 15 Nov 2022 02:34:43 +0000 (UTC) Received: by mail-il1-f182.google.com with SMTP id l6so6751627ilq.3 for ; Mon, 14 Nov 2022 18:34:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bobcopeland-com.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=I5DBoIqNagH3XrdRY1r6Eco1A6aUzboNusmzdLRomUQ=; b=BhLHIICyakMONq9rF7PTSR31xmu60lcMvmCY2Ved5pkA3CMCOwasit37iZcXH0t3gO vrFIOD/CM1U2YYMLP1XsvBhAbnHH4PJKe3YQ0MjuyKctAqaf9Ff7fMqBk+SsV2m8+3db 71ZCvALpPlT/q2S+hSblu9+dC/IKszNgG+3jzwGoUOG9Zy2wWDRYNPJpeWnK8/HcE24t 3JiAgikkYgpvRkYFtTiB+4T5XYg65wOvoTqt7zqXOOM5yuEy0AX0TtI/ZtUUXicF99Ss HsFcjTd41n/aJfhMi1UN+8CIJuQtL0jJjhlOHwj22oV7V2hF2B46FKI4hNuo8rvD+or6 FEVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=I5DBoIqNagH3XrdRY1r6Eco1A6aUzboNusmzdLRomUQ=; b=owYoxD25DIOv50I1z2dhW+2Ayk807Z8hpR4WLvAGuSi158Ubi07GzwipusCux+rwgr 65cq1C3Ysq/UWbARNRQFPZ3dR8mMNa8Sxgp7ymPDJ93UTiX7JIJ0yP5MLH/xMw7Jc7eJ qG+0PSolEYGGV7nM6mrjRwlnE/N2z9sTVLc4SS+f74KpN0KE0FR76FrlXMJQ1FEMWTMh gdYio4BUEMVo1NBm3UT73uTn6KsgLncrh5hPw6t9J05fq05magYNaJ3B9vSQAmx+BFEA FAfQhEYtNjZ7kceyUyOjHP8rkaHWTOhLGOFMzJK3koUGgGax3XrExaRyOpgvwM7BHhb7 CXXg== X-Gm-Message-State: ANoB5pkTYuz22TBYIvoo/rutN+sWqOB9lKg+JeAbT37CkRdj4vrYfCVJ YcDcNEE75bXZADlRwJ8au0dSsA== X-Google-Smtp-Source: AA0mqf7kAKIWh2OS1WpDznT7RyX7mgjfWyyk2UEacMxAMSsL23+bcKLTzBzFPbqhHAEvBf20J60FbQ== X-Received: by 2002:a92:d305:0:b0:2f9:b594:970 with SMTP id x5-20020a92d305000000b002f9b5940970mr7467585ila.56.1668479682530; Mon, 14 Nov 2022 18:34:42 -0800 (PST) Received: from elrond.bobcopeland.com ([142.113.148.203]) by smtp.gmail.com with ESMTPSA id e99-20020a02866c000000b0035b3e0a3243sm4064564jai.57.2022.11.14.18.34.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Nov 2022 18:34:42 -0800 (PST) Received: by elrond.bobcopeland.com (Postfix, from userid 1000) id 0953CFC00A9; Mon, 14 Nov 2022 21:34:37 -0500 (EST) Date: Mon, 14 Nov 2022 21:34:37 -0500 From: Bob Copeland To: Christoph Hellwig Cc: Namjae Jeon , Sungjong Seo , Jan Kara , OGAWA Hirofumi , Mikulas Patocka , Dave Kleikamp , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-karma-devel@lists.sourceforge.net, linux-mm@kvack.org Subject: Re: [PATCH 8/9] omfs: remove ->writepage Message-ID: References: <20221113162902.883850-1-hch@lst.de> <20221113162902.883850-9-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221113162902.883850-9-hch@lst.de> ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=bobcopeland-com.20210112.gappssmtp.com header.s=20210112 header.b=BhLHIICy; spf=none (imf13.hostedemail.com: domain of me@bobcopeland.com has no SPF policy when checking 209.85.166.182) smtp.mailfrom=me@bobcopeland.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668479683; a=rsa-sha256; cv=none; b=BWKqmi1wNq3GYxXBUCPEfkuGKmnDuf52nwDQ8KvzJk0KlVoNgFnDbZHya4uqBcu9CVA3xN 7jcyMbFHdsaJ1VCXOT2cjHjD8kWVybUa62xZW4DGn9SR4FmoTeZqIrvkKFsc5WiRRCxuzh ntgK83aL5EYqapItWIjKnCveFbdHXWI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668479683; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=I5DBoIqNagH3XrdRY1r6Eco1A6aUzboNusmzdLRomUQ=; b=MwlURcf3h/7HHrsxH1cQrYVsaCIZUv/jrWC71nj07njiMtzFrCb9BV3pFoDgV9NT7vutWr C/w0le+dVuI6qCXeBHF8202/IxKmMWMFaOqyA0Z1peijvsLIVwHTbtW32O9nzzTNPSzccA aSxNqw79ZszFb7TKB1hFE6hJ8zwO8g4= X-Stat-Signature: mgw6n3xw3ngdg8wofutp7j47mccd6ett X-Rspamd-Queue-Id: 5898420004 X-Rspam-User: Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=bobcopeland-com.20210112.gappssmtp.com header.s=20210112 header.b=BhLHIICy; spf=none (imf13.hostedemail.com: domain of me@bobcopeland.com has no SPF policy when checking 209.85.166.182) smtp.mailfrom=me@bobcopeland.com; dmarc=none X-Rspamd-Server: rspam11 X-HE-Tag: 1668479683-869690 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Nov 13, 2022 at 05:29:01PM +0100, Christoph Hellwig wrote: > ->writepage is a very inefficient method to write back data, and only > used through write_cache_pages or a a fallback when no ->migrate_folio > method is present. > > Set ->migrate_folio to the generic buffer_head based helper, and remove > the ->writepage implementation. > > Signed-off-by: Christoph Hellwig Looks good, Acked-by: Bob Copeland -- Bob Copeland %% https://bobcopeland.com/