From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 561D7C4332F for ; Mon, 14 Nov 2022 21:28:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D0A16B0071; Mon, 14 Nov 2022 16:28:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 859356B0072; Mon, 14 Nov 2022 16:28:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D2D86B0073; Mon, 14 Nov 2022 16:28:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 593266B0071 for ; Mon, 14 Nov 2022 16:28:17 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 292051A0143 for ; Mon, 14 Nov 2022 21:28:17 +0000 (UTC) X-FDA: 80133336234.28.4C83A51 Received: from eastern.ash.relay.mailchannels.net (eastern.ash.relay.mailchannels.net [23.83.222.55]) by imf25.hostedemail.com (Postfix) with ESMTP id 900C8A0010 for ; Mon, 14 Nov 2022 21:28:14 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|ian@linux.cowan.aero Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 4C4F23C111D; Mon, 14 Nov 2022 21:28:11 +0000 (UTC) Received: from pdx1-sub0-mail-a275.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 37B343C1211; Mon, 14 Nov 2022 21:28:10 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1668461290; a=rsa-sha256; cv=none; b=W5ROWTsMZrHOHnhlDC/c6QB+czt5XPTkoV5zDfGDPt/FHWv1UilUde+1hJ47wGnptQ0Wqo SNJZUt2J5Cn3xdD5vKwLFMfnfq5ShL+bUgaAnJZHr4k/ooiVpT3vWpwPGs8PzP1MsLNhg3 0zYkSKJaQSqH1vW0y16GqvBeuAOCwopusarCnAM/JrhGrYcEhVBtKYJYbXjjSv/GUWGVDX 2tnDzQ/Lf/7Ts0XFgFDmHLflJN6CcyAgxAouewjf35KDEsyV08QjoxT/VkfPf4Lg6x9b+Z 78n8yJ6ZMEDh4B3n67V9RoGWDhqUw3BXwQwKGFTHWfkBdM0N1P+ou+DPB60KkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1668461290; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dhghcBTxDDlVUI0nQwj3B1Orugxyqsm8zkmydYGlNeg=; b=H6u+23w3RXz/Zo3AdwtkpT5IMv4Gpi3AlEBbu0g4A5RixMKO+Zte12nButeG8yjftzpYyL RlbARv+wR+tov8WkvJH/MI9vROUQoTv7xOPo5OK7IxhAjHqc9Mnud7lsQzA98ZKEYF7plb JpGrapa01Cjf5PsFhGMh4Cr5gAZ+/GhZaVy97RsE5AjkSL4X56OqE1emXZnkFxpBKwVs4s NwlFmKY/CrXpINtGDjwJuf81t1Gs/XEw7zL0zF2SnyBKWix68KTS9tiEHKNU06wydt99EX F6k1BAPi5XBUW7m7xOP2SOxkAcyJWu6116xhYtIFIcpiRbM1TY61mu1KgRa3Lw== ARC-Authentication-Results: i=1; rspamd-7f9bbcf788-gzxf5; auth=pass smtp.auth=dreamhost smtp.mailfrom=ian@linux.cowan.aero X-Sender-Id: dreamhost|x-authsender|ian@linux.cowan.aero X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|ian@linux.cowan.aero X-MailChannels-Auth-Id: dreamhost X-Absorbed-Industry: 6e3b9a3016e26135_1668461290545_1507680007 X-MC-Loop-Signature: 1668461290545:2518700890 X-MC-Ingress-Time: 1668461290545 Received: from pdx1-sub0-mail-a275.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.123.200.111 (trex/6.7.1); Mon, 14 Nov 2022 21:28:10 +0000 Received: from rhino (dsl-50-5-144-34.fuse.net [50.5.144.34]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: ian@linux.cowan.aero) by pdx1-sub0-mail-a275.dreamhost.com (Postfix) with ESMTPSA id 4NB2V10bz7z2S; Mon, 14 Nov 2022 13:28:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.cowan.aero; s=dreamhost; t=1668461289; bh=dhghcBTxDDlVUI0nQwj3B1Orugxyqsm8zkmydYGlNeg=; h=Date:From:To:Cc:Subject:Content-Type; b=mK4q9NkruEYIjXoq8Y/9TcThuEieVs86t3ohaDs90lUbXqGBtd8fm4Q8B9qe7JIEM PyIb6iZ+Do03zrAQpLtigLPppnkPDLhtbHCXpeGwqlDjUxXeU21ADsdg0A9xLLH9rr Z//uyOaZLaoiXZGV4WWDZeQI4BkAlQd1UI6fGLpjjeKCdAPq/o2v/NKdiAISphm9uz i2KmL3iJh//2duJ9Va0SajToLnoYX40X84Eyer8uCfxAOJ7ha9x4VVzMxw+px2G9YY DfzMi2A0vf2q6u0W8pDFMSGrXnEvJIqXdca99oY7+Ao23y99ThFrmf8fXovHsdiA80 Xl6Kf1Q+s+jmA== Date: Mon, 14 Nov 2022 16:28:07 -0500 From: Ian Cowan To: Vlastimil Babka Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>, Randy Dunlap , cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, roman.gushchin@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: include: linux: slab: kmalloc_trace undefined when compiling drivers Message-ID: References: <1df133ef-d5e9-f323-7c67-fc9ffed04274@infradead.org> <5dc7529d-9edf-4ea7-35d3-a5f3dc55dd5c@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5dc7529d-9edf-4ea7-35d3-a5f3dc55dd5c@suse.cz> ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668461296; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dhghcBTxDDlVUI0nQwj3B1Orugxyqsm8zkmydYGlNeg=; b=DGpFGRF5LqvSssHpcm0N3i4nlcaEzWyaiDsP6E8wltda/Hj2F8VeItfjwrEo16K79Vee9X e5If44oAKSzrr3QofIBcozBNVnY9IkAfpkWqKTUcs4oId9szRJSt0MAIe272aZ1cpJB3Qu OYyfw/vdONWZM3tya+hNJVXh+12EXdQ= ARC-Authentication-Results: i=2; imf25.hostedemail.com; dkim=pass header.d=linux.cowan.aero header.s=dreamhost header.b=mK4q9Nkr; dmarc=pass (policy=none) header.from=cowan.aero; spf=pass (imf25.hostedemail.com: domain of ian@linux.cowan.aero designates 23.83.222.55 as permitted sender) smtp.mailfrom=ian@linux.cowan.aero; arc=pass ("mailchannels.net:s=arc-2022:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1668461296; a=rsa-sha256; cv=pass; b=lgUPhJBsulnC0Mb8lE65uqaewB1fsVta48ID5HR5D+BLlYlLMRXns0h0g5RqNn2F4AK3P+ x4bffghZA5en83yz+8UIES+YbiGgAa+FW8EX046IrACeGJkK1T1A+jFpPoMu6U1ni89D2L 7ZbYOsmxx+jWE6MWRB23xl0TcpHx3NU= X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 900C8A0010 X-Rspam-User: Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux.cowan.aero header.s=dreamhost header.b=mK4q9Nkr; dmarc=pass (policy=none) header.from=cowan.aero; spf=pass (imf25.hostedemail.com: domain of ian@linux.cowan.aero designates 23.83.222.55 as permitted sender) smtp.mailfrom=ian@linux.cowan.aero; arc=pass ("mailchannels.net:s=arc-2022:i=1") X-Stat-Signature: 6wnde9shcmf5ps4rjuduasga4p67tg4c X-HE-Tag: 1668461294-964030 X-Bogosity: Ham, tests=bogofilter, spamicity=0.001962, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 14, 2022 at 05:56:25PM +0100, Vlastimil Babka wrote: > On 11/14/22 13:39, Ian Cowan wrote: > > On Mon, Nov 14, 2022 at 05:59:06PM +0900, Hyeonggon Yoo wrote: > >> On Sat, Nov 12, 2022 at 08:21:14PM -0500, Ian Cowan wrote: > >> > On Sat, Nov 12, 2022 at 05:11:27PM -0800, Randy Dunlap wrote: > >> > > > >> > > > >> > > On 11/12/22 16:43, Ian Cowan wrote: > >> > > > On Sat, Nov 12, 2022 at 04:34:18PM -0800, Randy Dunlap wrote: > >> > > >> > >> > > >> > >> > > >> On 11/12/22 13:59, Ian Cowan wrote: > >> > > >>> On Sat, Nov 12, 2022 at 09:21:34AM -0800, Randy Dunlap wrote: > >> > > >>>> Hi-- > >> > > >>>> > >> > > >>>> On 11/12/22 08:37, Ian Cowan wrote: > >> > > >>>>> When compiling drivers (speficially drivers/pci/hotplug), I am receiving > >> > > >>>>> the following modpost error for both `kmalloc_trace` and > >> > > >>>>> `kmalloc_node_trace` on the staging/staging-next branch: > >> > > >>>>> > >> > > >> > >> > > >> Ian, what do you mean by "on the staging/staging-next branch"? > >> > > >> > >> > > >> What kernel version are you trying to build? > >> > > >> > >> > > >> The .config that you sent is for v6.1.0-rc1. > >> > > > > >> > > > I am building from the staging repository (gregkh/staging) and my > >> > > > working branch when building is staging-next. So I am trying to build > >> > > > from staging and not a particular version. I have also run `make modules_prepare` > >> > > > and updated the .config per that script. However, when I do build > >> > > > v6.1.0-rc1 from the main repository (torvalds/linux), I run into the same problem. > >> > > > >> > > Have you built the entire kernel already and then you are trying to build > >> > > only drivers/pci/hotplug? > >> > Yes, I did build the entire kernel already and then I'm just trying to > >> > rebuild that module. > >> > > >> > In `include/linux/slab.h` if I remove the lines between `#ifdef > >> > CONFIG_TRACING` and `#else` (lines 473-480) and then the corresponding > >> > `#endif` and leave lines 481-499, I'm able to compile that module > >> > without issue. > >> > >> I don't get what the problem is. > >> In case kmalloc[_node]_trace() is undefined, it's replaced with kmem_cache_alloc[_node]. > >> > >> Is the kernel built with same config on tree? > > > > Yes, the same config on tree with no errors or warnings. I was able to > > trace it back to this commit - building on the commit immediately prior > > builds without error or warning. It looks like this commit does some > > refactoring of the kmem_cache_alloc[_node] and kmalloc[_node]_trace. > > > > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/commit/?h=staging-next&id=26a40990ba052 > > Wonder if you have a stale mm/slab_common.o because for some reason it's not > being recompiled (a file timestamp in the future?) > Can you rm it and rebuild? And maybe also mm/built-in.a > Or maybe a full make clean and/or a fresh checkout. > I pulled a fresh checkout and rebuilt everything and it was fixed after that. Thanks for your help!