From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 990AEC433FE for ; Mon, 14 Nov 2022 17:47:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B6A946B0082; Mon, 14 Nov 2022 12:47:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B1AD96B0083; Mon, 14 Nov 2022 12:47:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A0A2D8E0001; Mon, 14 Nov 2022 12:47:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 90C916B0082 for ; Mon, 14 Nov 2022 12:47:29 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3849A1C00E9 for ; Mon, 14 Nov 2022 17:47:29 +0000 (UTC) X-FDA: 80132779818.01.2D0FC60 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf16.hostedemail.com (Postfix) with ESMTP id D25F218000A for ; Mon, 14 Nov 2022 17:47:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=uC2or5Vi29/ILL+10ZunUsXoSK2kh2fnZB6/reHnjHU=; b=eixZyTc84zaknlvIhRid19qxBv 1ErWk6J1F6A5nX9R3Gq1xqT3S452frgG5qvxXsSeOBb29oqb9giLYMGzwt1BQiyS0zLW8CBJ7T3Wc IcuCuIc/FUMLYb5ikR7pyoIP9rkKawUPtzIzfCDacq+J+jMM1+wacfwbd1QwvRM/61TvXCaAWpUY2 802jFBXCWyQxTSBSpyQuqQcDQQNhh42Yc+zOMrBbx+8eYqwpHEuzS/O1Fb0+YRpeN3zmynbe1CdgV NTwTsYp8ECm3e504wlVNbiwLg5+K5+fFBAzx66zNmw6bTGiSwXvIKETxqE8S+/7/MdvalhTVu1d8G ZM9LI9Mg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oudYH-00FcPV-4x; Mon, 14 Nov 2022 17:47:21 +0000 Date: Mon, 14 Nov 2022 17:47:21 +0000 From: Matthew Wilcox To: Andy Shevchenko Cc: kernel test robot , Jakob Koschel , Greg Kroah-Hartman , Mathias Nyman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, oe-kbuild-all@lists.linux.dev, Kevin Cernekee , Andrew Morton , Linux Memory Management List Subject: Re: [PATCH v1 1/4] list: Introduce list_count() to count existing nodes Message-ID: References: <20221114112842.38565-1-andriy.shevchenko@linux.intel.com> <202211142350.i0ngTfIl-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668448048; a=rsa-sha256; cv=none; b=TxjwchU4KeIq0d9CT32F124i8KuyxGt/4ZBXo61IH2JEzrqwTTGPAOOQkBIMYvPwMVdGHP sYGO34RK0hE01GzppRJ5mDKfCUe1icEy1H9sgnk6rHyA8WvKvDT8sDySJvOdF2BJQV3LXY wb8tNB2DRkDOTEBRphJ2inqhY7d16L4= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=eixZyTc8; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668448048; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uC2or5Vi29/ILL+10ZunUsXoSK2kh2fnZB6/reHnjHU=; b=1O1DBYzL/9gJsZjURHEvZa9YArDlXNR28/A2+rRS1gCXs21qMfgLCutP7xGyQknsVg6nc1 +Rw0/qr8dViWtg+0/Ar/4rAvdPZXLkuCQdQUkqrbN4uqrUXwNdF0VhU+GSes43bkgP5QzK XDifKH1vEJHPamnZHFlm6Oi76DuIf6A= X-Stat-Signature: chsmuu5ryq6mc5hq9s465f6p5ita38ja X-Rspamd-Queue-Id: D25F218000A Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=eixZyTc8; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspamd-Server: rspam04 X-Rspam-User: X-HE-Tag: 1668448047-299867 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 14, 2022 at 06:03:00PM +0200, Andy Shevchenko wrote: > Oh, nice! I will fix this for v2. list_count() is an antipattern. I don't have any of the patches in my inbox, so maybe there's a great reason for doing this, but my immediate response is: NAK.