From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CCF7C433FE for ; Mon, 14 Nov 2022 08:37:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E8E316B0074; Mon, 14 Nov 2022 03:37:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E3D146B0075; Mon, 14 Nov 2022 03:37:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D2B7D6B0078; Mon, 14 Nov 2022 03:37:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C44176B0074 for ; Mon, 14 Nov 2022 03:37:50 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9706A40EAB for ; Mon, 14 Nov 2022 08:37:50 +0000 (UTC) X-FDA: 80131394700.04.C473D8D Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf16.hostedemail.com (Postfix) with ESMTP id 355C2180005 for ; Mon, 14 Nov 2022 08:37:50 +0000 (UTC) Received: by mail-pl1-f181.google.com with SMTP id c2so9411100plz.11 for ; Mon, 14 Nov 2022 00:37:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=82vXPJwHd8IviU31bXsxdXjyP52czxzjDA7v+DaUSmg=; b=jCx5gmGPI0Vp6C3g0MGiimRIwIfmUwI0uYSizF6FBiZfAvKXHoJV2aUVfyC9R+Bazr vKxMUD4WMArBQye+lOxpi+HPi+VikbQlIF44VJzJ9CTK0okCj/i4GhEJdANBtKWvvgiW 6qjP4mUe2uQfvpaO6BlLrgtSYlueMGtog7cPc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=82vXPJwHd8IviU31bXsxdXjyP52czxzjDA7v+DaUSmg=; b=T0XoxD30ed3S/jdHwV2sMlGvUvLIP0bECSCZb1B7aMRltkyoiJVrxHxTIKHcGNLtY4 t0SP0gHIBieRha2wN44qPQfGEhRh/tBzcz7kiMmimayHRxG+icZtAaVpju8dnZ4rhCEa F5HlTGe/Go3MG2YiN2RZsO6wkC2AJxdIs6JPBxt45H4AQTv1LXIHdWf74QQcAtQm3P5C E4k85eqDxqz49XrHKrslahpDawNzHFfBTU/BwKsxZ79EE3vNb55exXE+Brc4c9Hq7kBo 6nXZzV9PSCRZ71xdvjNQlz1U7SIcXPAw8xa3mRXjxbwe5RYLLKJvUX3iFhuc8/HaJPtZ AmsQ== X-Gm-Message-State: ANoB5pn822L3CCAXfds1ykqp244wgckWdxIkWiKNkVajbpjCpPSULnwP 1XeTHp9XCJxx7A0XEG2zHctCuA== X-Google-Smtp-Source: AA0mqf66wBNnymE8ORCnamKzCASzkbTJfPvO0J/lrYDn/VJwJMhjUPgTArRD31piDE0IAsWGK4t29w== X-Received: by 2002:a17:90a:5e09:b0:212:d299:4758 with SMTP id w9-20020a17090a5e0900b00212d2994758mr12697230pjf.120.1668415069162; Mon, 14 Nov 2022 00:37:49 -0800 (PST) Received: from google.com ([240f:75:7537:3187:68f5:86c0:dcaa:df5]) by smtp.gmail.com with ESMTPSA id 131-20020a621989000000b0056bc1d7816dsm6254460pfz.99.2022.11.14.00.37.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Nov 2022 00:37:48 -0800 (PST) Date: Mon, 14 Nov 2022 17:37:44 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Sergey Senozhatsky , Andrew Morton , Nitin Gupta , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv4 0/9] zsmalloc/zram: configurable zspage size Message-ID: References: <20221031054108.541190-1-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668415070; a=rsa-sha256; cv=none; b=ZDF1Ors3fCDDeZMPmvhFF5dmG5eamEa/phzXUXVi0d8Mxvldpt+XpsolP9ruoOW6sYP1/Z xfBrjpZU03ilApP/wbIbILT2vCQ+TaqJzSodJ5sSDPyOGL2/j/i/86H8Wr4New0NiUl4UH +tRaHwoUpds0/20c/7uwawziWZI/tVA= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=jCx5gmGP; spf=pass (imf16.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.181 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668415070; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=82vXPJwHd8IviU31bXsxdXjyP52czxzjDA7v+DaUSmg=; b=uCQlh3x4pACP/xqJQCk8mfDh+uvIj+YBGpUl6BNQ+Jq3KrZGggK7DAZE9+vQ57wYsHXLaR +t84PY/DITvtXh+O8P9Y0X8a6TVQAAVWjbO7DPy7a/s3wdT7UUhvBXsGugNezKGFuLkaH9 GkzA+7hQUMBFszlfcTpNVaqS6MSsCN8= X-Stat-Signature: 3hnziae1pexnzaepg3aegmndttte3pq5 Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=jCx5gmGP; spf=pass (imf16.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.181 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspamd-Server: rspam10 X-Rspam-User: X-Rspamd-Queue-Id: 355C2180005 X-HE-Tag: 1668415070-461030 X-Bogosity: Ham, tests=bogofilter, spamicity=0.107229, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (22/11/11 09:03), Minchan Kim wrote: [..] > for class in classes: > wasted_bytes += class->pages_per_zspage * PAGE_SIZE - an object size > > with *aggressive zpage compaction*. Now, we are relying on shrinker > (it might be already enough) to trigger but we could change the policy > wasted memory in the class size crossed a threshold That threshold can be another tunable in zramX/allocator_tunables sysfs knob and struct zs_tunables. But overall it sounds like a bigger project for some time next year. We already have zs_compact() sysfs knob, so user-space can invoke it as often as it wants to (not aware if anyone does btw), maybe new compaction should be something slightly different. I don't have any ideas yet. One way or the other it still can use the same sysfs knob :)