From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AC39C433FE for ; Mon, 14 Nov 2022 03:55:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DADEB6B0072; Sun, 13 Nov 2022 22:55:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D5D436B0073; Sun, 13 Nov 2022 22:55:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C257A6B0074; Sun, 13 Nov 2022 22:55:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B18256B0072 for ; Sun, 13 Nov 2022 22:55:11 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8E8AF803F3 for ; Mon, 14 Nov 2022 03:55:11 +0000 (UTC) X-FDA: 80130682422.06.4D7D93E Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by imf24.hostedemail.com (Postfix) with ESMTP id 349A518000A for ; Mon, 14 Nov 2022 03:55:10 +0000 (UTC) Received: by mail-pl1-f170.google.com with SMTP id d20so8948556plr.10 for ; Sun, 13 Nov 2022 19:55:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=t3GShZvQl4pEmRrtjPK8DlcTmZgRHU01e2znj5m/hEU=; b=elfcGsDxiPXwzz150co30bptffTx7enBnC3vjVcv3FUPjNOdHhD3FFwlo7U5yP7CLQ zlOLSdotYjmPq1VviLKiqDA2gL+JW70oOHGjJsEYBlz/vss8FTyqJ985KmAzrF1dmfMe RrgLx+u+qf/rKTM9ZvkHMzZc3Ifk1DJhG1i0w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=t3GShZvQl4pEmRrtjPK8DlcTmZgRHU01e2znj5m/hEU=; b=IYG/nNlqmk3hAGodwfvz52UkGSVJQhQ/hDW0dZ+4bIhvtUgSCLgEZBUOlIxrukZl5s hPJ6ivO+cW8ngsLl5fvPenJBokioulhvHPF7L07yFMct1OLWziYsUgFSCXcn2n/acz3W osP725aTjBjlKoMAXlkGGNDREBaZuzXwyIy1/lhXeV2NQOwW320EPt9JeATiV07PnO1R n1irnIp+hC7QwPet39+KykABvnTSVrCne1PR0UJsf/GOL6gxgdk7/1iCvy+jNLkBc9BT HBf3J0Rc0OOQDQyUHNnrNsAQaS1NcP3UZeoNV20I4V6BsWCFa424MX6wxwVTwZwOmNUE Ibbw== X-Gm-Message-State: ANoB5pnBsWOSGYuWwwK/JO453H1qhsahOvZgu8i9TI5OHz2F6Jcw5lS7 C52Evu4QTu6ExKiEG3RSvOCu3g== X-Google-Smtp-Source: AA0mqf6r+S/Po/KR0EubjPX0NCRKOxILcyqeQtRODXINN+i8Y+6OLxpxyxl3MwYy9KILMhNfeUkc+A== X-Received: by 2002:a17:90a:9a8f:b0:212:9625:c8e9 with SMTP id e15-20020a17090a9a8f00b002129625c8e9mr12089043pjp.128.1668398110344; Sun, 13 Nov 2022 19:55:10 -0800 (PST) Received: from google.com ([240f:75:7537:3187:68f5:86c0:dcaa:df5]) by smtp.gmail.com with ESMTPSA id d4-20020a170902654400b00188a23098aasm6041093pln.69.2022.11.13.19.55.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Nov 2022 19:55:09 -0800 (PST) Date: Mon, 14 Nov 2022 12:55:05 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Sergey Senozhatsky , Andrew Morton , Nitin Gupta , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv4 2/9] zsmalloc: turn zspage order into runtime variable Message-ID: References: <20221031054108.541190-1-senozhatsky@chromium.org> <20221031054108.541190-3-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668398111; a=rsa-sha256; cv=none; b=tTKsZe7QXz2XoNpsNXPPJ/l9jaqHSxf3IGv1NLemzcUFoGwWAOPtQ4tgYTinXBTXv5Umac XCJVBHuVnSOCw8d8jJURwzu98iNrDGh2bq/Wwig6JMAPHg786hQIckA2cTAGz2vnxfFR8g yhzQqXVVjL2kNvkVtowDveQp1mJFRBI= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=elfcGsDx; spf=pass (imf24.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.170 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668398111; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=t3GShZvQl4pEmRrtjPK8DlcTmZgRHU01e2znj5m/hEU=; b=mMfY3IZ3Airtj0+y/xmM/W/9prFsjBoYrcb59CsesJ2P1ymOP0ucpsv3Qrf2fOFP5h+O4k OmQmFVCzlQf1PdKz9+84Lpzm4Y06dCIA0NQwxiLzML95+0e8tdTjWnnNt5Cyx6jHd42sg5 RibpGQQg9bBh9kPsApujRe2w8CJzgfU= X-Stat-Signature: 8w5nf59cr1ewjibrb6694nzf3ss99p8d X-Rspamd-Queue-Id: 349A518000A Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=elfcGsDx; spf=pass (imf24.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.170 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspamd-Server: rspam04 X-Rspam-User: X-HE-Tag: 1668398110-879545 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (22/11/11 09:09), Minchan Kim wrote: > > [..] > > OK. Any reason why we don't want u32? I thought that > > s16/u16/s32/u32/etc. is the new normal. > > Oh, I didn't know the new normal. > > # ag u32 mm/ | wc -l > 65 > > Then, I'd like to use int to be consistent with others. OK. > > > Let's just use int instead of u32 > > > > > > Why do you need num_pages argument instead of using 1UL << ZS_DEFAULT_PAGE_ORDER? > > > It looks like static value. > > > > It is static right now, but in the a couple of patches it'll change to > > dynamic. > > Then, plase have the change in the patch you will use to review easier. OK.